Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix what can be modified via ReadWriteLogRecord #3907

Merged
merged 21 commits into from
Mar 28, 2024
Merged
Show file tree
Hide file tree
Changes from 15 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ release.
([#3852](https://github.com/open-telemetry/opentelemetry-specification/pull/3852))
- Add support for empty values.
([#3853](https://github.com/open-telemetry/opentelemetry-specification/pull/3853))
- Fix what can be modified via `ReadWriteLogRecord`.
([#3907](https://github.com/open-telemetry/opentelemetry-specification/pull/3907))

### Resource

Expand Down
19 changes: 14 additions & 5 deletions specification/logs/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,20 @@ value type.

### ReadWriteLogRecord

A function receiving this as an argument MUST be able to write to the
full [LogRecord](data-model.md#log-and-event-record-definition) and additionally MUST be able to retrieve all
information
that was added to the `LogRecord` (as with
[ReadableLogRecord](#readablelogrecord)).
ReadWriteLogRecord is a superset of [ReadableLogRecord](#readablelogrecord).

A function receiving this as an argument MUST additionally be able to modify
the following information added to the [LogRecord](data-model.md#log-and-event-record-definition):

* `Timestamp`
* `ObservedTimestamp`
* `SeverityText`
* `SeverityNumber`
* `Body`
* `Attributes` (addition, modification, removal)
* `TraceId`
* `SpanId`
* `TraceFlags`
pellared marked this conversation as resolved.
Show resolved Hide resolved

## LogRecord Limits

Expand Down
Loading