Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-metrics] Mention of 'context' w/o definition. #352

Closed
ghost opened this issue Nov 12, 2019 · 4 comments
Closed

[api-metrics] Mention of 'context' w/o definition. #352

ghost opened this issue Nov 12, 2019 · 4 comments
Labels
spec:metrics Related to the specification/metrics directory

Comments

@ghost
Copy link

ghost commented Nov 12, 2019

Under Gauge, there is the following sentence: "The only difference between Observer and ordinary gauges is that their events do not have an associated OpenTelemetry context". https://github.com/open-telemetry/opentelemetry-specification/blob/27b738b74eeb10560dc0308554a1d626cb93df79/specification/api-metrics.md

What is an "OpenTelemetry context"?

@jmacd
Copy link
Contributor

jmacd commented Nov 13, 2019

The terminology for distributed context has been shifting in the spec. In this context it refers to the correlation context and trace context. Observer metrics were supposed to have been removed from the spec entirely in order to tighten up their definition, but this statement will hold true. Observer metrics are set from a context-free callback and therefore cannot be associated with correlation or trace context. Please refer to https://github.com/open-telemetry/oteps/blob/master/text/0008-metric-observer.md

@ghost
Copy link
Author

ghost commented Nov 13, 2019

So does that mean the observer should be removed from the spec until the otep migrates from "proposed" to "accepted"?

@jmacd
Copy link
Contributor

jmacd commented Nov 13, 2019

I think we should mark the OTEP as accepted. @bogdandrutu and I realized the specification wasn't complete, related to specifics about calling conventions for Observer metrics. It's fine to remove from the spec (it was an oversight), but it will come back.

I (perhaps stubbornly) am refusing to write any new metrics-related OTEPs until the three outstanding PRs are resolved:
open-telemetry/oteps#49
open-telemetry/oteps#61
open-telemetry/oteps#62

@jmacd jmacd added the spec:metrics Related to the specification/metrics directory label Nov 25, 2019
@jmacd
Copy link
Contributor

jmacd commented Feb 20, 2020

This was addressed in the updates of #430.

@jmacd jmacd closed this as completed Feb 20, 2020
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

No branches or pull requests

1 participant