Combined Metrics API updates for v0.3 (Add Observer instrument, remove Gauge instrument, etc.) #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
songy23,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
Closed
|
I've added a couple pages of examples. |
yurishkuro
reviewed
Jan 31, 2020
jmacd
changed the title
jmacd
commented
Feb 3, 2020
jmacd
commented
Feb 4, 2020
yurishkuro
approved these changes
Feb 12, 2020
bogdandrutu
reviewed
Feb 13, 2020
This was referenced Feb 13, 2020
34 tasks
|
suggest renaming this PR because I have been not watching changes assuming the title made it self-evident what has been going on here. This looks way bigger than the title suggests. |
jmacd
changed the title
|
@dyladan You're right. I've added more detail in the title. |
|
@bogdandrutu Please take another look. |
|
@dyladan I looks big, you're right. There is a lot of philosophical justification here for removing Gauge and adding Observer. That's really just ab out all that's happened here. |
tylerbenson
reviewed
Feb 13, 2020
bogdandrutu
approved these changes
Feb 14, 2020
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
…e Gauge instrument, etc.) (open-telemetry#430) * Gauge/Observer rewrite pt 1 * Checkpoint * Checkpoint * Optional features restored * Update selection process * Update TOC * Reword intro para on standard impl * Add detail on label set * Add examples * Misspellings * Rewrite the introductory material * Add a section on time * Clarify 'standard implementation' and 'default interpretation' * Explain aggregations; Discourage timestamp use * Reword the metric event format * Update Counter and Measure * Update Observer (partial) * Remove options, discuss views API * Fixes * Fixes * Fixes * Rename BoundTimer * Typos and suggestions * Reword global Meter * Rearrange early paragraphs * Use _run time_ and _simultaneous_ * Rearrange early paragraphs (again) * Define _run time_ * These * Iterate * Remove a TODO * More on global/named meters * Difference, Capture * Timer wording * Explicit timestamp * Rewrite simultaneous * Example: active requests * Synchronously * Wording * Example using correlation context * Detail on WithKeys * Counter is a special case * Counter fixes; typo * Typo * Split the leading example into Counter and Measure cases * Remove poor example * Update TOC * Add note about Observer and Context * Add note about context-freedom in Observer * Run MDL * WithRecommendedKeys * Typo * Address most of Bogdan's feedback * Typo Co-authored-by: Bogdan Drutu <lazy@splunk.com>
This was referenced Feb 20, 2020
37 tasks
34 tasks
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specifies the changes described in these OTEPs:
open-telemetry/oteps#80
open-telemetry/oteps#72