-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 0009-metric-handles to match current spec #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saw the comment about LabelSets. Reviewing OTEPs in retrospective is difficult, so as long as the linking is evident it should be good.
For anyone else struggling to keep up with metrics work: open-telemetry/opentelemetry-specification#299 made significant changes to the metrics spec that weren't yet described by OTEP 0009. The specs PR was informed by go prototypes at open-telemetry/opentelemetry-go#100 and open-telemetry/opentelemetry-go#172. The specs changes were merged, but the OTEP was still "proposed" (i.e. not yet "accepted"). In the meantime #49 was merged, and the process was changed (in #55) so that OTEPs wouldn't be merged until they were "accepted". This PR revises the OTEP and moves it to "accepted". Usually the next step would be to edit the spec to reflect the OTEP, but in this case that's already done. |
Thank you. I will merge this tomorrow. |
This has the required number of approvals. |
* Update 0008 and accept
* Update 0008 and accept
* Update 0008 and accept
This OTEP reflected a relatively-complicated association between instruments, their recommended keys, and handles. Much of this text was no longer needed. In particular, a large "Trade-offs and mitigations" block of text was completely rewritten as 0049-metric-label-set.md.
This brings this OTEP into line with the current spec. I believe there are no significant discrepancies between this and the current spec. In a future OTEP I will propose the renaming of "Handle" to "Bound instrument". Note, however, that "Handle" is not a recommended type name, it is only a concept. Each kind of instrument has a distinct type of handle, but in discussing this feature, we will use "Bound instrument" in the future.