Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add measurement consumer #2339

Merged
merged 14 commits into from
Jan 13, 2022
Merged

Add measurement consumer #2339

merged 14 commits into from
Jan 13, 2022

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Dec 17, 2021

Fixes #2326

@ocelotl ocelotl self-assigned this Dec 17, 2021
@ocelotl ocelotl requested a review from a team December 17, 2021 21:32
@ocelotl ocelotl mentioned this pull request Jan 12, 2022
Open
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 12, 2022
@lzchen lzchen removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 12, 2022
@lzchen
Copy link
Contributor

lzchen commented Jan 12, 2022

@ocelotl
Why are we skipping changelog for this pr?

@ocelotl
Copy link
Contributor Author

ocelotl commented Jan 12, 2022

I am skipping changelogs for all metrics components because they are still private

aabmass
aabmass requested changes Jan 12, 2022
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocking bug

opentelemetry-sdk/src/opentelemetry/sdk/_metrics/instrument.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/measurement_consumer.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/measurement_consumer.py Outdated Show resolved Hide resolved
opentelemetry-sdk/tests/metrics/test_measurement_consumer.py Outdated Show resolved Hide resolved
opentelemetry-sdk/tests/metrics/test_measurement_consumer.py Outdated Show resolved Hide resolved
opentelemetry-sdk/tests/metrics/test_measurement_consumer.py Outdated Show resolved Hide resolved
@lzchen lzchen added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 12, 2022
@ocelotl ocelotl requested a review from aabmass January 12, 2022 23:59
@ocelotl ocelotl added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Jan 13, 2022
@ocelotl ocelotl mentioned this pull request Jan 13, 2022
Closed
@ocelotl ocelotl merged commit 6a88987 into open-telemetry:main Jan 13, 2022
@ocelotl ocelotl deleted the issue_2326 branch January 13, 2022 19:54
@ocelotl ocelotl mentioned this pull request Jan 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@aabmass aabmass aabmass approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees

@ocelotl ocelotl

Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary metrics Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MeasurementConsumer to metrics SDK
4 participants
@ocelotl @lzchen @aabmass @srikanthccv