Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MeasurementConsumer to metrics SDK #2326

Closed
aabmass opened this issue Dec 14, 2021 · 0 comments · Fixed by #2339
Closed

Add MeasurementConsumer to metrics SDK #2326

aabmass opened this issue Dec 14, 2021 · 0 comments · Fixed by #2339
Assignees
Labels
1.10.0rc1 release candidate 1 for metrics GA metrics sdk Affects the SDK package.

Comments

@aabmass
Copy link
Member

aabmass commented Dec 14, 2021

See design doc section on MeasurementConsumer. For this issue:

  • Create ABC MeasurementConsumer interface and an empty implementation of DefaultMeasurementConsumer (implementation is tracked in Implement DefaultMeasurementConsumer #2328).
  • Add a member measurement_consumer: MeasurementConsumer on MeterProvider
  • Wire instruments to call into its methods (e.g. Counter.add() should pass measurement to measurement_consumer.consume_measurement())
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.10.0rc1 release candidate 1 for metrics GA metrics sdk Affects the SDK package.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants