Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a mechanism to select the measurement consumer #2365

Open
ocelotl opened this issue Jan 12, 2022 · 3 comments
Open

Define a mechanism to select the measurement consumer #2365

ocelotl opened this issue Jan 12, 2022 · 3 comments
Labels

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Jan 12, 2022

Ok, but I think that we will need a mechanism to do that. Opening a corresponding issue.

Originally posted by @ocelotl in #2339 (comment)

@lzchen lzchen added 1.10.0rc1 release candidate 1 for metrics GA metrics labels Jan 12, 2022
@ocelotl ocelotl self-assigned this Jan 14, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jan 14, 2022
@aabmass
Copy link
Member

aabmass commented Jan 14, 2022

I don't think we need to tackle this for a while. MeasurementConsumer is not part of the spec and we don't need to publicly expose it or allow users to implement it right now. Once we have good confidence in it, maybe we should open it up, but I'd rather keep it private and have the freedom to tweak things even after a stable release.

@ocelotl
Copy link
Contributor Author

ocelotl commented Jan 18, 2022

As far as I understand, the design is based on the idea of MeasurementConsumer being a component that can be replaced by another implementation. If that is the case, then don't we need a way to let the user select the implementation? 🤷

@aabmass
Copy link
Member

aabmass commented Jan 19, 2022

At some point that's the idea. For now, we don't need to expose any of the MeasurementConsumer stuff to the user/public API.

@lzchen lzchen removed the 1.10.0rc1 release candidate 1 for metrics GA label Jan 20, 2022
@ocelotl ocelotl removed their assignment Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants