Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release proposal v1.0.1 #2609

Closed
wants to merge 2 commits into from

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 9, 2021

🚀 (Enhancement)

  • Other
    • #2465 fix: prefer globalThis instead of window to support webworkers (@legendecas)
  • opentelemetry-semantic-conventions
    • #2532 feat(@opentelemetry/semantic-conventions): change enum to object literals (@echoontheway)
    • #2528 feat: upgrade semantic-conventions to latest v1.7.0 spec (@weyert)
  • opentelemetry-core, opentelemetry-sdk-trace-base

🐛 (Bug Fix)

  • Other
  • opentelemetry-exporter-zipkin
    • #2519 fix(exporter-zipkin): correct status tags names (@t2t2)

📚 (Refine Doc)

🏠 (Internal)

  • opentelemetry-sdk-trace-base, opentelemetry-sdk-trace-node, opentelemetry-sdk-trace-web
  • Other
  • opentelemetry-context-async-hooks, opentelemetry-context-zone-peer-dep, opentelemetry-core, opentelemetry-exporter-jaeger, opentelemetry-exporter-zipkin, opentelemetry-propagator-b3, opentelemetry-propagator-jaeger, opentelemetry-resources, opentelemetry-sdk-trace-base, opentelemetry-sdk-trace-node, opentelemetry-sdk-trace-web, opentelemetry-shim-opentracing
  • opentelemetry-core

Committers: 20

@dyladan dyladan requested a review from a team November 9, 2021 19:51
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #2609 (fe2eb52) into main (61cfbfe) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head fe2eb52 differs from pull request most recent head 0fa3891. Consider uploading reports for the commit 0fa3891 to get more accurate results

@@            Coverage Diff             @@
##             main    #2609      +/-   ##
==========================================
- Coverage   93.04%   93.00%   -0.05%     
==========================================
  Files         138      138              
  Lines        5093     5092       -1     
  Branches     1096     1095       -1     
==========================================
- Hits         4739     4736       -3     
- Misses        354      356       +2     
Impacted Files Coverage Δ
...entelemetry-instrumentation/src/instrumentation.ts 70.37% <0.00%> (-7.41%) ⬇️
...entelemetry-instrumentation/src/autoLoaderUtils.ts 91.66% <0.00%> (-0.34%) ⬇️

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, any chance to release experimental packages too ?

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I see in description my PR - changes in experimental only which is listed here but not released, why is that ?
this one -> #2584

@obecny obecny self-requested a review November 9, 2021 20:08
@vmarchaud
Copy link
Member

hmm I see in description my PR - changes in experimental only which is listed here but not released, why is that ?

I believe because we don't release experimental at the same time of core packages ?

@dyladan
Copy link
Member Author

dyladan commented Nov 10, 2021

hmm I see in description my PR - changes in experimental only which is listed here but not released, why is that ? this one -> #2584

The automated changelog tool isn't smart enough to know the difference between experimental and stable PRs so I had to do my best to remove the experimental ones and just missed one. I'll remove it.

hmm I see in description my PR - changes in experimental only which is listed here but not released, why is that ?

I believe because we don't release experimental at the same time of core packages ?

I was thinking about this. What would you think of a single PR which released experimental and stable? Then the changelog generation is a little easier and we don't have to go through the PR process twice for a single release?

@vmarchaud
Copy link
Member

I was thinking about this. What would you think of a single PR which released experimental and stable? Then the changelog generation is a little easier and we don't have to go through the PR process twice for a single release?

I checked on the other PR but the experimental will not depend on latest core if we do this, that means some experimental pkgs won't have latest bug fixes. I think its better to split them, WDYT ?

@dyladan
Copy link
Member Author

dyladan commented Nov 10, 2021

I was thinking about this. What would you think of a single PR which released experimental and stable? Then the changelog generation is a little easier and we don't have to go through the PR process twice for a single release?

I checked on the other PR but the experimental will not depend on latest core if we do this, that means some experimental pkgs won't have latest bug fixes. I think its better to split them, WDYT ?

I can update the core deps in this PR. It just means I have to run the release command for core before experimental which I would have had to do anyway so it's no different.

@dyladan dyladan closed this Nov 10, 2021
@dyladan
Copy link
Member Author

dyladan commented Nov 10, 2021

I was thinking about this. What would you think of a single PR which released experimental and stable? Then the changelog generation is a little easier and we don't have to go through the PR process twice for a single release?

I checked on the other PR but the experimental will not depend on latest core if we do this, that means some experimental pkgs won't have latest bug fixes. I think its better to split them, WDYT ?

I updated the other PR. Take a look there. if you still have doubts we can reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants