-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding selenium tests with browserstack #2570
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2570 +/- ##
=======================================
Coverage 93.00% 93.00%
=======================================
Files 138 138
Lines 5092 5092
Branches 1095 1095
=======================================
Hits 4736 4736
Misses 356 356 |
3b31f9d
to
422253a
Compare
Looks like selenium isn't compatible with node 8. We can either skip it in the bootstrap on node 8 or we can drop support for node 8 unless you have another option. Node 16 is a little different. Looks like a dependency mismatch with the hoisting due to the new peer dependency handling in node 16 |
I wasn't sure how to do it (skip it in the bootstrap on node 8) , any example ? |
I think you should be able to just add |
Which problem is this PR solving?
Adding selenium test with browserstack
Short description of the changes
This is first part to be able to run tests either locally with local browser or using local server and browser stack (this requires account on browserstack)
Next step will be to add github action to run tests automatically with browserstack. Can be done once this is merged and we decide how and when we want to run it