-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Move upgrade propagator notes to correct section #2579
Merged
obecny
merged 6 commits into
open-telemetry:main
from
NathanielRN:fix--put-upgrade-guide-to-rename-propagator-in-correct-section
Nov 2, 2021
Merged
doc: Move upgrade propagator notes to correct section #2579
obecny
merged 6 commits into
open-telemetry:main
from
NathanielRN:fix--put-upgrade-guide-to-rename-propagator-in-correct-section
Nov 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in-correct-section
dyladan
approved these changes
Nov 2, 2021
…in-correct-section
obecny
reviewed
Nov 2, 2021
Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com>
…in-correct-section
obecny
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thx for changes
dyladan
reviewed
Nov 2, 2021
dyladan
changed the title
fix: Move upgrade propagator notes to correct section
doc: Move upgrade propagator notes to correct section
Nov 2, 2021
NathanielRN
deleted the
fix--put-upgrade-guide-to-rename-propagator-in-correct-section
branch
November 5, 2021 18:38
This was referenced Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The OTel JS 0.26.0 release notes say that the propagator was renamed in
0.26.0
while the README upgrade guidelines says it was done in 0.25.0.Short description of the changes
It seems like the release notes are correct in this case so this PR fixes that.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
N/A
Checklist: