Reduce volatile reads in GlobalOpenTelemetry.get #4009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
bogdandrutu,
carlosalberto,
jack-berg,
jkwatson and
jsuereth
as code owners
Codecov Report
@@ Coverage Diff @@
## main #4009 +/- ##
============================================
+ Coverage 89.87% 89.91% +0.04%
- Complexity 4275 4277 +2
============================================
Files 512 512
Lines 12942 12944 +2
Branches 1250 1251 +1
============================================
+ Hits 11632 11639 +7
+ Misses 906 903 -3
+ Partials 404 402 -2
Continue to review full report at Codecov.
|
trask
approved these changes
Dec 17, 2021
bogdandrutu
approved these changes
Dec 17, 2021
| synchronized (mutex) { | ||
| if (globalOpenTelemetry == null) { | ||
| openTelemetry = globalOpenTelemetry; | ||
| if (openTelemetry == null) { | ||
|
|
||
| OpenTelemetry autoConfigured = maybeAutoConfigure(); |
There was a problem hiding this comment.
not related to your change (probably in a separate PR), if maybeAutoConfigure can be renamed would be good to have it as makeAutoConfigureAndSet because it is confusing that you don't set on that path.
jkwatson
approved these changes
Dec 17, 2021
jsuereth
approved these changes
Dec 17, 2021
jack-berg
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.