-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce volatile reads in GlobalOpenTelemetry.get #4009
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4009 +/- ##
============================================
+ Coverage 89.87% 89.91% +0.04%
- Complexity 4275 4277 +2
============================================
Files 512 512
Lines 12942 12944 +2
Branches 1250 1251 +1
============================================
+ Hits 11632 11639 +7
+ Misses 906 903 -3
+ Partials 404 402 -2
Continue to review full report at Codecov.
|
synchronized (mutex) { | ||
if (globalOpenTelemetry == null) { | ||
openTelemetry = globalOpenTelemetry; | ||
if (openTelemetry == null) { | ||
|
||
OpenTelemetry autoConfigured = maybeAutoConfigure(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related to your change (probably in a separate PR), if maybeAutoConfigure
can be renamed would be good to have it as makeAutoConfigureAndSet
because it is confusing that you don't set on that path.
No description provided.