Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce volatile reads in GlobalOpenTelemetry.get #4009

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Reduce volatile reads in GlobalOpenTelemetry.get #4009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions api/all/src/main/java/io/opentelemetry/api/GlobalOpenTelemetry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,11 @@ private GlobalOpenTelemetry() {}
* interface FQCN but the specified provider cannot be found.
*/
public static OpenTelemetry get() {
if (globalOpenTelemetry == null) {
OpenTelemetry openTelemetry = globalOpenTelemetry;
if (openTelemetry == null) {
synchronized (mutex) {
if (globalOpenTelemetry == null) {
openTelemetry = globalOpenTelemetry;
if (openTelemetry == null) {

OpenTelemetry autoConfigured = maybeAutoConfigure();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to your change (probably in a separate PR), if maybeAutoConfigure can be renamed would be good to have it as makeAutoConfigureAndSet because it is confusing that you don't set on that path.

if (autoConfigured != null) {
Expand All @@ -65,7 +67,7 @@ public static OpenTelemetry get() {
}
}
}
return globalOpenTelemetry;
return openTelemetry;
}

/**
Expand Down