Reduce volatile reads in GlobalOpenTelemetry.get (#4009)

open-telemetry · Dec 21, 2021 · d88b09c · d88b09c
1 parent 4fbcc5c
commit d88b09c
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/api/all/src/main/java/io/opentelemetry/api/GlobalOpenTelemetry.java b/api/all/src/main/java/io/opentelemetry/api/GlobalOpenTelemetry.java
@@ -51,9 +51,11 @@ private GlobalOpenTelemetry() {}
    *     interface FQCN but the specified provider cannot be found.
    */
   public static OpenTelemetry get() {
-    if (globalOpenTelemetry == null) {
+    OpenTelemetry openTelemetry = globalOpenTelemetry;
+    if (openTelemetry == null) {
       synchronized (mutex) {
-        if (globalOpenTelemetry == null) {
+        openTelemetry = globalOpenTelemetry;
+        if (openTelemetry == null) {
 
           OpenTelemetry autoConfigured = maybeAutoConfigure();
           if (autoConfigured != null) {
@@ -65,7 +67,7 @@ public static OpenTelemetry get() {
         }
       }
     }
-    return globalOpenTelemetry;
+    return openTelemetry;
   }
 
   /**