-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelgrpc: Add metrics support for stats handler #4316
Comments
@fatsheep9146 Can you take this? |
It would be good to solve #4323 before this or as part of this issue. |
I'm happy to work on this if it means implementing an |
I'm already working on this issue now, and before this work is merged, the #4323 should also be fixed, I'm now fixing the #4323 first. @Sovietaced I think you could help review and add more meaningful metric after this issue is done if you want. |
I think metric is the only missing feature, since I wrote a simple e2e test
TestStatsHandler
just like interceptors to make sure the trace related function is complete.@pellared
Originally posted by @fatsheep9146 in #3002 (comment)
The text was updated successfully, but these errors were encountered: