Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelgrpc: Deprecate the interceptors #4318

Closed
pellared opened this issue Sep 18, 2023 · 3 comments · Fixed by #4534
Closed

otelgrpc: Deprecate the interceptors #4318

pellared opened this issue Sep 18, 2023 · 3 comments · Fixed by #4534
Labels
area: instrumentation Related to an instrumentation package instrumentation: otelgrpc
Milestone

Comments

@pellared
Copy link
Member

pellared commented Sep 18, 2023

I think we should also update the existing examples to use the new instrumentation.

I propose to:

  1. Merge this PR
  2. Create an issue for https://github.com/open-telemetry/opentelemetry-go-contrib/pull/3002/files#r1209293763
  3. Update the existing examples to use the new functionality.
  4. Deprecate the interceptors so that they are available in next release.
  5. After the next release remove the interceptors.

@open-telemetry/go-approvers please upvote/downvote if you agree or not. Feel free to leave any additional feedback.

Originally posted by @pellared in #3002 (review)

  1. Blocked by otelgrpc: Add metrics support for stats handler #4316
  2. Deprecate the interceptors
  3. Update the docs so that grpc.StatsHandler is the first-class citizen
@pellared pellared added this to the v0.45.0 milestone Sep 18, 2023
@pellared pellared added area: instrumentation Related to an instrumentation package instrumentation: otelgrpc labels Sep 18, 2023
@dashpole

This comment was marked as resolved.

@pellared
Copy link
Member Author

FYI @fatsheep9146

@pellared

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package instrumentation: otelgrpc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants