-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelgrpc: Add metrics tests for ServerStreamInterceptors #4323
Comments
opentelemetry-go-contrib/instrumentation/google.golang.org/grpc/otelgrpc/interceptor.go Lines 449 to 499 in b39f96e
I found that the ServerStreamInterceptors do not produce metric for now, only ServerUnaryInterceptors support, do we need add metrics support for ServerStreamInterceptors and then add test for it? Or should we directly support metrics in StatsHandler , since interceptors will be deprecated in some day.
|
I think that we wanted to add tests for metrics emitted by server interceptors. I propose to leave implementation and just add assertions for metrics emitted by the interceptors. You can consider adding an assertion showing that I think adding support for metrics in @MadVikingGod do you agree? |
I was under the impression that the different Interceptors were being deprecated, if that's the case, then I don't think any functionality should be added. I think there should be some testing around what metrics (if any) are put out by both the stat's handler and the interceptors, and peer Attributes must be part of that dataset. |
Closing per #4318 |
Problem Statement
There are two problems discovered in #4322:
peerInfo
within the call made. This means that peer info will not show in tests, but does show in actual use.Proposed Solution
Write a test similar to checkUnaryServerRecords to assert that the produced metrics match
Change the test such that it does have peerInfo within it's context
The text was updated successfully, but these errors were encountered: