You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that the stats handler misses the functionality you added here: #2700. Any reasons for that?
I was plan to implement the stats.handler step by step, cover the trace first, and then cover the metrics. Which is also convenient for review.
Do you think I should implement it in this pr or create another pr for metrics?
I'm open for both way. @pellared
During the SIG meetings we discussed that we would like to have a feature-parity before we deprecate interceptors as part of #3002 (review).
Still I think we can tackle it in a separate PR.
Are there any other features which are missing when comparing with the interceptors?
I think metric is the only missing feature, since I wrote a simple e2e test TestStatsHandler just like interceptors to make sure the trace related function is complete. @pellared
I think metric is the only missing feature, since I wrote a simple e2e test
TestStatsHandler
just like interceptors to make sure the trace related function is complete.@pellared
Originally posted by @fatsheep9146 in #3002 (comment)
The text was updated successfully, but these errors were encountered: