-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify error scenario logic #1657
Merged
julianocosta89
merged 3 commits into
open-telemetry:main
from
beeme1mr:simplify-flag-config
Jul 8, 2024
Merged
Simplify error scenario logic #1657
julianocosta89
merged 3 commits into
open-telemetry:main
from
beeme1mr:simplify-flag-config
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
github-actions
bot
added
docs-update-required
Requires documentation update
helm-update-required
Requires an update to the Helm chart when released
labels
Jul 3, 2024
I'll be away for a few days, but I've chatted with @dyladan about this. He has access to my fork and can help in my absence. |
puckpuck
approved these changes
Jul 5, 2024
julianocosta89
approved these changes
Jul 8, 2024
eliasmueller
pushed a commit
to UST-DeMAF/opentelemetry-demo
that referenced
this pull request
Jul 14, 2024
* remove fractional config from rule definition Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com> * add random failure logic to ad service Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com> * add random failure logic to cart service Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com> --------- Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
ahealy-newr
pushed a commit
to ahealy-newr/opentelemetry-demo-ahealy
that referenced
this pull request
Jul 24, 2024
* remove fractional config from rule definition Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com> * add random failure logic to ad service Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com> * add random failure logic to cart service Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com> --------- Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs-update-required
Requires documentation update
helm-update-required
Requires an update to the Helm chart when released
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Moved the random failure logic outside of the flag configuration and into the service. This simplifies the flag configuration and guarantees the behavior matches what's defined in the docs.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.
Addresses