-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set OTLP receiver endpoint #1662
Merged
puckpuck
merged 4 commits into
open-telemetry:main
from
julianocosta89:chore-set-otelcol-receiver-endpoint
Jul 12, 2024
Merged
Set OTLP receiver endpoint #1662
puckpuck
merged 4 commits into
open-telemetry:main
from
julianocosta89:chore-set-otelcol-receiver-endpoint
Jul 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
helm-update-required
Requires an update to the Helm chart when released
label
Jul 11, 2024
julianocosta89
changed the title
Set OTelCol receiver endpoint
Set OTLP receiver endpoint
Jul 11, 2024
rogercoll
reviewed
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use env variables instead?
Co-authored-by: Roger Coll <roger.coll@elastic.co>
rogercoll
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
puckpuck
approved these changes
Jul 12, 2024
eliasmueller
pushed a commit
to UST-DeMAF/opentelemetry-demo
that referenced
this pull request
Jul 14, 2024
* Set OTelCol receiver endpoint * changelog * Apply suggestions from code review Co-authored-by: Roger Coll <roger.coll@elastic.co> * Add env vars to collector container --------- Co-authored-by: Roger Coll <roger.coll@elastic.co>
ahealy-newr
pushed a commit
to ahealy-newr/opentelemetry-demo-ahealy
that referenced
this pull request
Jul 24, 2024
* Set OTelCol receiver endpoint * changelog * Apply suggestions from code review Co-authored-by: Roger Coll <roger.coll@elastic.co> * Add env vars to collector container --------- Co-authored-by: Roger Coll <roger.coll@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The default endpoints for all servers in the OTel Collector have changed to use localhost instead of 0.0.0.0.
If we keep the default, it won't work for Docker compose anymore.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additions[ ] Appropriate documentation updates in the docs[ ] Appropriate Helm chart updates in the helm-chartsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.