-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otel-col] Add docker stats receiver #1650
Merged
puckpuck
merged 5 commits into
open-telemetry:main
from
julianocosta89:otelcol-add-dockerstatsreceiver
Jul 2, 2024
Merged
[otel-col] Add docker stats receiver #1650
puckpuck
merged 5 commits into
open-telemetry:main
from
julianocosta89:otelcol-add-dockerstatsreceiver
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
helm-update-required
Requires an update to the Helm chart when released
label
Jul 1, 2024
julianocosta89
changed the title
Add docker stats receiver
[otel-col] Add docker stats receiver
Jul 1, 2024
rogercoll
reviewed
Jul 2, 2024
Co-authored-by: Roger Coll <roger.coll@elastic.co>
julianocosta89
removed
helm-update-required
Requires an update to the Helm chart when released
labels
Jul 2, 2024
mviitane
approved these changes
Jul 2, 2024
rogercoll
approved these changes
Jul 2, 2024
This is a great change; it will lead to a few more things being needed, like Grafana dashboards and what we do about similar functionality in a K8s world. I'll create an issue so we can track the follow-up tasks. |
4 tasks
joshleecreates
pushed a commit
to joshleecreates/opentelemetry-demo
that referenced
this pull request
Jul 7, 2024
* Add docker stats receiver * changelog * Nit: prevent write access to the Docker socket Co-authored-by: Roger Coll <roger.coll@elastic.co> * Add compose minimal --------- Co-authored-by: Roger Coll <roger.coll@elastic.co>
eliasmueller
pushed a commit
to UST-DeMAF/opentelemetry-demo
that referenced
this pull request
Jul 14, 2024
* Add docker stats receiver * changelog * Nit: prevent write access to the Docker socket Co-authored-by: Roger Coll <roger.coll@elastic.co> * Add compose minimal --------- Co-authored-by: Roger Coll <roger.coll@elastic.co>
ahealy-newr
pushed a commit
to ahealy-newr/opentelemetry-demo-ahealy
that referenced
this pull request
Jul 24, 2024
* Add docker stats receiver * changelog * Nit: prevent write access to the Docker socket Co-authored-by: Roger Coll <roger.coll@elastic.co> * Add compose minimal --------- Co-authored-by: Roger Coll <roger.coll@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds the
docker_stats
receiver to the demo.This receiver is meant to be used only when running locally on Docker.
For that to work we need privileged access to docker sock:
I've also added Prometheus receiver to get internal Collector Metrics.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsAppropriate documentation updates in the docsAppropriate Helm chart updates in the helm-chartsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.