Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for periodic reader interval/timeout #8096

Conversation

codeboten
Copy link
Contributor

This adds support for configuring timeout and interval options for the periodic metric exporter.

Linked issue: #7641

@codeboten codeboten requested review from a team and mx-psi July 17, 2023 18:09
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7996c45) 90.54% compared to head (10f0102) 90.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8096   +/-   ##
=======================================
  Coverage   90.54%   90.55%           
=======================================
  Files         301      301           
  Lines       15311    15317    +6     
=======================================
+ Hits        13864    13870    +6     
  Misses       1161     1161           
  Partials      286      286           
Impacted Files Coverage Δ
service/internal/proctelemetry/config.go 94.69% <100.00%> (+0.29%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

This adds support for configuring `timeout` and `interval` options for the periodic metric exporter.

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten force-pushed the codeboten/add-periodic-internal-timeout branch from 0086600 to 10f0102 Compare July 17, 2023 21:04
@codeboten codeboten merged commit 8949d1d into open-telemetry:main Jul 17, 2023
@codeboten codeboten deleted the codeboten/add-periodic-internal-timeout branch July 17, 2023 22:19
@github-actions github-actions bot added this to the next release milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants