[pdata] Rename ValueAtQuantile to SummaryDataPointValueAtQuantile #6262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
rename-ValueAtQuantile
branch
from
aacf1fb
to
e64c13f
Compare
Codecov ReportBase: 92.30% // Head: 92.30% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6262 +/- ##
==========================================
- Coverage 92.30% 92.30% -0.01%
==========================================
Files 219 219
Lines 13463 13455 -8
==========================================
- Hits 12427 12419 -8
Misses 806 806
Partials 230 230
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bogdandrutu
approved these changes
Oct 8, 2022
|
@dmitryax please rebase |
Rename `pmetric.[New]?ValueAtQuantile[Slice]?` structs and functionas to align them with the underlying protobuf messages. It should have SummaryDataPoint prefix as they are defined in the scope of SummaryDataPoint protobuf message.
dmitryax
force-pushed
the
rename-ValueAtQuantile
branch
from
8ae98be
to
6ef479e
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
pmetric.[New]?ValueAtQuantile[Slice]?structs and functions to align them with the underlying protobuf messages. It should haveSummaryDataPointprefix as they are defined in the scope ofSummaryDataPointprotobuf message.Updates #6257