Skip to content

Commit

Permalink
[pdata] Rename ValueAtQuantile to SummaryDataPointValueAtQuantile
Browse files Browse the repository at this point in the history
Rename `pmetric.[New]?ValueAtQuantile[Slice]?` structs and functionas to align them with the underlying protobuf messages. It should have SummaryDataPoint prefix as they are defined in the scope of SummaryDataPoint protobuf message.
  • Loading branch information
dmitryax committed Oct 8, 2022
1 parent fca25f2 commit e64c13f
Show file tree
Hide file tree
Showing 6 changed files with 129 additions and 116 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
- Deprecate `pcommon.NewValueString` in favor of `pcommon.NewValueStr` (#6209)
- Deprecate `pmetric.MetricAggregationTemporality` enum type in favor of `pmetric.AggregationTemporality` (#6249)
- Deprecate `confmap.Conf.UnmarshalExact` in favor of `confmap.Conf.Unmarshal(.., WithErrorUnused)` (#6231)
- Deprecate `pmetric.[New]?ValueAtQuantile[Slice]?` in favor of `pmetric.[New]?SummaryDataPointValueAtQuantile[Slice]?` (#6262)

### 💡 Enhancements 💡

Expand Down
6 changes: 3 additions & 3 deletions pdata/internal/cmd/pdatagen/internal/metrics_structs.go
Original file line number Diff line number Diff line change
Expand Up @@ -427,13 +427,13 @@ var summaryDataPoint = &messageValueStruct{
}

var quantileValuesSlice = &sliceOfPtrs{
structName: "ValueAtQuantileSlice",
structName: "SummaryDataPointValueAtQuantileSlice",
element: quantileValues,
}

var quantileValues = &messageValueStruct{
structName: "ValueAtQuantile",
description: "// ValueAtQuantile is a quantile value within a Summary data point.",
structName: "SummaryDataPointValueAtQuantile",
description: "// SummaryDataPointValueAtQuantile is a quantile value within a Summary data point.",
originFullName: "otlpmetrics.SummaryDataPoint_ValueAtQuantile",
fields: []baseField{
quantileField,
Expand Down
36 changes: 18 additions & 18 deletions pdata/internal/generated_wrapper_metrics.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

102 changes: 51 additions & 51 deletions pdata/pmetric/generated_metrics.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit e64c13f

Please sign in to comment.