Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pdata] Rename pdata struct that are named inconsistently with protobuf messages #6257

Closed
5 tasks done
dmitryax opened this issue Oct 8, 2022 · 0 comments
Closed
5 tasks done

[pdata] Rename pdata struct that are named inconsistently with protobuf messages #6257

dmitryax opened this issue Oct 8, 2022 · 0 comments
Assignees
@dmitryax
Labels
area:pdata pdata module related issues
Milestone
go.opentelemetry....

Comments

@dmitryax
Copy link
Member

dmitryax commented Oct 8, 2022 •
edited by bogdandrutu
Loading

We want rename the following structs that are not aligned with names of underlying protobuf messages:

  • pmetric.MetricAggregationTemporality -> pmetric.AggregationTemporality
  • ptrace.SpanStatus -> ptrace.Status
  • pmetric.MetricDataPointFlags -> pmetric.DataPointFlags
  • pmetric.ValueAtQuantile -> pmetric.SummaryDataPointValueAtQuantile
  • pmetric.Buckets -> ExponentialHistogramDataPointBuckets

See #6200 for the discussion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitryax dmitryax

Labels
area:pdata pdata module related issues
Projects
None yet
Milestone
go.opentelemetry.io/collector/pdata 1.0
Development

No branches or pull requests
2 participants
@bogdandrutu @dmitryax