Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate NumberDataPoint/Exemplar Val suffix methods #6134

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Sep 21, 2022

Updates #6081

Signed-off-by: Bogdan bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested review from a team and dmitryax September 21, 2022 01:00
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 92.00% // Head: 91.89% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (f194acd) compared to base (d9a847e).
Patch coverage: 40.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6134      +/-   ##
==========================================
- Coverage   92.00%   91.89%   -0.12%     
==========================================
  Files         217      217              
  Lines       13303    13319      +16     
==========================================
  Hits        12240    12240              
- Misses        834      850      +16     
  Partials      229      229              
Impacted Files Coverage Δ
pdata/pmetric/metrics.go 75.00% <0.00%> (-13.05%) ⬇️
pdata/pmetric/generated_metrics.go 96.09% <83.33%> (ø)
...er/loggingexporter/internal/otlptext/databuffer.go 99.12% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Bogdan <bogdandrutu@gmail.com>
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdandrutu bogdandrutu merged commit 44ce8e3 into open-telemetry:main Sep 23, 2022
@bogdandrutu bogdandrutu deleted the deprecatedval branch September 23, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants