Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/otlp] Rewrite logs related to server startup #6174

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Sep 28, 2022

The logs were a bit confusing when debugging DataDog/datadog-agent#13495, where an user was accidentally passing "0.0.0.0:4317" as an endpoint (quotes included). Making this a log field would make this issue more explicit.

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 92.19% // Head: 92.19% // No change to project coverage 👍

Coverage data is based on head (fc56801) compared to base (7cb544d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6174   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         219      219           
  Lines       13475    13475           
=======================================
  Hits        12423    12423           
  Misses        823      823           
  Partials      229      229           
Impacted Files Coverage Δ
receiver/otlpreceiver/otlp.go 87.58% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mx-psi mx-psi marked this pull request as ready for review September 28, 2022 19:48
@mx-psi mx-psi requested review from a team and codeboten September 28, 2022 19:48
@bogdandrutu
Copy link
Member

Please rebase.

@bogdandrutu bogdandrutu merged commit b1e1614 into open-telemetry:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants