Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Update deprecation comments #6206

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Sep 29, 2022

No description provided.

@mx-psi mx-psi requested review from a team and dmitryax September 29, 2022 18:59
@mx-psi mx-psi added Skip Changelog PRs that do not require a CHANGELOG.md entry area:pdata pdata module related issues labels Sep 29, 2022
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 91.77% // Head: 91.77% // No change to project coverage 👍

Coverage data is based on head (4403f9b) compared to base (8060037).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6206   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         218      218           
  Lines       13364    13364           
=======================================
  Hits        12265    12265           
  Misses        870      870           
  Partials      229      229           
Impacted Files Coverage Δ
pdata/pcommon/common.go 89.92% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeboten codeboten closed this Sep 29, 2022
@codeboten codeboten reopened this Sep 29, 2022
@codeboten
Copy link
Contributor

reopening, a couple of the status checks were stuck

@bogdandrutu bogdandrutu merged commit b73cd13 into open-telemetry:main Sep 29, 2022
@mx-psi mx-psi deleted the mx-psi/update-comments branch September 29, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:pdata pdata module related issues Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants