Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Restore NewValueBytesEmpty that was removed without deprecation #6105

Merged

Conversation

dmitryax
Copy link
Member

Appeared that we accidentally broke the deprecation rule in #6088. This PR unblocks core dependency upgrade in contrib

@dmitryax dmitryax requested review from a team and bogdandrutu September 16, 2022 16:17
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 91.85% // Head: 91.85% // No change to project coverage 👍

Coverage data is based on head (1a25063) compared to base (25d081e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6105   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files         217      217           
  Lines       13333    13333           
=======================================
  Hits        12247    12247           
  Misses        857      857           
  Partials      229      229           
Impacted Files Coverage Δ
pdata/pcommon/common.go 91.78% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants