-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pdata] Add Append and EnsureCapacity methods to primitive slices #6060
[pdata] Add Append and EnsureCapacity methods to primitive slices #6060
Conversation
Codecov ReportBase: 91.58% // Head: 91.60% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6060 +/- ##
==========================================
+ Coverage 91.58% 91.60% +0.01%
==========================================
Files 217 217
Lines 13424 13454 +30
==========================================
+ Hits 12295 12325 +30
Misses 906 906
Partials 223 223
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Confused about why not offering an Some other question:
|
@bogdandrutu My reasoning for Maybe we shouldn't rely on usage and think of the slices in more abstracted way. In that case |
I think an |
Ok sounds good. let's do that |
965858e
to
133d92d
Compare
133d92d
to
9f5c741
Compare
@bogdandrutu , updated |
Need a rebase |
Rebased |
cd3e8de
to
4a1a429
Compare
Follow-up PR from #5971:
Given that we have
SetAt
interface notAppend...
, I think it makes sense to haveSetLen
. But I'm open to other suggestionsFixes #6063
cc @bogdandrutu