Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate duplicate settings in service.ConfigProvider, embed ResolverSettings #5843

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested review from a team and tigrannajaryan August 5, 2022 21:57
…rSettings.

Signed-off-by: Bogdan <bogdandrutu@gmail.com>
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #5843 (fef7b01) into main (8bde9ee) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #5843      +/-   ##
==========================================
- Coverage   91.73%   91.66%   -0.07%     
==========================================
  Files         195      195              
  Lines       11915    11926      +11     
==========================================
+ Hits        10930    10932       +2     
- Misses        777      783       +6     
- Partials      208      211       +3     
Impacted Files Coverage Δ
service/config_provider.go 68.75% <43.75%> (-15.04%) ⬇️
service/command.go 78.57% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bogdandrutu bogdandrutu merged commit c620bc4 into open-telemetry:main Aug 8, 2022
@bogdandrutu bogdandrutu deleted the deprecateduplicate branch October 14, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants