Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] export NewSliceFromRaw #5679

Merged
merged 5 commits into from
Jul 15, 2022
Merged

Conversation

TylerHelmuth
Copy link
Member

Description:
Exports internal.NewSliceFromRaw to make it easier to make a slice from know values.

Link to tracking Issue:
#5617

Testing:
Ran existing tests

@TylerHelmuth TylerHelmuth requested review from a team and mx-psi July 12, 2022 21:20
@TylerHelmuth
Copy link
Member Author

/cc @dmitryax

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #5679 (e06cf6b) into main (a831d51) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5679   +/-   ##
=======================================
  Coverage   91.40%   91.40%           
=======================================
  Files         192      192           
  Lines       11416    11416           
=======================================
  Hits        10435    10435           
  Misses        781      781           
  Partials      200      200           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a831d51...e06cf6b. Read the comment docs.

pdata/pcommon/alias.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
TylerHelmuth and others added 2 commits July 12, 2022 15:47
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
@dmitryax
Copy link
Member

@codeboten I believe this is ready for merge

@dmitryax dmitryax added the ready-to-merge Code review completed; ready to merge by maintainers label Jul 14, 2022
@codeboten codeboten merged commit a7c047b into open-telemetry:main Jul 15, 2022
@TylerHelmuth TylerHelmuth deleted the issue-5617 branch July 15, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants