fix nil panic in confighttp #5628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5628 +/- ##
==========================================
+ Coverage 91.53% 91.58% +0.05%
==========================================
Files 192 192
Lines 11398 11399 +1
==========================================
+ Hits 10433 10440 +7
+ Misses 770 766 -4
+ Partials 195 193 -2
Continue to review full report at Codecov.
|
|
Does this small pr need changelog? @jpkrohling |
|
Yes, and a test. |
bogdandrutu
reviewed
Jul 5, 2022
There was a problem hiding this comment.
@jpkrohling please also check that the new order of operations is ok.
Unit test and changelog are both added. @jpkrohling |
fatsheep9146
force-pushed
the
confighttp-panic
branch
from
db79cf8
to
a3de2a2
Compare
jpkrohling
reviewed
Jul 6, 2022
TylerHelmuth
reviewed
Jul 7, 2022
fatsheep9146
force-pushed
the
confighttp-panic
branch
from
a3de2a2
to
e857c29
Compare
|
@jpkrohling @TylerHelmuth All comments are resolved, please help check those again :-) |
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
fatsheep9146
force-pushed
the
confighttp-panic
branch
from
3ab1d66
to
c7567ac
Compare
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
jpkrohling
approved these changes
Jul 19, 2022
TylerHelmuth
approved these changes
Jul 19, 2022
bogdandrutu
approved these changes
Jul 19, 2022
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ziqi Zhao zhaoziqi9146@gmail.com
Description: <Describe what has changed.
fix #5556
Link to tracking Issue:
#5556