[chore][Testbed] - Try flushing the data before exiting in load generator #35211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacherfl
reviewed
Sep 17, 2024
VihasMakwana
changed the title
bacherfl
reviewed
Sep 18, 2024
bacherfl
reviewed
Sep 18, 2024
VihasMakwana
force-pushed
the
testbed-flush-before-exiting
branch
from
56efb03
to
21ae1b2
Compare
bacherfl
approved these changes
Sep 19, 2024
|
LGTM, so putting my approval here for what it's worth :) I think the title of the PR can be changed to start with |
VihasMakwana
changed the title
|
@TylerHelmuth @open-telemetry/collector-contrib-approvers can some take a look at this? |
|
@open-telemetry/collector-contrib-approvers can I get a quick approval here? this is needed for #35209 |
djaglowski
approved these changes
Sep 24, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…ator (open-telemetry#35211) **Description:** In the `LoadGenerator`, if we encounter a non-permanent error and are in the process of retrying, we should not immediately exit upon receiving a stop signal. Instead, we need to first flush the existing data and then proceed to exit the LoadGenerator. This is necessary for stress test cases and we need to validate the data received and data sent. --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: In the
LoadGenerator, if we encounter a non-permanent error and are in the process of retrying, we should not immediately exit upon receiving a stop signal. Instead, we need to first flush the existing data and then proceed to exit the LoadGenerator. This is necessary for stress test cases and we need to validate the data received and data sent.