Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][Testbed] - Try flushing the data before exiting in load generator #35211

Merged
merged 9 commits into from
Sep 24, 2024
Merged

[chore][Testbed] - Try flushing the data before exiting in load generator #35211

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8eff3b1
initial commit
VihasMakwana Sep 16, 2024
27fad22
correctness validator
VihasMakwana Sep 16, 2024
55c07ae
chore: flush the data before exiting
VihasMakwana Sep 16, 2024
b6f835f
fix: revert unnecesary
VihasMakwana Sep 16, 2024
8b1ecff
chore: implement max delay
VihasMakwana Sep 17, 2024
21ae1b2
fix: revert mistake
VihasMakwana Sep 18, 2024
7a7ba32
Merge branch 'main' into testbed-flush-before-exiting
VihasMakwana Sep 18, 2024
5c2359a
Merge branch 'main' into testbed-flush-before-exiting
VihasMakwana Sep 19, 2024
c60572f
Merge branch 'main' into testbed-flush-before-exiting
djaglowski Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions testbed/testbed/load_generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ type LoadOptions struct {

// Parallel specifies how many goroutines to send from.
Parallel int

// MaxDelay defines the longest amount of time we can continue retrying for non-permanent errors.
MaxDelay time.Duration
}

var _ LoadGenerator = (*ProviderSender)(nil)
Expand Down Expand Up @@ -112,6 +115,11 @@ func (ps *ProviderSender) Start(options LoadOptions) {
ps.options.ItemsPerBatch = 10
}

if ps.options.MaxDelay == 0 {
// retry for an additional 10 seconds by default
ps.options.MaxDelay = time.Second * 10
}

log.Printf("Starting load generator at %d items/sec.", ps.options.DataItemsPerSecond)

// Indicate that generation is in progress.
Expand Down Expand Up @@ -240,6 +248,7 @@ func (ps *ProviderSender) generateTrace() error {
traceSender := ps.Sender.(TraceDataSender)

traceData, done := ps.Provider.GenerateTraces()
timer := time.NewTimer(ps.options.MaxDelay)
if done {
return nil
}
Expand All @@ -258,9 +267,8 @@ func (ps *ProviderSender) generateTrace() error {
return fmt.Errorf("cannot send traces: %w", err)
}
ps.nonPermanentErrors.Add(uint64(traceData.SpanCount()))

VihasMakwana marked this conversation as resolved.
Show resolved Hide resolved
select {
case <-ps.stopSignal:
case <-timer.C:
return nil
default:
}
Expand All @@ -271,6 +279,7 @@ func (ps *ProviderSender) generateMetrics() error {
metricSender := ps.Sender.(MetricDataSender)

metricData, done := ps.Provider.GenerateMetrics()
timer := time.NewTimer(ps.options.MaxDelay)
if done {
return nil
}
Expand All @@ -291,7 +300,7 @@ func (ps *ProviderSender) generateMetrics() error {
ps.nonPermanentErrors.Add(uint64(metricData.DataPointCount()))

select {
case <-ps.stopSignal:
case <-timer.C:
return nil
default:
}
Expand All @@ -302,6 +311,7 @@ func (ps *ProviderSender) generateLog() error {
logSender := ps.Sender.(LogDataSender)

logData, done := ps.Provider.GenerateLogs()
timer := time.NewTimer(ps.options.MaxDelay)
if done {
return nil
}
Expand All @@ -322,7 +332,7 @@ func (ps *ProviderSender) generateLog() error {
ps.nonPermanentErrors.Add(uint64(logData.LogRecordCount()))

select {
case <-ps.stopSignal:
case <-timer.C:
return nil
default:
}
Expand Down