[chore][testbed] - Further testbed enhancements #35209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VihasMakwana
force-pushed
the
memorylimit-test-cases
branch
from
59df2b6 to
27fad22
Compare
VihasMakwana
changed the title
|
@open-telemetry/collector-contrib-approvers can some take a look here? |
|
ccing @atoulme as he reviewed my past tested PRs. Can you take a look? |
VihasMakwana
changed the title
|
@fatsheep9146 can you take a look here? |
|
@open-telemetry/collector-contrib-approvers can someone take a look here? |
atoulme
approved these changes
Oct 31, 2024
|
This looks like a useful test to me. The test seems to test the right things. |
djaglowski
approved these changes
Nov 7, 2024
pull bot
pushed a commit
to abaguas/opentelemetry-collector-contrib
that referenced
this pull request
Nov 7, 2024
PR to add memory limiter test cases. This tests scenarios where collector is understress and we verify that we receive all the data, without drops/duplication.
songy23
reviewed
Nov 7, 2024
|
|
||
| agentProc := testbed.NewChildProcessCollector(testbed.WithEnvVar("GOMAXPROCS", "2")) | ||
|
|
||
| configStr := createConfigYaml(t, sender, receiver, resultDir, processors, nil) |
There was a problem hiding this comment.
TylerHelmuth
pushed a commit
that referenced
this pull request
Nov 7, 2024
evan-bradley
added a commit
that referenced
this pull request
Nov 13, 2024
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
PR to add memory limiter test cases. This tests scenarios where collector is understress and we verify that we receive all the data, without drops/duplication.
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
There was a merge conflict somewhere and we had to revert open-telemetry#35209. This PR fixes the CI failure and updates the test cases. cc: @atoulme --------- Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add memory limiter test cases.
This tests scenarios where collector is understress and we verify that we receive all the data, without drops/duplication.