Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken lifecycle test in several components #30563

Closed
wants to merge 2 commits into from
Closed

Fix broken lifecycle test in several components #30563

wants to merge 2 commits into from

Conversation

fatsheep9146
Copy link
Contributor

Description:
fix #30561

Link to tracking Issue:
#30561

Testing:
No need

Documentation:
No need

@fatsheep9146 fatsheep9146 requested review from a team and dashpole January 15, 2024 22:59
@fatsheep9146 fatsheep9146 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 15, 2024
@codeboten codeboten added the Run Windows Enable running windows test on a PR label Jan 15, 2024
@fatsheep9146
[receiver/podman] fix broken lifecycle test
06ae434 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
@fatsheep9146
fix windows unit test failed for opampsupervisor
3991161 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
@fatsheep9146
Copy link
Contributor Author

sshreceiver also came with same error

--- FAIL: TestComponentLifecycle (0.00s)
    --- FAIL: TestComponentLifecycle/metrics-shutdown (0.00s)
        generated_component_test.go:67: 
            	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/sshcheckreceiver/generated_component_test.go:67
            	Error:      	Received unexpected error:
            	            	sshcheck is unsupported on Windows.
            	Test:       	TestComponentLifecycle/metrics-shutdown
    --- FAIL: TestComponentLifecycle/metrics-lifecycle (0.00s)
        generated_component_test.go:75: 
            	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/sshcheckreceiver/generated_component_test.go:75
            	Error:      	Received unexpected error:
            	            	sshcheck is unsupported on Windows.
            	Test:       	TestComponentLifecycle/metrics-lifecycle

@fatsheep9146 fatsheep9146 changed the title [receiver/podman] fix broken lifecycle test Fix broken lifecycle test in several components Jan 16, 2024
evan-bradley
evan-bradley reviewed Jan 16, 2024
View reviewed changes
receiver/podmanreceiver/podman_windows.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make changes to mdatagen to not run these tests on Windows instead of allowing the receiver to start on Windows. Allowing the receiver to silently start on Windows will lead to a more confusing user experience since it makes it less obvious that Windows isn't a supported platform.

In my opinion we should tackle this issue to resolve the problems with the Windows tests: #30044.

Copy link
Contributor Author

@fatsheep9146 fatsheep9146 Jan 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I also talk about this idea in slacks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a pr to solve this problem by adding supported_platforms
#30640
close this

@fatsheep9146
Copy link
Contributor Author

Add a pr to solve this problem by adding supported_platforms
#30640
close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-bradley evan-bradley evan-bradley left review comments

@dashpole dashpole Awaiting requested review from dashpole

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan tigrannajaryan is a code owner

Assignees

@TylerHelmuth TylerHelmuth

Labels
cmd/opampsupervisor receiver/podman Run Windows Enable running windows test on a PR Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[receiver/podman] lifecycle test failure on windows
4 participants
@fatsheep9146 @evan-bradley @codeboten @TylerHelmuth