-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd/mdatagen] Support modifying component tests for different platforms #30044
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@dmitryax I can take implementation of this one if you wish |
@evan-bradley thoughts on specifying build-targets instead of values for GOOS/PLATFORM? Idea would be we
Or do we need more granularity, ex at the per-metric level? If so then I'd say a change in metadata.yaml schema is warranted/better. |
We may want to hold off on implementation until |
Sorry, I missed the notification for this. Are there other build targets that we would want to gate tests on outside of the OS/architecture? I'm not against the approach you suggested, but to me restricting the allowed values to the supported Collector platforms seems like a reasonable default choice.
I'm not aware that we need granularity on anything more than the component level for these tests, since I think most components handle per-platform metrics within their own tests and not in the mdatagen-generated tests. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Component(s)
cmd/mdatagen
Is your feature request related to a problem? Please describe.
Not all components support all platforms, which can lead to failures in tests when testing is performed on an unsupported platform in CI.
Describe the solution you'd like
Add a config option that allows configuring which platforms a component supports. I'm not aware of any components that are currently restricted by architecture, but that may also be necessary.
Describe alternatives you've considered
No response
Additional context
We are currently receiving the current error on main when running Windows unit tests for the Podman receiver:
From: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7250553809/job/19751004982
I believe this error comes from generating the tests, which was done here: #29957
The text was updated successfully, but these errors were encountered: