Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/podman] lifecycle test failure on windows #30561

Closed
codeboten opened this issue Jan 15, 2024 · 3 comments · Fixed by #30640
Closed

[receiver/podman] lifecycle test failure on windows #30561

codeboten opened this issue Jan 15, 2024 · 3 comments · Fixed by #30640
Labels
receiver/podman release:blocker The issue must be resolved before cutting the next release

Comments

@codeboten
Copy link
Contributor

Component(s)

receiver/podman

Describe the issue you're reporting

This is currently breaking tests in main:

--- FAIL: TestComponentLifecycle (0.00s)
    --- FAIL: TestComponentLifecycle/metrics-shutdown (0.00s)
        generated_component_test.go:67: 
            	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/podmanreceiver/generated_component_test.go:67
            	Error:      	Received unexpected error:
            	            	podman receiver is not supported on windows
            	Test:       	TestComponentLifecycle/metrics-shutdown
FAIL
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/podmanreceiver	0.061s
FAIL

See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7532146479/job/20502194154 for full logs
@codeboten codeboten added needs triage New item requiring triage release:blocker The issue must be resolved before cutting the next release labels Jan 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@codeboten
Copy link
Contributor Author

Looks like this change broke things: 755ae7b

@fatsheep9146 fatsheep9146 mentioned this issue Jan 15, 2024
Closed
@github-actions github-actions bot mentioned this issue Jan 16, 2024
Closed
@crobert-1
Copy link
Member

Looks like a PR is open to resolve this, removing needs triage.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Jan 16, 2024
@fatsheep9146 fatsheep9146 mentioned this issue Jan 17, 2024
Merged
@atoulme atoulme mentioned this issue Jan 17, 2024
Closed
dmitryax added a commit that referenced this issue Jan 20, 2024
@fatsheep9146 @dmitryax
[mdatagen] add unsupported_platforms support and enable several com…
ff3023c 
…ponents (#30640)

**Description:**
Add `supported_platforms` to enable components to describe which
platforms are supported, meanwhile this configuration can also be used
to generate the liftcycle test to skip windows when the component does
not support windows.

**Link to tracking Issue:** fix #30561

---------

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
@fatsheep9146 @dmitryax @cparkins
[mdatagen] add unsupported_platforms support and enable several com…
02dd7af 
…ponents (open-telemetry#30640)

**Description:**
Add `supported_platforms` to enable components to describe which
platforms are supported, meanwhile this configuration can also be used
to generate the liftcycle test to skip windows when the component does
not support windows.

**Link to tracking Issue:** fix open-telemetry#30561

---------

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
receiver/podman release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Milestone
No milestone
2 participants
@codeboten @crobert-1