Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/sshcheck] Windows support #30650

Closed
atoulme opened this issue Jan 17, 2024 · 6 comments · Fixed by #30648
Closed

[receiver/sshcheck] Windows support #30650

atoulme opened this issue Jan 17, 2024 · 6 comments · Fixed by #30648
Labels
os:windows receiver/sshcheck Stale

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 17, 2024

Component(s)

receiver/sshcheck

Describe the issue you're reporting

It is unclear to me why Windows is not supported for the sshcheckreceiver. The README doesn't mention why it's not supported, and I don't see any code libraries used that might be OS specific.
I have opened a draft PR to try and run Windows tests on this component and see if they fail.
@atoulme atoulme added the needs triage New item requiring triage label Jan 17, 2024
@atoulme
Copy link
Contributor Author

atoulme commented Jan 17, 2024 •
edited
Loading

The draft PR fails on an unrelated issue: #30561

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme
Copy link
Contributor Author

atoulme commented Jan 22, 2024

the draft PR now passes. It seems to indicate that Windows support is possible. What do you think?

@github-actions github-actions bot mentioned this issue Jan 23, 2024
Closed
@github-actions github-actions bot mentioned this issue Jan 30, 2024
Closed
@atoulme
Copy link
Contributor Author

atoulme commented Feb 1, 2024

@nslaughter @codeboten any idea?

@github-actions github-actions bot mentioned this issue Feb 6, 2024
Closed
@github-actions github-actions bot mentioned this issue Feb 13, 2024
Closed
@atoulme
Copy link
Contributor Author

atoulme commented Feb 14, 2024

@nslaughter @codeboten any take on whether Windows should be supported?

@atoulme atoulme mentioned this issue Feb 17, 2024
Merged
@atoulme atoulme removed the needs triage New item requiring triage label Feb 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 17, 2024
codeboten added a commit that referenced this issue Apr 29, 2024
@atoulme @codeboten
[receiver/sshcheck] enable Windows (#30648)
06c970d 
Removes the checks forbidding to use sshcheckreceiver on Windows.

Fixes #30650

Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
os:windows receiver/sshcheck Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[receiver/sshcheck] enable Windows atoulme/opentelemetry-collector-contrib
2 participants
@atoulme @crobert-1