Splunkent client refactor #27205
Merged
Splunkent client refactor #27205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
reviewed
Sep 26, 2023
atoulme
reviewed
Sep 26, 2023
atoulme
reviewed
Sep 26, 2023
atoulme
reviewed
Sep 26, 2023
shalper2
force-pushed
the
splunkent-client-refactor
branch
3 times, most recently
from
a311bba
to
63e4636
Compare
shalper2
force-pushed
the
splunkent-client-refactor
branch
from
8849d11
to
7dc6f56
Compare
|
Looks good, just my earlier comment left. |
shalper2
force-pushed
the
splunkent-client-refactor
branch
4 times, most recently
from
9dfbbf2
to
491b9e7
Compare
| component: splunkentreceiver | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: "Refactor Splunkenterprise Receiver component to better leverage existing otel SDK." |
There was a problem hiding this comment.
I would change the note to be user facing saying that you can use the auth settings to connect to Splunk enterprise.
There was a problem hiding this comment.
Gotcha! Makes sense to me. Thanks Sean!
MovieStoreGuy
approved these changes
Sep 30, 2023
shalper2
force-pushed
the
splunkent-client-refactor
branch
10 times, most recently
from
9bad504
to
19e70a1
Compare
Not sure how this keeps getting changed
Again, not sure where this change came from
shalper2
force-pushed
the
splunkent-client-refactor
branch
from
b9d74f8
to
fd14417
Compare
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
Refactored parts of the Splunk Enterprise receiver to better leverage the pre-existing otel SDK. This PR also updates the README to be a more informative document. [27026](open-telemetry#27026) Unit testing is included and updated to accommodate the new refactor.
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
Refactored parts of the Splunk Enterprise receiver to better leverage the pre-existing otel SDK. This PR also updates the README to be a more informative document. [27026](open-telemetry#27026) Unit testing is included and updated to accommodate the new refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactored parts of the Splunk Enterprise receiver to better leverage the pre-existing otel SDK. This PR also updates the README to be a more informative document.
Link to tracking Issue:
27026
Testing:
Unit testing is included and updated to accommodate the new refactor.
Documentation:
README.md