Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splunkent client refactor #27205

Merged
merged 28 commits into from
Oct 16, 2023
Merged

Splunkent client refactor #27205

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
4bbafc9
fixed bad scraper test
shalper2 Aug 14, 2023
61e3d9c
gci'd
shalper2 Aug 14, 2023
add8c07
changes in response to feedback
shalper2 Aug 17, 2023
ec3ba7b
lint
shalper2 Aug 17, 2023
463eb10
removed defer calls in loop
shalper2 Aug 28, 2023
2798572
gci
shalper2 Aug 28, 2023
eb9852c
refactor to use confighttp
shalper2 Aug 16, 2023
fef1807
removed dead dependencies
shalper2 Aug 31, 2023
379755d
chipping away at client_test
shalper2 Sep 1, 2023
25cbeb9
removed maxWaitTime
shalper2 Sep 19, 2023
36eabdf
refactor tests
shalper2 Sep 25, 2023
a960330
chlog entry
shalper2 Sep 25, 2023
62905e2
cleaned client_test imports
shalper2 Sep 25, 2023
d88ab3f
cleaned up mockHost
shalper2 Sep 25, 2023
11a2f3a
added readme
shalper2 Sep 25, 2023
d6c6592
fixing bad edits
shalper2 Sep 25, 2023
ad8de68
fix local change to lokireceiver on local
shalper2 Sep 26, 2023
a3eb4ec
Fixing bad commit to opencensus receiver
shalper2 Sep 26, 2023
604e1a7
fixed client_test.go
shalper2 Sep 26, 2023
b40f8a8
new chlog
shalper2 Sep 26, 2023
11d2d2a
new chlog
shalper2 Sep 26, 2023
2ffb492
separated chlog entries
shalper2 Sep 26, 2023
59e77c1
chlog again
shalper2 Sep 26, 2023
61226fe
fixed lint
shalper2 Sep 27, 2023
049050b
gci
shalper2 Sep 27, 2023
a2d049c
using default http client settings
shalper2 Sep 28, 2023
b59ed79
gci
shalper2 Sep 28, 2023
fd14417
updated chlog
shalper2 Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed defer calls in loop
  • Loading branch information
@shalper2
shalper2 committed Oct 16, 2023
commit 463eb1068194eb0fa2f3a63595ccea2a5280b643
4 changes: 1 addition & 3 deletions receiver/splunkenterprisereceiver/scraper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"encoding/json"
"encoding/xml"
"errors"
"fmt"
"fmt"
"io"
"net/http"
"strconv"
Expand Down Expand Up @@ -100,13 +100,11 @@ func (s *splunkScraper) scrapeLicenseUsageByIndex(ctx context.Context, now pcomm
errs.Add(err)
return
}
defer res.Body.Close()

// if its a 204 the body will be empty because we are still waiting on search results
err = unmarshallSearchReq(res, &sr)
if err != nil {
errs.Add(err)
return
}
res.Body.Close()

Expand Down