[receiver/splunkenterprise] Refactor component to better utilize SDK #27026
Assignees
Labels
Comments
shalper2
added
enhancement
|
please assign to me |
crobert-1
added
receiver/splunkenterprise
and removed
needs triage
|
Pinging code owners for receiver/splunkenterprise: @shalper2 @MovieStoreGuy. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
|
Removed needs triage flag, totally agree to reusing the existing logic for these functionalities. |
This was referenced Sep 26, 2023
codeboten
pushed a commit
that referenced
this issue
Oct 16, 2023
Refactored parts of the Splunk Enterprise receiver to better leverage the pre-existing otel SDK. This PR also updates the README to be a more informative document. [27026](#27026) Unit testing is included and updated to accommodate the new refactor.
|
This is closed by #27205 |
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this issue
Oct 18, 2023
Refactored parts of the Splunk Enterprise receiver to better leverage the pre-existing otel SDK. This PR also updates the README to be a more informative document. [27026](open-telemetry#27026) Unit testing is included and updated to accommodate the new refactor.
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this issue
Nov 12, 2023
Refactored parts of the Splunk Enterprise receiver to better leverage the pre-existing otel SDK. This PR also updates the README to be a more informative document. [27026](open-telemetry#27026) Unit testing is included and updated to accommodate the new refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
receiver/splunkenterprise
Is your feature request related to a problem? Please describe.
The current logic of the Splunkenterprise receiver does not utilize the provided SDK as comprehensively as it could. Specifically,
httpauth,configauth, andbasicauthextensioncould all be leveraged to reduce custom code and improve the readability of the component. Additionally there is a custom timeout setting that can be replaced by using theScraperControllerSettings.Timeoutfield.Describe the solution you'd like
A refactor of the component to leverage the above mentioned pieces of the opentelemetry SDK to replace custom code implementing the same functionality.
Describe alternatives you've considered
Currently the component works well but relies on custom implementations of functionality which exists in the codebase.
Additional context
No response
The text was updated successfully, but these errors were encountered: