Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWSEMFExporter - Adding SummaryDataType, Remove MinMax from Histogram #1564

Closed
wants to merge 22 commits into from
Closed

AWSEMFExporter - Adding SummaryDataType, Remove MinMax from Histogram #1564

wants to merge 22 commits into from

Conversation

shaochengwang
Copy link
Contributor

Description:
Add SummaryDataType
Remove Min Max from Histogram data type

Link to tracking Issue:
#1510

Testing:
unit tests
manual end-to-end test

Documentation:
Add SummaryDataType since it's now supported
Remove Min Max from Histogram data type since the histogram buckets doesn't expose the Min and Max.

@shaochengwang shaochengwang requested a review from a team November 13, 2020 05:55
@codecov
Copy link

codecov bot commented Nov 13, 2020 •
edited
Loading

Codecov Report

Merging #1564 (cb4270e) into master (61f1363) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1564   +/-   ##
=======================================
  Coverage   89.23%   89.24%           
=======================================
  Files         354      354           
  Lines       17418    17427    +9     
=======================================
+ Hits        15543    15552    +9     
  Misses       1398     1398           
  Partials      477      477
Flag Coverage Δ
integration 70.96% <ø> (ø)
unit 87.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/awsemfexporter/metric_translator.go 94.55% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f1363...497524c. Read the comment docs.

bogdandrutu
bogdandrutu reviewed Nov 13, 2020
View reviewed changes
exporter/awsemfexporter/metric_translator.go
@@ -82,6 +82,7 @@ type CWMetricStats struct {
// - pdata.DoubleDataPointSlice
// - pdata.IntHistogramDataPointSlice
// - pdata.DoubleHistogramDataPointSlice
// - pdata.DoubleSummaryDataPointSlice
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align with previous comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Didn't see this in the IDE. I will replace all tabs with spaces :)

exporter/awsemfexporter/metric_translator.go
@@ -92,6 +93,7 @@ type DataPoints interface {
// - pdata.DoubleDataPoint
// - pdata.IntHistogramDataPoint
// - pdata.DoubleHistogramDataPoint
// - pdata.DoubleSummaryDataPointSlice
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

mxiamxia
mxiamxia approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

kohrapha and others added 19 commits November 13, 2020 09:51
@kohrapha @shaochengwang
[awsemfexporter] Implement metric filtering and dimension setting (op…
0217d55 
…en-telemetry#1503)

* Create MetricDeclaration struct

* Implement dimension dedup logic when adding rolledup dimensions (open-telemetry#6)

* Implement dimension dedup logic when adding rolledup dimensions

* Remove duplicated dimensions in metric declaration

* Create benchmark for filtering with metric declarations and use assertCwMeasurementEqual for tests

* Move helper test code to the top of file

* Update dimRollup test

* Aggregate dimensions and perform dedup

* Minor code change

* Fix test failure from merging new changes
@jpkrohling @shaochengwang
Trace ID aware load-balancing exporter - 4/4 (open-telemetry#1542)
b01cc16 
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@dependabot @shaochengwang
Bump github.com/aws/aws-sdk-go in /internal/awsxray/testdata/sampleapp (
ed8eca5 
open-telemetry#1566)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.35.23 to 1.35.27.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.35.23...v1.35.27)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @shaochengwang
Bump github.com/prometheus/common in /receiver/simpleprometheusreceiv…
14fcef3 
…er (open-telemetry#1569)

Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.14.0 to 0.15.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.14.0...v0.15.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @shaochengwang
Bump github.com/aliyun/aliyun-log-go-sdk (open-telemetry#1568)
84a94fc 
Bumps [github.com/aliyun/aliyun-log-go-sdk](https://github.com/aliyun/aliyun-log-go-sdk) from 0.1.16 to 0.1.17.
- [Release notes](https://github.com/aliyun/aliyun-log-go-sdk/releases)
- [Commits](aliyun/aliyun-log-go-sdk@v0.1.16...v0.1.17)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @shaochengwang
Bump github.com/honeycombio/libhoney-go in /exporter/honeycombexporter (
255f46b 
open-telemetry#1571)

Bumps [github.com/honeycombio/libhoney-go](https://github.com/honeycombio/libhoney-go) from 1.14.1 to 1.15.0.
- [Release notes](https://github.com/honeycombio/libhoney-go/releases)
- [Changelog](https://github.com/honeycombio/libhoney-go/blob/main/CHANGELOG.md)
- [Commits](honeycombio/libhoney-go@v1.14.1...v1.15.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @shaochengwang
Bump github.com/aws/aws-sdk-go in /exporter/awsemfexporter (open-tele…
c0d37de 
…metry#1572)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.35.23 to 1.35.27.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.35.23...v1.35.27)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @shaochengwang
Bump github.com/google/go-cmp in /exporter/jaegerthrifthttpexporter (o…
49f8ad0 
…pen-telemetry#1579)

Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.2 to 0.5.3.
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](google/go-cmp@v0.5.2...v0.5.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @shaochengwang
Bump github.com/aws/aws-sdk-go in /processor/resourcedetectionprocess…
b2e5a3b 
…or (open-telemetry#1580)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.35.23 to 1.35.27.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.35.23...v1.35.27)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @shaochengwang
Bump github.com/google/go-cmp in /exporter/sentryexporter (open-telem…
631c24c 
…etry#1581)

Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.2 to 0.5.3.
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](google/go-cmp@v0.5.2...v0.5.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @shaochengwang
Bump github.com/aws/aws-sdk-go in /receiver/awsxrayreceiver (open-tel…
e344887 
…emetry#1578)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.35.23 to 1.35.27.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.35.23...v1.35.27)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @shaochengwang
Bump github.com/google/go-cmp in /processor/metricstransformprocessor (…
18f87ac 
…open-telemetry#1576)

Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.2 to 0.5.3.
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](google/go-cmp@v0.5.2...v0.5.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @shaochengwang
Bump github.com/aws/aws-sdk-go in /exporter/datadogexporter (open-tel…
fd04869 
…emetry#1575)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.35.23 to 1.35.27.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.35.23...v1.35.27)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @shaochengwang
Bump github.com/prometheus/common in /receiver/prometheusexecreceiver (…
74c0de5 
…open-telemetry#1574)

Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.14.0 to 0.15.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.14.0...v0.15.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @shaochengwang
Bump github.com/observiq/stanza in /receiver/stanzareceiver (open-tel…
0dbce50 
…emetry#1573)

Bumps [github.com/observiq/stanza](https://github.com/observiq/stanza) from 0.13.0 to 0.13.1.
- [Release notes](https://github.com/observiq/stanza/releases)
- [Changelog](https://github.com/observIQ/stanza/blob/master/CHANGELOG.md)
- [Commits](observIQ/stanza@v0.13.0...v0.13.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @shaochengwang
Bump github.com/aws/aws-sdk-go in /exporter/awsxrayexporter (open-tel…
1571b78 
…emetry#1577)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.35.23 to 1.35.27.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.35.23...v1.35.27)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @shaochengwang
Bump github.com/google/go-cmp in /exporter/honeycombexporter (open-te…
31501b2 
…lemetry#1570)

Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.2 to 0.5.3.
- [Release notes](https://github.com/google/go-cmp/releases)
- [Commits](google/go-cmp@v0.5.2...v0.5.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@bogdandrutu @shaochengwang
Fix version for carbonexporter, avoid dependabot upgrades like open-t…
56ee8c8 
…elemetry#1517 (open-telemetry#1560)

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@james-bebbington @bogdandrutu @shaochengwang
Enable windows perf counters receiver (open-telemetry#1539)
497524c 
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
@shaochengwang
Copy link
Contributor Author

Sorry, I accidentally touched several commits. I have reopened a new PR to clean this up. #1584
Closing this one.

@shaochengwang shaochengwang mentioned this pull request Nov 13, 2020
Merged
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
@pavolloffay
Configure mTLS in jaeger exporter test (#1564)
4412a94 
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
@ijsong
Use reasonable interval in sdktrace.WithBatchTimeout (#1621)
1519d95 
* Use reasonable interval in sdktrace.WithBatchTimeout

This patch resolves #1564.

* Add pull request ID to CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu left review comments

@mxiamxia mxiamxia mxiamxia approved these changes

@anuraaga anuraaga anuraaga approved these changes

@james-bebbington james-bebbington Awaiting requested review from james-bebbington

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

@jrcamp jrcamp Awaiting requested review from jrcamp

@kbrockhoff kbrockhoff Awaiting requested review from kbrockhoff

Assignees

@bogdandrutu bogdandrutu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shaochengwang @anuraaga @bogdandrutu @mxiamxia @kohrapha @jpkrohling @james-bebbington