Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version for carbonexporter, avoid dependabot upgrades like #1517 #1560

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team November 12, 2020 20:01
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #1560 (b32c213) into master (90e51a8) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1560      +/-   ##
==========================================
+ Coverage   89.22%   89.24%   +0.01%     
==========================================
  Files         354      354              
  Lines       17418    17418              
==========================================
+ Hits        15542    15544       +2     
+ Misses       1398     1396       -2     
  Partials      478      478              
Flag Coverage Δ
integration 70.96% <ø> (ø)
unit 87.87% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
processor/groupbytraceprocessor/event.go 95.96% <0.00%> (-0.81%) ⬇️
receiver/prometheusexecreceiver/receiver.go 88.33% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e51a8...b32c213. Read the comment docs.

@bogdandrutu
Copy link
Member Author

@jpkrohling please review this

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O_____O

Is there any way we can prevent this from happening again?

@bogdandrutu
Copy link
Member Author

@jpkrohling not that I know of, but there is an open issue to resolve the versions and how to use externally without a replace, which should most likely address this as well.

@bogdandrutu bogdandrutu merged commit 8e17468 into open-telemetry:master Nov 13, 2020
@bogdandrutu bogdandrutu deleted the carbonexporter branch November 13, 2020 15:50
shaochengwang pushed a commit to shaochengwang/opentelemetry-collector-contrib that referenced this pull request Nov 13, 2020
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
)

Bumps [github.com/grpc-ecosystem/grpc-gateway](https://github.com/grpc-ecosystem/grpc-gateway) from 1.14.6 to 1.14.7.
- [Release notes](https://github.com/grpc-ecosystem/grpc-gateway/releases)
- [Changelog](https://github.com/grpc-ecosystem/grpc-gateway/blob/master/CHANGELOG.md)
- [Commits](grpc-ecosystem/grpc-gateway@v1.14.6...v1.14.7)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants