Not adding IntHistogram in this revision

exporter/awsemfexporter/metric_translator.go

@@ -82,6 +82,7 @@ type CWMetricStats struct {
 // 	- pdata.DoubleDataPointSlice
 // 	- pdata.IntHistogramDataPointSlice
 // 	- pdata.DoubleHistogramDataPointSlice
+//  - pdata.DoubleSummaryDataPointSlice
 type DataPoints interface {
 	Len() int
 	At(int) DataPoint
@@ -92,6 +93,7 @@ type DataPoints interface {
 // 	- pdata.DoubleDataPoint
 // 	- pdata.IntHistogramDataPoint
 // 	- pdata.DoubleHistogramDataPoint
+//  - pdata.DoubleSummaryDataPointSlice
 type DataPoint interface {
 	IsNil() bool
 	LabelsMap() pdata.StringMap
@@ -104,9 +106,6 @@ type IntDataPointSlice struct {
 type DoubleDataPointSlice struct {
 	pdata.DoubleDataPointSlice
 }
-type IntHistogramDataPointSlice struct {
-	pdata.IntHistogramDataPointSlice
-}
 type DoubleHistogramDataPointSlice struct {
 	pdata.DoubleHistogramDataPointSlice
 }
@@ -120,9 +119,6 @@ func (dps IntDataPointSlice) At(i int) DataPoint {
 func (dps DoubleDataPointSlice) At(i int) DataPoint {
 	return dps.DoubleDataPointSlice.At(i)
 }
-func (dps IntHistogramDataPointSlice) At(i int) DataPoint {
-	return dps.IntHistogramDataPointSlice.At(i)
-}
 func (dps DoubleHistogramDataPointSlice) At(i int) DataPoint {
 	return dps.DoubleHistogramDataPointSlice.At(i)
 }
@@ -230,8 +226,6 @@ func getCWMetrics(metric *pdata.Metric, namespace string, instrumentationLibName
 		dps = IntDataPointSlice{metric.IntSum().DataPoints()}
 	case pdata.MetricDataTypeDoubleSum:
 		dps = DoubleDataPointSlice{metric.DoubleSum().DataPoints()}
-	case pdata.MetricDataTypeIntHistogram:
-		dps = IntHistogramDataPointSlice{metric.IntHistogram().DataPoints()}
 	case pdata.MetricDataTypeDoubleHistogram:
 		dps = DoubleHistogramDataPointSlice{metric.DoubleHistogram().DataPoints()}
 	case pdata.MetricDataTypeDoubleSummary:
@@ -290,11 +284,6 @@ func buildCWMetric(dp DataPoint, pmd *pdata.Metric, namespace string, metricSlic
 		if needsCalculateRate(pmd) {
 			metricVal = calculateRate(fields, metric.Value(), timestamp)
 		}
-	case pdata.IntHistogramDataPoint:
-		metricVal = &CWMetricStats{
-			Count: metric.Count(),
-			Sum:   float64(metric.Sum()),
-		}
 	case pdata.DoubleHistogramDataPoint:
 		metricVal = &CWMetricStats{
 			Count: metric.Count(),

exporter/awsemfexporter/metric_translator_test.go

@@ -32,6 +32,8 @@ import (
 	"go.opentelemetry.io/collector/translator/conventions"
 	"go.opentelemetry.io/collector/translator/internaldata"
 	"go.uber.org/zap"
+	"go.uber.org/zap/zapcore"
+	"go.uber.org/zap/zaptest/observer"
 )
 
 // Asserts whether dimension sets are equal (i.e. has same sets of dimensions)
@@ -922,6 +924,37 @@ func TestGetCWMetrics(t *testing.T) {
 		})
 	}
 
+	t.Run("Unhandled metric type", func(t *testing.T) {
+		metric := pdata.NewMetric()
+		metric.InitEmpty()
+		metric.SetName("foo")
+		metric.SetUnit("Count")
+		metric.SetDataType(pdata.MetricDataTypeIntHistogram)
+
+		obs, logs := observer.New(zap.WarnLevel)
+		obsConfig := &Config{
+			DimensionRollupOption: "",
+			logger:                zap.New(obs),
+		}
+
+		cwMetrics := getCWMetrics(&metric, namespace, instrumentationLibName, obsConfig)
+		assert.Nil(t, cwMetrics)
+
+		// Test output warning logs
+		expectedLogs := []observer.LoggedEntry{
+			{
+				Entry: zapcore.Entry{Level: zap.WarnLevel, Message: "Unhandled metric data type."},
+				Context: []zapcore.Field{
+					zap.String("DataType", "IntHistogram"),
+					zap.String("Name", "foo"),
+					zap.String("Unit", "Count"),
+				},
+			},
+		}
+		assert.Equal(t, 1, logs.Len())
+		assert.Equal(t, expectedLogs, logs.AllUntimed())
+	})
+
 	t.Run("Nil metric", func(t *testing.T) {
 		cwMetrics := getCWMetrics(nil, namespace, instrumentationLibName, config)
 		assert.Nil(t, cwMetrics)
@@ -1086,6 +1119,15 @@ func TestBuildCWMetric(t *testing.T) {
 		}
 		assert.Equal(t, expectedFields, cwMetric.Fields)
 	})
+
+	t.Run("Invalid datapoint type", func(t *testing.T) {
+		metric.SetDataType(pdata.MetricDataTypeIntGauge)
+		dp := pdata.NewIntHistogramDataPoint()
+		dp.InitEmpty()
+
+		cwMetric := buildCWMetric(dp, &metric, namespace, metricSlice, instrLibName, "")
+		assert.Nil(t, cwMetric)
+	})
 }
 
 func TestCreateDimensions(t *testing.T) {