Enable and enforce goleak in all packages #30438

crobert-1 · 2024-01-11T17:26:14Z

Component(s)

No response

Is your feature request related to a problem? Please describe.

There's currently no widespread testing in this repository for detecting leaking goroutines. Leaked goroutines are a result of improperly handling concurrency in golang, and a common cause of memory leaks.

Describe the solution you'd like

goleak is a testing tool used to detect leaking goroutines. This is currently being done in core (#9165) and would be useful in contrib as well.

Describe alternatives you've considered

No response

Additional context

No response

The text was updated successfully, but these errors were encountered:

crobert-1 · 2024-01-11T19:41:34Z

A couple notes from my initial efforts:

The tailsampling processor is the only existing package that already uses goleak.
For goleak to work properly it's required to run from the TestMain function of testing. However, the following packages already use TestMain. I'll have to investigate to determine how to use TestMain to accomplish existing functionality as well as goleak for each of these packages.

./testbed/tests/trace_test.go
./testbed/stabilitytests/trace_test.go
./testbed/correctnesstests/traces/correctness_test.go
./exporter/splunkhecexporter/integration_test.go
./exporter/kineticaexporter/exporter_metric_test.go
./exporter/datadogexporter/traces_exporter_test.go

crobert-1 · 2024-01-11T21:06:46Z

I decided to upgrade my bash script for adding goleak to make it do everything in one go, without manual intervention. This used some commands from contrib's makefile to get all go packages, and then filter down to only packages containing tests. The script also now cleans up failing tests to clearly delineate which tests are successul, which are failing.

ALL_PKG_DIRS=$(go list -f '{{ .Dir }}' ./... | sort)
ALL_SRC=$(find $ALL_PKG_DIRS -name '*.go' -not -path '*/third_party/*' -not -path '*/local/*' -type f | sort)
ALL_PKGS_WITH_TESTS=$(dirname $(find $ALL_PKG_DIRS -name '*.go' -not -path '*/third_party/*' -not -path '*/local/*' -type f | grep test.go) | sort --unique)

FAILED_PACKAGES_LIST_FILE="/Users/crobert/dev/opentelemetry-collector-contrib/failed_packages.txt"

for pkg_dir in $ALL_PKGS_WITH_TESTS;
do
  if [[ "$pkg_dir" == '/Users/crobert/dev/opentelemetry-collector-contrib' ]]; then
    echo "Skipping repo head dir"
    continue
  fi

  echo "Attempting package: $pkg_dir"
  cp ./package_test.go $pkg_dir

  PACKAGE_NAME=$(basename $pkg_dir)

  sed -i '' -e "s|package component|package $PACKAGE_NAME|g" $pkg_dir/package_test.go

  pushd . > /dev/null
  cd $pkg_dir
  echo "Running go mod tidy"
  go mod tidy
  echo "Running go test"
  go test -v . > /dev/null
  if [ $? -eq 0 ]; then
    echo "Package was successful"
  else
    echo "Package was not successful"
    echo "$pkg_dir" >> $FAILED_PACKAGES_LIST_FILE
    rm $pkg_dir/package_test.go
    go mod tidy
  fi
  popd > /dev/null
done

Sample output:

~/dev/opentelemetry-collector-contrib $ ./add_leak_test.sh 
Skipping repo head dir
Attempting package: /Users/crobert/dev/opentelemetry-collector-contrib/cmd/configschema
Running go mod tidy
Running go test
Package was not successful
...
Attempting package: /Users/crobert/dev/opentelemetry-collector-contrib/cmd/mdatagen/internal/metadata
Running go mod tidy
Running go test
Package was successful

crobert-1 · 2024-01-11T21:08:29Z

Here's the initial list of failing packages:

./cmd/configschema
./cmd/configschema/cfgmetadatagen/cfgmetadatagen
./cmd/configschema/docsgen/docsgen
./cmd/mdatagen
./cmd/mdatagen/internal/metadata
./cmd/opampsupervisor
./cmd/otelcontribcol
./cmd/oteltestbedcol
./cmd/telemetrygen
./cmd/telemetrygen/internal/e2etest
./connector/countconnector
./connector/datadogconnector
./connector/exceptionsconnector
./connector/failoverconnector
./connector/routingconnector
./connector/servicegraphconnector
./connector/spanmetricsconnector
./exporter/alertmanagerexporter
./exporter/alibabacloudlogserviceexporter
./exporter/awscloudwatchlogsexporter
./exporter/awsemfexporter
./exporter/awskinesisexporter
./exporter/awss3exporter
./exporter/awsxrayexporter
./exporter/azuredataexplorerexporter
./exporter/azuremonitorexporter
./exporter/carbonexporter
./exporter/cassandraexporter
./exporter/clickhouseexporter
./exporter/coralogixexporter
./exporter/datadogexporter
./exporter/datadogexporter/integrationtest
./exporter/datadogexporter/internal/clientutil
./exporter/datadogexporter/internal/hostmetadata
./exporter/datadogexporter/internal/hostmetadata/internal/gohai
./exporter/datadogexporter/internal/hostmetadata/provider
./exporter/datadogexporter/internal/logs
./exporter/datadogexporter/internal/metrics
./exporter/datadogexporter/internal/testutil
./exporter/datasetexporter
./exporter/dynatraceexporter
./exporter/dynatraceexporter/config
./exporter/elasticsearchexporter
./exporter/f5cloudexporter
./exporter/fileexporter
./exporter/googlecloudexporter
./exporter/googlecloudpubsubexporter
./exporter/googlemanagedprometheusexporter
./exporter/honeycombmarkerexporter
./exporter/influxdbexporter
./exporter/instanaexporter
./exporter/kafkaexporter
./exporter/kineticaexporter
./exporter/loadbalancingexporter
./exporter/logicmonitorexporter
./exporter/logicmonitorexporter/internal/logs
./exporter/logicmonitorexporter/internal/traces
./exporter/logzioexporter
./exporter/lokiexporter
./exporter/mezmoexporter
./exporter/opencensusexporter
./exporter/opensearchexporter
./exporter/prometheusexporter
./exporter/prometheusremotewriteexporter
./exporter/pulsarexporter
./exporter/sapmexporter
./exporter/sentryexporter
./exporter/signalfxexporter
./exporter/signalfxexporter/internal/correlation
./exporter/signalfxexporter/internal/dimensions
./exporter/signalfxexporter/internal/hostmetadata
./exporter/signalfxexporter/internal/translation
./exporter/skywalkingexporter
./exporter/splunkhecexporter
./exporter/sumologicexporter
./exporter/syslogexporter
./exporter/tencentcloudlogserviceexporter
./exporter/zipkinexporter
./extension/asapauthextension
./extension/awsproxy
./extension/basicauthextension
./extension/bearertokenauthextension
./extension/encoding/jaegerencodingextension
./extension/encoding/jsonlogencodingextension
./extension/encoding/otlpencodingextension
./extension/encoding/textencodingextension
./extension/encoding/zipkinencodingextension
./extension/headerssetterextension
./extension/healthcheckextension
./extension/httpforwarder
./extension/jaegerremotesampling
./extension/jaegerremotesampling/internal
./extension/oauth2clientauthextension
./extension/observer/dockerobserver
./extension/observer/ecsobserver
./extension/observer/ecstaskobserver
./extension/observer/hostobserver
./extension/observer/k8sobserver
./extension/oidcauthextension
./extension/opampextension
./extension/pprofextension
./extension/remotetapextension
./extension/sigv4authextension
./extension/storage/dbstorage
./extension/storage/filestorage
./extension/storage/storagetest
./internal/aws/ecsutil
./internal/aws/k8s/k8sclient
./internal/aws/proxy
./internal/aws/xray
./internal/aws/xray/telemetry
./internal/common/ttlmap
./internal/datadog
./internal/docker
./internal/filter/filterottl
./internal/metadataproviders/aws/ec2
./internal/metadataproviders/azure
./internal/sharedcomponent
./internal/splunk
./pkg/ottl
./pkg/ottl/e2e
./pkg/ottl/ottlfuncs
./pkg/stanza/adapter
./pkg/stanza/operator/helper
./pkg/stanza/operator/parser/regex
./pkg/stanza/operator/transformer/recombine
./processor/attributesprocessor
./processor/cumulativetodeltaprocessor
./processor/datadogprocessor
./processor/deltatorateprocessor
./processor/filterprocessor
./processor/groupbyattrsprocessor
./processor/groupbytraceprocessor
./processor/k8sattributesprocessor
./processor/k8sattributesprocessor/internal/kube
./processor/k8sattributesprocessor/internal/observability
./processor/logstransformprocessor
./processor/metricsgenerationprocessor
./processor/metricstransformprocessor
./processor/probabilisticsamplerprocessor
./processor/redactionprocessor
./processor/remotetapprocessor
./processor/resourcedetectionprocessor
./processor/resourcedetectionprocessor/internal
./processor/resourcedetectionprocessor/internal/aws/ec2
./processor/resourcedetectionprocessor/internal/aws/ecs
./processor/resourcedetectionprocessor/internal/aws/eks
./processor/resourcedetectionprocessor/internal/aws/elasticbeanstalk
./processor/resourcedetectionprocessor/internal/aws/lambda
./processor/resourcedetectionprocessor/internal/azure
./processor/resourcedetectionprocessor/internal/azure/aks
./processor/resourcedetectionprocessor/internal/docker
./processor/resourcedetectionprocessor/internal/env
./processor/resourcedetectionprocessor/internal/heroku
./processor/resourcedetectionprocessor/internal/k8snode
./processor/resourcedetectionprocessor/internal/system
./processor/resourceprocessor
./processor/routingprocessor
./processor/schemaprocessor
./processor/servicegraphprocessor
./processor/spanmetricsprocessor
./processor/spanprocessor
./processor/sumologicprocessor
./processor/tailsamplingprocessor
./processor/tailsamplingprocessor/internal/sampling
./processor/transformprocessor
./processor/transformprocessor/internal/logs
./processor/transformprocessor/internal/metrics
./processor/transformprocessor/internal/traces
./receiver/activedirectorydsreceiver
./receiver/activedirectorydsreceiver/internal/metadata
./receiver/aerospikereceiver
./receiver/aerospikereceiver/internal/metadata
./receiver/apachereceiver
./receiver/apachereceiver/internal/metadata
./receiver/apachesparkreceiver
./receiver/apachesparkreceiver/internal/metadata
./receiver/awscloudwatchmetricsreceiver
./receiver/awscloudwatchreceiver
./receiver/awscontainerinsightreceiver
./receiver/awscontainerinsightreceiver/internal/cadvisor
./receiver/awscontainerinsightreceiver/internal/ecsInfo
./receiver/awscontainerinsightreceiver/internal/host
./receiver/awscontainerinsightreceiver/internal/k8sapiserver
./receiver/awscontainerinsightreceiver/internal/stores
./receiver/awsecscontainermetricsreceiver
./receiver/awsfirehosereceiver
./receiver/awsxrayreceiver
./receiver/awsxrayreceiver/internal/udppoller
./receiver/azureblobreceiver
./receiver/azureeventhubreceiver
./receiver/azuremonitorreceiver
./receiver/azuremonitorreceiver/internal/metadata
./receiver/bigipreceiver
./receiver/bigipreceiver/internal/metadata
./receiver/carbonreceiver
./receiver/chronyreceiver
./receiver/chronyreceiver/internal/metadata
./receiver/cloudflarereceiver
./receiver/cloudfoundryreceiver
./receiver/collectdreceiver
./receiver/couchdbreceiver
./receiver/couchdbreceiver/internal/metadata
./receiver/datadogreceiver
./receiver/dockerstatsreceiver
./receiver/dockerstatsreceiver/internal/metadata
./receiver/elasticsearchreceiver
./receiver/elasticsearchreceiver/internal/metadata
./receiver/expvarreceiver
./receiver/expvarreceiver/internal/metadata
./receiver/filelogreceiver
./receiver/filereceiver
./receiver/filestatsreceiver
./receiver/filestatsreceiver/internal/metadata
./receiver/flinkmetricsreceiver
./receiver/flinkmetricsreceiver/internal/metadata
./receiver/fluentforwardreceiver
./receiver/fluentforwardreceiver/observ
./receiver/gitproviderreceiver
./receiver/gitproviderreceiver/internal/metadata
./receiver/gitproviderreceiver/internal/scraper/githubscraper
./receiver/googlecloudpubsubreceiver
./receiver/googlecloudpubsubreceiver/internal
./receiver/googlecloudspannerreceiver
./receiver/googlecloudspannerreceiver/internal/datasource
./receiver/googlecloudspannerreceiver/internal/filter
./receiver/googlecloudspannerreceiver/internal/filterfactory
./receiver/googlecloudspannerreceiver/internal/metadata
./receiver/googlecloudspannerreceiver/internal/metadataconfig
./receiver/googlecloudspannerreceiver/internal/metadataparser
./receiver/googlecloudspannerreceiver/internal/statsreader
./receiver/haproxyreceiver
./receiver/haproxyreceiver/internal/metadata
./receiver/hostmetricsreceiver
./receiver/hostmetricsreceiver/internal/scraper/cpuscraper
./receiver/hostmetricsreceiver/internal/scraper/cpuscraper/internal/metadata
./receiver/hostmetricsreceiver/internal/scraper/diskscraper
./receiver/hostmetricsreceiver/internal/scraper/diskscraper/internal/metadata
./receiver/hostmetricsreceiver/internal/scraper/filesystemscraper
./receiver/hostmetricsreceiver/internal/scraper/filesystemscraper/internal/metadata
./receiver/hostmetricsreceiver/internal/scraper/loadscraper
./receiver/hostmetricsreceiver/internal/scraper/loadscraper/internal/metadata
./receiver/hostmetricsreceiver/internal/scraper/memoryscraper
./receiver/hostmetricsreceiver/internal/scraper/memoryscraper/internal/metadata
./receiver/hostmetricsreceiver/internal/scraper/networkscraper
./receiver/hostmetricsreceiver/internal/scraper/networkscraper/internal/metadata
./receiver/hostmetricsreceiver/internal/scraper/pagingscraper
./receiver/hostmetricsreceiver/internal/scraper/pagingscraper/internal/metadata
./receiver/hostmetricsreceiver/internal/scraper/processesscraper
./receiver/hostmetricsreceiver/internal/scraper/processesscraper/internal/metadata
./receiver/hostmetricsreceiver/internal/scraper/processscraper
./receiver/hostmetricsreceiver/internal/scraper/processscraper/internal/metadata
./receiver/httpcheckreceiver
./receiver/httpcheckreceiver/internal/metadata
./receiver/iisreceiver
./receiver/iisreceiver/internal/metadata
./receiver/influxdbreceiver
./receiver/jaegerreceiver
./receiver/jmxreceiver
./receiver/jmxreceiver/internal/subprocess
./receiver/journaldreceiver
./receiver/k8sclusterreceiver
./receiver/k8sclusterreceiver/internal/clusterresourcequota
./receiver/k8sclusterreceiver/internal/collection
./receiver/k8sclusterreceiver/internal/cronjob
./receiver/k8sclusterreceiver/internal/demonset
./receiver/k8sclusterreceiver/internal/deployment
./receiver/k8sclusterreceiver/internal/hpa
./receiver/k8sclusterreceiver/internal/jobs
./receiver/k8sclusterreceiver/internal/metadata
./receiver/k8sclusterreceiver/internal/namespace
./receiver/k8sclusterreceiver/internal/node
./receiver/k8sclusterreceiver/internal/pod
./receiver/k8sclusterreceiver/internal/replicaset
./receiver/k8sclusterreceiver/internal/replicationcontroller
./receiver/k8sclusterreceiver/internal/resourcequota
./receiver/k8sclusterreceiver/internal/statefulset
./receiver/k8seventsreceiver
./receiver/k8sobjectsreceiver
./receiver/kafkametricsreceiver
./receiver/kafkametricsreceiver/internal/metadata
./receiver/kafkareceiver
./receiver/kubeletstatsreceiver
./receiver/kubeletstatsreceiver/internal/kubelet
./receiver/kubeletstatsreceiver/internal/metadata
./receiver/lokireceiver
./receiver/memcachedreceiver
./receiver/memcachedreceiver/internal/metadata
./receiver/mongodbatlasreceiver
./receiver/mongodbatlasreceiver/internal/metadata
./receiver/mongodbreceiver
./receiver/mongodbreceiver/internal/metadata
./receiver/mysqlreceiver
./receiver/mysqlreceiver/internal/metadata
./receiver/namedpipereceiver
./receiver/nginxreceiver
./receiver/nginxreceiver/internal/metadata
./receiver/nsxtreceiver
./receiver/nsxtreceiver/internal/metadata
./receiver/opencensusreceiver
./receiver/opencensusreceiver/internal/ocmetrics
./receiver/opencensusreceiver/internal/octrace
./receiver/oracledbreceiver
./receiver/oracledbreceiver/internal/metadata
./receiver/osqueryreceiver
./receiver/otlpjsonfilereceiver
./receiver/podmanreceiver
./receiver/postgresqlreceiver
./receiver/postgresqlreceiver/internal/metadata
./receiver/prometheusreceiver
./receiver/prometheusreceiver/internal
./receiver/pulsarreceiver
./receiver/purefareceiver
./receiver/purefareceiver/internal
./receiver/purefbreceiver
./receiver/purefbreceiver/internal
./receiver/rabbitmqreceiver
./receiver/rabbitmqreceiver/internal/metadata
./receiver/receivercreator
./receiver/redisreceiver
./receiver/redisreceiver/internal/metadata
./receiver/riakreceiver
./receiver/riakreceiver/internal/metadata
./receiver/saphanareceiver
./receiver/saphanareceiver/internal/metadata
./receiver/sapmreceiver
./receiver/signalfxreceiver
./receiver/simpleprometheusreceiver
./receiver/skywalkingreceiver
./receiver/snmpreceiver
./receiver/snowflakereceiver
./receiver/snowflakereceiver/internal/metadata
./receiver/solacereceiver
./receiver/splunkenterprisereceiver
./receiver/splunkenterprisereceiver/internal/metadata
./receiver/splunkhecreceiver
./receiver/sqlqueryreceiver
./receiver/sqlserverreceiver
./receiver/sqlserverreceiver/internal/metadata
./receiver/sshcheckreceiver
./receiver/sshcheckreceiver/internal/configssh
./receiver/sshcheckreceiver/internal/metadata
./receiver/statsdreceiver
./receiver/syslogreceiver
./receiver/tcplogreceiver
./receiver/udplogreceiver
./receiver/vcenterreceiver
./receiver/vcenterreceiver/internal/metadata
./receiver/wavefrontreceiver
./receiver/webhookeventreceiver
./receiver/windowseventlogreceiver
./receiver/windowsperfcountersreceiver
./receiver/zipkinreceiver
./receiver/zookeeperreceiver
./receiver/zookeeperreceiver/internal/metadata
./testbed/correctnesstests/metrics
./testbed/correctnesstests/traces
./testbed/stabilitytests
./testbed/testbed
./testbed/tests

crobert-1 · 2024-01-12T18:45:42Z

After ignoring opencensus-go issues, here's the remaining package list that needs to be enabled:

./cmd/configschema - [chore][cmd/configschema] Enable goleak #30492
./cmd/configschema/docsgen/docsgen - [chore][cmd/configschema/docsgen/docsgen] Enable goleak #30494
./cmd/mdatagen - Need to fix in core, it's actively being removed from contrib.
./cmd/opampsupervisor - [cmd/opampsupervisor] Fix memory leak and enable goleak #30496, [cmd/opampsupervisor] Fix leaks in e2e tests #32477
./cmd/otelcontribcol - Blocked by Remove tests from cmd/otelcontribcol #30884
./cmd/oteltestbedcol - [chore][cmd/oteltestbedcol] Enable goleak #31725
./cmd/telemetrygen - [chore][cmd/telemetrygen] Enable goleak #31724
./cmd/telemetrygen/internal/e2etest
./connector/datadogconnector - [connector/datadog] Fix leaking goroutines and enable goleak #30500, [connector/datadog] Shutdown hangs #30487
./exporter/alertmanagerexporter - [chore][exporter/alertmanagerexporter] Enable goleak check #30710
./exporter/alibabacloudlogserviceexporter - Started working, running into some challenging potential third party leaks: https://github.com/crobert-1/opentelemetry-collector-contrib/tree/goleak_alibabaexporter
./exporter/awscloudwatchlogsexporter - Initial investigation: [chore][awscloudwatchlogsexporter] Enable goleak check #30744, Fixed in [chore][awscloudwatchlogsexporter] Enable goleak check #31891
./exporter/awsemfexporter
./exporter/awss3exporter
./exporter/awsxrayexporter
./exporter/azuredataexplorerexporter - [chore][exporter/azuredataexplorerexporter] Enable goleak check #30768
./exporter/azuremonitorexporter - [exporter/azuremonitor] Fix memory leaks on shutdown #30801
./exporter/coralogixexporter - [chore][exporter/coralogixexporter] Enable goleak check #30803
./exporter/datadogexporter
./exporter/datadogexporter/integrationtest
./exporter/datadogexporter/internal/hostmetadata
./exporter/datadogexporter/internal/hostmetadata/internal/gohai
./exporter/datadogexporter/internal/hostmetadata/provider
./exporter/datadogexporter/internal/testutil
./exporter/datasetexporter
~~- [ ] ./exporter/dynatraceexporter~~ Component deleted.
./exporter/fileexporter - [chore][exporter/fileexporter] Enable goleak check #30899
./exporter/googlecloudpubsubexporter
./exporter/kafkaexporter - [chore][exporter/kafka] Enable goleak check #30961
./exporter/kineticaexporter
./exporter/loadbalancingexporter - [exporter/loadbalancing] Fix memory leaks #31050
./exporter/logicmonitorexporter - [exporter/logicmonitorexporter] Fix leaking goroutines on shutdown #31150
./exporter/logzioexporter - [chore][exporter/logzioexporter] Enable goleak check #31151
./exporter/opencensusexporter - [receiver/opencensusreceiver] Fix memory leak on shutdown #31152
./exporter/prometheusexporter - [chore][exporter/prometheusexporter] Enable goleak check #30965
./exporter/prometheusremotewriteexporter - [chore][exporter/prometheusremotewriteexporter] Enable goleak check #30966
./exporter/pulsarexporter - [chore][exporter/pulsar] Enable goleak #33135
./exporter/signalfxexporter
./exporter/signalfxexporter/internal/dimensions
./exporter/signalfxexporter/internal/correlation - [exporter/signalfx] Fix memory leaks #31772
./exporter/signalfxexporter/internal/apm/correlations - [exporter/signalfx] Fix memory leaks #31772
./exporter/signalfxexporter/internal/translation
./exporter/skywalkingexporter
./exporter/splunkhecexporter - [chore][exporter/splunkhecexporter] Enable goleak check #30968
./exporter/sumologicexporter
./exporter/tencentcloudlogserviceexporter
./extension/asapauthextension
./extension/awsproxy
./extension/basicauthextension - [chore] Enable goleak for tests failing on opencensus-go #30457
./extension/bearertokenauthextension - [chore][extension/bearertokenauth] Enable goleak check #31154
./extension/jaegerremotesampling - [chore][extension/jaegarremotesampling] Enable goleak check #31155
./extension/jaegerremotesampling/internal - [extension/jaegarremotesamplingextension/internal] add goleak tests for jaegerremotesampling extension #31661
./extension/oidcauthextension
./extension/opampextension - [chore][extension/opampextension] Enable goleak check #31175
./extension/sigv4authextension
./internal/aws/k8s/k8sclient - [chore][internal/aws/k8s/k8sclient] Enable goleak check #30761
./internal/aws/proxy
./internal/aws/xray
./internal/aws/xray/telemetry
./internal/common/ttlmap - [internal/common/ttlmap] Fix leak caused by time.Tick #32044
./internal/datadog
./internal/docker - [chore][internal/docker] Enable goleak check #32046
./internal/metadataproviders/aws/ec2
./internal/metadataproviders/azure - [internal/metadataproviders/azure] Fix memory leak on AKS #32574
./pkg/stanza/adapter - [chore][pkg/stanza/adapter] Enable goleak check #30969
./pkg/stanza/operator/helper - [chore][pkg/stanza/operator/helper] Enable goleak check #31092
./pkg/stanza/operator/parser/regex - [chore][pkg/stanza] Fix goroutine leak in regex parser #31108
./pkg/stanza/operator/transformer/recombine - [chore][pkg/stanza/operator/transformer/recombine] Enable goleak check #31095
./processor/cumulativetodeltaprocessor - [chore][processor/cumulativetodeltaprocessor] Enable goleak check #30804
./processor/datadogprocessor
./processor/groupbytraceprocessor - [chore][processor/groupbytrace] Enable goleak check #32573
./processor/k8sattributesprocessor - [processor/k8sattributesprocessor] Fix memory leak #30842
./processor/k8sattributesprocessor/internal/kube - [processor/k8sattributesprocessor] Fix memory leak #30842
./processor/k8sattributesprocessor/internal/observability - [processor/k8sattributesprocessor] Fix memory leak #30842
./processor/remotetapprocessor - [processor/remotetap] Fix memory leak on shutdown #32571
~~- [ ] ./processor/servicegraphprocessor~~ Component has been removed.
~~- [x] ./processor/spanmetricsprocessor - [chore][processor/spanmetricsprocessor] Enable goleak check #31176~~
./processor/tailsamplingprocessor - [chore] Enable all (passing) goleak checks #30451
./receiver/activedirectorydsreceiver/internal/metadata
./receiver/aerospikereceiver - [chore][receiver/aerospike] Enable goleak check #32567
./receiver/aerospikereceiver/internal/metadata
./receiver/apachereceiver - [chore][receiver/apache] Enable goleak check #32472
./receiver/awscontainerinsightreceiver - [chore][receiver/awscontainerinsight] Enable goleak check #32462
./receiver/awscontainerinsightreceiver/internal/ecsInfo - [chore][receiver/awscontainerinsight] Enable goleak checks in internal packages #32406
./receiver/awscontainerinsightreceiver/internal/host - [chore][receiver/awscontainerinsight] Enable goleak checks in internal packages #32406
./receiver/awscontainerinsightreceiver/internal/k8sapiserver - [receiver/awscontainerinsight] Fix memory leak on shutdown in k8s API server #32405
./receiver/awscontainerinsightreceiver/internal/stores - [chore][receiver/awscontainerinsight] Enable goleak checks in internal packages #32406
./receiver/awscontainerinsights/internal/cadvisor - [chore][receiver/awscontainerinsights] Enable goleak checks #32404
./receiver/awsxrayreceiver/internal/udppoller - [chore][receiver/awsxray] Enable goleak checks #32402
./receiver/azureeventhubreceiver - [chore][receiver/azureeventhub] Enable goleak check #32364, [receiver/azureeventhub] Fix memory leak on shutdown #32401
./receiver/dockerstatsreceiver - [receiver/dockerstats] Fix leaking goroutines #31668
./receiver/fluentforwardreceiver - [receiver/fluentforward] Fix memory leak #32363
./receiver/gitproviderreceiver/internal/scraper/githubscraper - [chore][receiver/gitproviderreceiver] Enable goleak check in GitHub scraper #32362
./receiver/googlecloudpubsubreceiver - [receiver/googlecloudpubsubreceiver] Fix memory leak during shutdown #32361
./receiver/googlecloudpubsubreceiver/internal - [chore][receiver/googlecloudpubsubreceiver/internal] Enable goleak check #32311
./receiver/googlecloudspannerreceiver
./receiver/googlecloudspannerreceiver/internal/datasource - There's currently a leak caused by third party dependency, but it may be resolved once the google-api-client upgrades its oauth2 dependency to v0.19+, as it changes functionality of the Credentials.GetUniverseDomain method. The google api dep has been updated in v0.174.0, so once the dep in our repo is updated this can be tried again.
./receiver/googlecloudspannerreceiver/internal/filter - [chore][receiver/googlecloudspannerreceiver] Enable goleak checks #32307
./receiver/googlecloudspannerreceiver/internal/filterfactory - [chore][receiver/googlecloudspannerreceiver] Enable goleak checks #32307
./receiver/googlecloudspannerreceiver/internal/statsreader - [chore][receiver/googlecloudspannerreceiver] Enable goleak checks #32307
./receiver/jaegerreceiver - [chore] Add goleak tests for jaeger receiver #31687
./receiver/jmxreceiver - [receiver/jmx] Fix memory leak on shutdown #32289
./receiver/jmxreceiver/internal/subprocess - [chore][receiver/jmx/internal/subprocess] Enable goleak check #31773
./receiver/k8sclusterreceiver - [chore][receiver/k8sclusterreceiver] Enable goleak check #30898
./receiver/k8seventsreceiver - [chore][receiver/k8sevent] Enable goleak check #31917
./receiver/k8sobjectsreceiver - [receiver/k8sobjects] Fix memory leak caused by pull mode's interval ticker #31919 fixed a leak, but goleak hasn't been added yet due to internal/k8stest leak bug.
./receiver/kubeletstatsreceiver - Blocked by [internal/k8stest] Leaking goroutine when creating and deleting objects #31047
./receiver/mongodbatlasreceiver - [receiver/mongodbatlas] Fix memory leak #32206
./receiver/namedpipereceiver - [chore][receiver/namedpipe] Enable goleak check #32200
./receiver/nginxreceiver - [chore][receiver/nginx] Enable goleak check #32198
./receiver/nsxtreceiver - [chore][receiver/nsxt] Enable goleak check #32197
./receiver/opencensusreceiver - [receiver/opencensusreceiver] Fix memory leak on shutdown #31152
./receiver/podmanreceiver - [chore][receiver/podman] Enable goleak check #32196
./receiver/prometheusreceiver - [chore] add goleak tests for prometheusreceiver #31630
./receiver/pulsarreceiver - [chore][receiver/pulsar] Enable goleak check #32195
./receiver/purefareceiver - [chore][receiver/purefa] Enable goleak check #32194
./receiver/purefbreceiver - [chore][receiver/purefb] Enable goleak check #32184
./receiver/saphanareceiver - [chore][receiver/saphana] Enable goleak check #32183
./receiver/sapmreceiver - [chore][receiver/sapmreceiver] Enable goleak check #31666
./receiver/signalfxreceiver - Blocked by [internal/common/ttlmap] Fix leak caused by time.Tick #32044
./receiver/snowflakereceiver - [chore][receiver/snowflake] Enable goleak check #32182
./receiver/splunkhecreceiver - [chore] add goleak tests for splunkhecreceiver #31619
./receiver/sqlqueryreceiver - [chore][receiver/sqlquery] Enable goleak check #31667
./receiver/sshcheckreceiver - [chore][receiver/sshcheck] Enable goleak check #32181
./receiver/zookeeperreceiver - [chore][receiver/zookeeper] Enable goleak check #32179
./testbed/correctnesstests/metrics
./testbed/correctnesstests/traces
./testbed/stabilitytests
./testbed/testbed
./testbed/tests

**Description:** <Describe what has changed.>  This PR contains 3 main changes: 1. Make a copy of the same file into every package whose `goleak` check is currently passing. The only change for the `package_test.go` file in each package is the package name itself. 2. Rename `processor/tailsamplingprocessor/main_test.go` to `package_test.go` for uniformity. `package_test.go` is the name we chose for core (see discussion [here](open-telemetry/opentelemetry-collector#9173 (comment))). 3. Run `make gotidy` to add `goleak` dependency. I included the script used to make these changes [in the issue](#30438 (comment)). **Link to tracking Issue:** <Issue number if applicable> #30438

**Description:** <Describe what has changed.>  This PR contains 3 main changes: 1. Make a copy of the same file into every package whose `goleak` check is currently passing. The only change for the `package_test.go` file in each package is the package name itself. 2. Rename `processor/tailsamplingprocessor/main_test.go` to `package_test.go` for uniformity. `package_test.go` is the name we chose for core (see discussion [here](open-telemetry/opentelemetry-collector#9173 (comment))). 3. Run `make gotidy` to add `goleak` dependency. I included the script used to make these changes [in the issue](open-telemetry#30438 (comment)). **Link to tracking Issue:** <Issue number if applicable> open-telemetry#30438

**Description:** <Describe what has changed.>  Enables goleak check on tests in the `alertmanager` exporter to ensure it's not leaking goroutines. This is a test only change. **Link to tracking Issue:** <Issue number if applicable> #30438 **Testing:** <Describe what testing was performed and which tests were added.> All tests are passing, goleak check is passing.

This is a test only change, adding `goleak` to help ensure no goroutines are being leaked. This passed in local testing without any changes. #30438 `goleak` is passing

This originally was failing in CI/CD, but has passed 10+ times in a row, I think it's safe to merge. **Link to tracking Issue:** #30438

* Update module google.golang.org/api to v0.178.0 (#32927) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google.golang.org/api](https://togithub.com/googleapis/google-api-go-client) | `v0.177.0` -> `v0.178.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/google.golang.org%2fapi/v0.178.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/google.golang.org%2fapi/v0.178.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/google.golang.org%2fapi/v0.177.0/v0.178.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/google.golang.org%2fapi/v0.177.0/v0.178.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleapis/google-api-go-client (google.golang.org/api)</summary> ### [`v0.178.0`](https://togithub.com/googleapis/google-api-go-client/releases/tag/v0.178.0) [Compare Source](https://togithub.com/googleapis/google-api-go-client/compare/v0.177.0...v0.178.0) ##### Features - **all:** Auto-regenerate discovery clients ([#2561](https://togithub.com/googleapis/google-api-go-client/issues/2561)) ([2d22d11](https://togithub.com/googleapis/google-api-go-client/commit/2d22d11df9643a4fad0f9e952d7a92a419370122)) - **all:** Auto-regenerate discovery clients ([#2564](https://togithub.com/googleapis/google-api-go-client/issues/2564)) ([b313e4b](https://togithub.com/googleapis/google-api-go-client/commit/b313e4bd70e601fd7a2a931f168fb1dece980e75)) - **all:** Auto-regenerate discovery clients ([#2565](https://togithub.com/googleapis/google-api-go-client/issues/2565)) ([0843d21](https://togithub.com/googleapis/google-api-go-client/commit/0843d217048b2e713c0d273b95b33afb99926a8c)) - **all:** Auto-regenerate discovery clients ([#2567](https://togithub.com/googleapis/google-api-go-client/issues/2567)) ([76b27f1](https://togithub.com/googleapis/google-api-go-client/commit/76b27f162032649ddb3cb3f06ed24c7333b3fa66)) - **all:** Auto-regenerate discovery clients ([#2568](https://togithub.com/googleapis/google-api-go-client/issues/2568)) ([d922e3b](https://togithub.com/googleapis/google-api-go-client/commit/d922e3b559ce5832941390b4f9bf91210e3f6579)) - **all:** Auto-regenerate discovery clients ([#2570](https://togithub.com/googleapis/google-api-go-client/issues/2570)) ([f2da582](https://togithub.com/googleapis/google-api-go-client/commit/f2da582c9f6aab240d44c8ebd2dcc43f5096f896)) - **all:** Auto-regenerate discovery clients ([#2571](https://togithub.com/googleapis/google-api-go-client/issues/2571)) ([0c976dc](https://togithub.com/googleapis/google-api-go-client/commit/0c976dcc8d1d653f2284ce273493e6714a6d4b2a)) - **gen:** Add internaloption.EnableNewAuthLibrary ([#2519](https://togithub.com/googleapis/google-api-go-client/issues/2519)) ([8c74bb8](https://togithub.com/googleapis/google-api-go-client/commit/8c74bb83e2bc27188154c506e63a3e0f3a042f55)) - **google-api-go-client:** Add x-goog-api-version header ([#2563](https://togithub.com/googleapis/google-api-go-client/issues/2563)) ([fe54ffd](https://togithub.com/googleapis/google-api-go-client/commit/fe54ffd92359506fca1ffd70dc647db0ab9a903c)) ##### Documentation - Update commit style in CONTRIBUTING ([#2566](https://togithub.com/googleapis/google-api-go-client/issues/2566)) ([5e44215](https://togithub.com/googleapis/google-api-go-client/commit/5e44215df618fcafd5f6c1bbe259062cddd32f1a)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> * chore: add constants for prometheus translation (#32830) **Description:** This is a cleanup to consolidate the constants used for prometheus translation in a single place. --------- Co-authored-by: Curtis Robert <crobert@splunk.com> * sumologicexporter!: change metrics behavior (#32737) **Description:** <Describe what has changed.>  * remove suppport for carbon2 and graphite * add support for otlp format * do not support metadata attributes * do not support source headers * set otlp as default format This PR reduces size of #32315 **Link to tracking Issue:** #31479 **Testing:** - unit tests - manual tests **Documentation:** - Readme --------- Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> Co-authored-by: Adam Boguszewski <aboguszewski@sumologic.com> * Update module github.com/aws/aws-sdk-go to v1.52.4 (#32928) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/aws/aws-sdk-go](https://togithub.com/aws/aws-sdk-go) | `v1.52.3` -> `v1.52.4` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go/v1.52.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go/v1.52.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go/v1.52.3/v1.52.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go/v1.52.3/v1.52.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>aws/aws-sdk-go (github.com/aws/aws-sdk-go)</summary> ### [`v1.52.4`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v1524-2024-05-07) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.52.3...v1.52.4) \=== ##### Service Client Updates - `service/b2bi`: Updates service documentation - `service/budgets`: Updates service API and documentation - This release adds tag support for budgets and budget actions. - `service/resiliencehub`: Updates service API, documentation, and paginators - `service/route53profiles`: Updates service API and documentation </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> * [chore][receiver/sqlserver] Update documentation for darwin and linux OS (#32878) **Description:** <Describe what has changed.>  With the enhancement in https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/30297, the SQL Server receiver can now run on MacOS and Linux, since it no longer solely relies on Windows. The difference in functionality has (hopefully) been documented clearly between the different platforms, so the unsupported warning can be removed. I missed this in my previous PRs. * Update module github.com/grafana/loki/pkg/push to v0.0.0-20240507085123-772616cd8f5c (#32897) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/grafana/loki/pkg/push](https://togithub.com/grafana/loki) | `v0.0.0-20240506154431-a772ed705c65` -> `v0.0.0-20240507085123-772616cd8f5c` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgrafana%2floki%2fpkg%2fpush/v0.0.0-20240507085123-772616cd8f5c?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgrafana%2floki%2fpkg%2fpush/v0.0.0-20240507085123-772616cd8f5c?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgrafana%2floki%2fpkg%2fpush/v0.0.0-20240506154431-a772ed705c65/v0.0.0-20240507085123-772616cd8f5c?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgrafana%2floki%2fpkg%2fpush/v0.0.0-20240506154431-a772ed705c65/v0.0.0-20240507085123-772616cd8f5c?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> * chore(deps): update dependency go to v1.22.3 (#32621) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [go](https://go.dev/) ([source](https://togithub.com/golang/go)) | toolchain | minor | `1.21.9` -> `1.22.3` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>golang/go (go)</summary> ### [`v1.22.3`](https://togithub.com/golang/go/compare/go1.22.2...go1.22.3) ### [`v1.22.2`](https://togithub.com/golang/go/compare/go1.22.1...go1.22.2) ### [`v1.22.1`](https://togithub.com/golang/go/compare/go1.22.0...go1.22.1) ### [`v1.22.0`](https://togithub.com/golang/go/compare/go1.21.7...go1.22rc1) ### [`v1.21.10`](https://togithub.com/golang/go/compare/go1.21.9...go1.21.10) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> * [receiver/haproxy] Unit test timing out (#32940) I wasn't able to reproduce the exact situation from CI, but the tests I changed weren't completing at all here. Looking closely, it looks like they never closed the stream, something the first test does. After closing it, the tests start passing locally for me. While I'm not confident this will fix the CI flaky failures, this does make the test work locally for me. Fixes #32877 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com> * [connector/servicegraph] Remove use of host.GetExporters (#32902) Fixes #31628 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> --------- Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com> * [exporter/loadbalancing] Improve the performance when merging traces belonging to the same backend (#32032) **Description:** no need to reimplement that in an extremely allocation-inefficient fashion. I'm actually not sure why mergeTraces() and mergeMetrics() need to exist in the first place; all the other exporters coupled with the batch processor work just fine, not sure why loadbalancing would be special. https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/30141 seems to imply they were implemented to improve performance, but I don't really understand why batch processor would not have been sufficient for that improvement originally. benchmarks before: ``` goos: darwin goarch: arm64 pkg: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/loadbalancingexporter BenchmarkMergeTraces_X100-8 50214 23507 ns/op BenchmarkMergeTraces_X500-8 10000 113952 ns/op BenchmarkMergeTraces_X1000-8 5208 226062 ns/op BenchmarkMergeMetrics_X100-8 64933 18540 ns/op BenchmarkMergeMetrics_X500-8 12885 91418 ns/op BenchmarkMergeMetrics_X1000-8 6590 184584 ns/op PASS ok github.com/open-telemetry/opentelemetry-collector-contrib/exporter/loadbalancingexporter 9.783s ``` and after: ``` goos: darwin goarch: arm64 pkg: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/loadbalancingexporter BenchmarkMergeTraces_X100-8 295886529 3.836 ns/op BenchmarkMergeTraces_X500-8 309865370 3.833 ns/op BenchmarkMergeTraces_X1000-8 310739948 3.800 ns/op BenchmarkMergeMetrics_X100-8 315567813 3.841 ns/op BenchmarkMergeMetrics_X500-8 310341650 3.849 ns/op BenchmarkMergeMetrics_X1000-8 314292003 3.830 ns/op PASS ok github.com/open-telemetry/opentelemetry-collector-contrib/exporter/loadbalancingexporter 10.733s ``` **Link to tracking Issue:** n/a **Testing:** unit tests pass & cpu time for our collectors using loadbalancingexporter (12 replicas, total of 25k-40k spans/sec) went from 800ms-1400ms/sec down to <40msec/sec. **Documentation:** none --------- Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de> * Move Aneurysm9 to emeritus status (#32943) I have been unable to provide this position the bandwidth that it deserves and it is time to formalize recognition of that fact. Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * [receiver/googlecloudpubsubreceiver] Fix memory leak during shutdown (#32361) **Description:** <Describe what has changed.>  This PR contains the following changes: 1. Add `Close` call to the receiver's GRPC client. Without this, goroutines were being leaked on shutdown. 2. Change `grpc.Dial` -> `grpc.NewClient`. They offer the same functionality, but `Dial` is being deprecated in favor of `NewClient`. 3. Enable `goleak` checks on this receiver to help ensure no goroutines are being leaked. 4. Change a couple `Assert.Nil` calls to `Assert.NoError`. The output of `NoError` includes the error message if hit, `Nil` simply includes the object's address, i.e. `&status.Error{s:(*status.Status)(0xc00007e158)}` **Link to tracking Issue:** <Issue number if applicable> #30438 **Testing:** <Describe what testing was performed and which tests were added.> All existing tests are passing, as well as added goleak check. * [chore] Add some docs to readme regarding file exporter (#32855) Admittedly I tested this via docker-compose. I can expand to having a full docker-compose file with telemetry gen if that's preferred. --------- Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com> * [receiver/vcenter] Fixes Cluster Resource Attributes for Datastore Resource (#32687) **Description:** <Describe what has changed.> Removed the `vcenter.cluster.name` resource attribute from all Datastore resources. **Link to tracking Issue:** <Issue number if applicable> #32674 **Testing:** <Describe what testing was performed and which tests were added.> Unit/integration tests updated and tested. Local environment tested. **Documentation:** <Describe the documentation added.> New documentation generated based on the metadata. --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com> Co-authored-by: Curtis Robert <crobert@splunk.com> * [receiver/vcenter] Adds New Packet Dropped Rate Metric for VMs (#32930) **Description:** <Describe what has changed.> Adds new default disabled (with Warning log for default enabled on next release) metric `vcenter.vm.network.packet.drop.rate` for Virtual Machines. This metric makes use of the `droppedRx` and `droppedTx` Network performance metrics detailed [here](https://vdc-repo.vmware.com/vmwb-repository/dcr-public/d1902b0e-d479-46bf-8ac9-cee0e31e8ec0/07ce8dbd-db48-4261-9b8f-c6d3ad8ba472/network_counters.html) for Virtual machines. This would use the same metric attributes as the other VM packet metrics and closely match `vcenter.vm.network.packet.rate` in every other way. **Link to tracking Issue:** <Issue number if applicable> #32929 **Testing:** <Describe what testing was performed and which tests were added.> Unit/integration tests updated and tested. Local environment tested. **Documentation:** <Describe the documentation added.> New documentation generated based on the metadata. * fix(deps): update module github.com/open-telemetry/otel-arrow to v0.22.0 (#32105) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/open-telemetry/otel-arrow](https://togithub.com/open-telemetry/otel-arrow) | `v0.18.0` -> `v0.22.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fopen-telemetry%2fotel-arrow/v0.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fopen-telemetry%2fotel-arrow/v0.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fopen-telemetry%2fotel-arrow/v0.18.0/v0.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fopen-telemetry%2fotel-arrow/v0.18.0/v0.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>open-telemetry/otel-arrow (github.com/open-telemetry/otel-arrow)</summary> ### [`v0.22.0`](https://togithub.com/open-telemetry/otel-arrow/releases/tag/v0.22.0) [Compare Source](https://togithub.com/open-telemetry/otel-arrow/compare/v0.21.0...v0.22.0) Includes [#178](https://togithub.com/open-telemetry/otel-arrow/issues/178). [CHANGELOG](https://togithub.com/open-telemetry/otel-arrow/blob/main/CHANGELOG.md) ### [`v0.21.0`](https://togithub.com/open-telemetry/otel-arrow/releases/tag/v0.21.0) [Compare Source](https://togithub.com/open-telemetry/otel-arrow/compare/v0.20.0...v0.21.0) See the [CHANGELOG](https://togithub.com/open-telemetry/otel-arrow/blob/main/CHANGELOG.md). ### [`v0.20.0`](https://togithub.com/open-telemetry/otel-arrow/releases/tag/v0.20.0) [Compare Source](https://togithub.com/open-telemetry/otel-arrow/compare/v0.19.0...v0.20.0) ##### What's Changed - Backport lint fixes from OTel-Collector-Contrib PR 31996 by [@jmacd](https://togithub.com/jmacd) in [https://github.com/open-telemetry/otel-arrow/pull/163](https://togithub.com/open-telemetry/otel-arrow/pull/163) - Upgrade collector to v0.97.0 by [@moh-osman3](https://togithub.com/moh-osman3) in [https://github.com/open-telemetry/otel-arrow/pull/164](https://togithub.com/open-telemetry/otel-arrow/pull/164) **Full Changelog**: https://github.com/open-telemetry/otel-arrow/compare/v0.19.0...v0.20.0 ### [`v0.19.0`](https://togithub.com/open-telemetry/otel-arrow/releases/tag/v0.19.0) [Compare Source](https://togithub.com/open-telemetry/otel-arrow/compare/v0.18.0...v0.19.0) See [CHANGELOG.md](https://togithub.com/open-telemetry/otel-arrow/blob/main/CHANGELOG.md#0190---2024-03-26) for release notes. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> * [remotetapprocessor] use 'time/rate' to limit traffic (#32481) bug: The remotetapprocessor `limit` configure doesn't work. how to fix: use `time/rate` to limit traffic. Resolves https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/32385 --------- Co-authored-by: Andrzej Stencel <astencel@sumologic.com> * [receiver/vcenter] Switches Over Metadata Configs Waiting for v0.100.0 Release (#32913) **Description:** <Describe what has changed.> A number of configurations were disabled by default and had warnings that they were going to be enabled in v0.101.0 (1 metric had a warning that it was going to be removed). Now that v0.100.0 has been release, I have removed all of these warnings, and made the modifications that the warnings "warned" about. I have also updated the tests to reflect this. **Link to tracking Issue:** <Issue number if applicable> #32803 #32805 #32821 #32531 #32557 **Testing:** <Describe what testing was performed and which tests were added.> Unit/integration tests updated and tested. Local environment tested. **Documentation:** <Describe the documentation added.> New documentation generated based on the metadata. * [chore][fileconsumer] Skip flaky TestFlushPeriodEOF on windows (#32946) See https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/32715 This also adds a bit more debugging info for other tests which fail on the same expectation, since it's not very obvious what was expected vs actually found. * [chore][CI/CD][arm] Trigger arm runs on label (#32955) **Description:** <Describe what has changed.>  I found in https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/32948 that the label `Run ARM` has been added, but the `build-and-test-arm / arm-unittest-matrix (pull_request) ` workflow is still skipped. This is because the `label` action does not trigger a retry. From [documentation](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request): ``` if no activity types are specified, the workflow runs when a pull request is opened or reopened or when the head branch of the pull request is updated. ``` We need to specify that labelling issues should trigger the workflow to check to see if it needs to run again. I've copied the added section from the Windows workflow. I also added that we should only run on PRs against `main`. **Testing:** This PR shows it's working as it should now. Arm test was [originally skipped](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/9009218559/job/24753003216?pr=32955), but after adding the label, tests [have started](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/9009223570/job/24753017935?pr=32955) * [chore][receiver/splunkenterprise] Add header to README (#32956) **Description:** <Describe what has changed.>  The readme for the Splunk Enterprise receiver does not currently have the autogenerated header. This was missing because `mdatagen` requires `` and `` to know where to insert the generated data. * [exporter/elasticsearch] Replace go-elasticsearch BulkIndexer with go-docappender (#32359) **Description:** <Describe what has changed.>  Replace go-elasticsearch BulkIndexer with go-docappender BulkIndexer for Flush function in preparation for reliability fixes. Maintain similar interface and implementation to go-elasticsearch BulkIndexer. Further changes to expose individual `docappender.BulkIndexer` instances are needed down the road but it is out of the scope of this PR. Implications of this change: - flush timeout is now enforced on client side - oversize payload special handling is now removed - go-docappender uses bulk request filterPath which means bulk response is smaller, less JSON parsing and lower CPU usage - document level retry debug logging is removed as retries are done transparently ~~Blocked by #32585~~ **Link to tracking Issue:** <Issue number if applicable> Fixes #32378 **Testing:** Integration test is passing --------- Co-authored-by: Vishal Raj <vishal.raj@elastic.co> * fix(test): Skip flaky test around forcing collector re-registration until the root cause is confirmed (#32937) **Description:** Remove flaky test around forcing collector re-registration until the root cause is confirmed **Link to tracking Issue:** https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/32785 **Testing:** Unit tests * [chore][receiver/splunkenterprise] Splunkent wire component (#32795) **Description:** Graduate splunkenterprise receiver component to alpha **Link to tracking Issue:** **Testing:** Performed `make otelcontribcol` and ran resulting binary with the following config: ```yaml extensions: basicauth/indexer: client_auth: username: admin password: securityFirst basicauth/cluster_master: client_auth: username: admin password: securityFirst receivers: splunkenterprise: indexer: auth: authenticator: basicauth/indexer endpoint: "https://localhost:8089/" timeout: 45s cluster_master: auth: authenticator: basicauth/cluster_master endpoint: "https://localhost:8089/" timeout: 45s exporters: otlp: endpoint: 127.0.0.1:8000 service: extensions: [basicauth/indexer, basicauth/cluster_master] pipelines: metrics: receivers: [splunkenterprise] exporters: [otlp] ``` and received the following output: ``` sh ~> ./otelcontribcol_linux_amd64 --config=file:config.yaml 2024-05-08T17:34:33.032-0500 info service@v0.100.0/service.go:102 Setting up own telemetry... 2024-05-08T17:34:33.032-0500 info service@v0.100.0/telemetry.go:103 Serving metrics {"address": ":8888", "level": "Normal"} 2024-05-08T17:34:33.032-0500 info receiver@v0.100.0/receiver.go:310 Development component. May change in the future. {"kind": "receiver", "name": "splunkenterprise", "data_type": "metrics"} 2024-05-08T17:34:33.033-0500 info service@v0.100.0/service.go:169 Starting otelcontribcol... {"Version": "0.100.0-dev", "NumCPU": 16} 2024-05-08T17:34:33.033-0500 info extensions/extensions.go:34 Starting extensions... 2024-05-08T17:34:33.033-0500 info extensions/extensions.go:37 Extension is starting... {"kind": "extension", "name": "basicauth/cluster_master"} 2024-05-08T17:34:33.033-0500 info extensions/extensions.go:52 Extension started. {"kind": "extension", "name": "basicauth/cluster_master"} 2024-05-08T17:34:33.033-0500 info extensions/extensions.go:37 Extension is starting... {"kind": "extension", "name": "basicauth/indexer"} 2024-05-08T17:34:33.033-0500 info extensions/extensions.go:52 Extension started. {"kind": "extension", "name": "basicauth/indexer"} 2024-05-08T17:34:33.033-0500 info service@v0.100.0/service.go:195 Everything is ready. Begin running and processing data. ``` indicating that the collector was able to successfully start with the component configured. **Documentation:** Documentation was updated to indicate change in status from development to alpha --------- Co-authored-by: Curtis Robert <crobert@splunk.com> * [pkg/ottl] Added support for timezone in Time converter (#32479) **Description:** Added support for default timezone in Time converter. Timezone is optional and can be specified as so: `Time("2023-05-26 12:34:56", "%Y-%m-%d %H:%M:%S", "America/New_York")` **Link to tracking Issue:** #32140 **Testing:** Unit tests added **Documentation:** Documentation in ottl/Readme updated --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com> * [processor/transform] Add common where clause (#31491) **Description:** Add global conditions with where clause  **Link to tracking Issue:** Fixes #27830 **Testing:** Unit tests **Documentation:** TODO ~~The main objective is to extend the `ContextStatements` struct by adding a new `Conditions` parameter. By introducing `Conditions` to `ContextStatements`, we can now apply a global condition to all related statements in `WithStatementSequenceGlobalConditions` function.~~ Thanks in advance for your feedback! If this changes will be fine, I will add common where clause into another context `span`, `metrics`. * Instantiate ID in pkg/stanza/adapter tests (#32966) **Description:** <Describe what has changed.> In https://github.com/open-telemetry/opentelemetry-collector/pull/10069, I am making Type an interface. This means the zero value of Type will be nil - which will cause this test to fail. Initializing ID instead of relying on the zero value fixes this --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com> * Add connector usage to the testbed (#32881) **Description:** Added a new component to the testbed called DataConnectors which allows connectors to be added to the testbed config. Also, added a sample connector correctness test using the routingconnector as an example of the usage. **Link to tracking Issue:** #30165 **Testing:** Sample correctness test using routingconnector. **Documentation:** Will update the testbed README with new addition. --------- Co-authored-by: Bryan Aguilar <bryaag@amazon.com> * [chore][CONTRIBUTING.md] Update adding component directions (#32957) **Description:** <Describe what has changed.>  This is two main changes: 1. Remove `goleak` section. It's now added by default by mdatagen, there's nothing required of users here. 2. Add information and reformat the `Last steps` section of adding a new component. - Move the directions to be bullet points - Add `make generate` to make sure the component's README is updated properly - Explicitly point out that stability and distribution needs to be updated in `metadata.yaml` - Add step for adding the component to the releases repo. My understanding is that if a component is `Alpha`, it should be included in the release, so I've made that a noted part of the steps here. (Let me know if we should word this in a more "optional" way.) --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> * [opampextension]: Move custom message interface to separate module (#32951) **Description:** <Describe what has changed.> * Breaks our the custom message interface to a separate module, so other components can use the interface without needing to import the `opampextension` module in its entirety. We could temporarily alias the old methods if we'd like, but I think that the CustomMessage stuff has been so short lived that, in addition to the alpha status of the opampextension component, it feels justified to just skip the deprecation process and move it to a new module. **Link to tracking Issue:** Closes #32950 **Testing:** * Covered by existing unit tests **Documentation:** * Added more documentation on usage in the new module. * Modified opampextension docs to point to the new module. * [chore] Add contrib confmap providers to otelcontribcol (#32916) **Description:** Contrib hosts two confmap providers which aren't in the local binary. We should add them so we can test them with a live system. cc @Aneurysm9 @driverpt @atoulme --------- Co-authored-by: Evan Bradley <evan-bradley@users.noreply.github.com> * chore: remote write exporter retry on 429 (#31924) **Description:** <Describe what has changed.> This PR adds an option to retry the remote write requests when the receiving backend responds with 429 http status code,  **Link to tracking Issue:** #31032 **Testing:** <Describe what testing was performed and which tests were added.> Added tests covering the case. **Documentation:** <Describe the documentation added.> Not sure what's the pattern for documenting feature flags. --------- Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> Co-authored-by: David Ashpole <dashpole@google.com> * [chore] vcenterreceiver Adds Accidentally Removed Unit Test Configs/Results (#32987) **Description:** <Describe what has changed.> In this [PR](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/32913), I accidentally removed all the enabled configs from the 2nd set of unit tests. This was incorrect as there are still 4 of them that are currently disabled by default. This is rectifying that by adding those back in. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> This change is for the unit tests only **Documentation:** <Describe the documentation added.> NA * OpenTelemetry Protocol with Apache Arrow Exporter component (#31996) **Description:** This is the same code as OTel-Arrow at https://github.com/open-telemetry/otel-arrow/releases/tag/v0.23.0 (plus [backported lint and test fixes](https://github.com/open-telemetry/otel-arrow/commit/0910113d46454c80881db840e21f25485dce2499)). Only import statements change here, to match the host repository. **Link to tracking Issue:** #26491 **Testing:** Test coverage is approximately 90%. **Documentation:** I double-checked and the existing README had only a few updates needed. * [exporter/sumologic] change logs behavior (#32939) **Description:** * set OTLP as default format * add support for OTLP format * do not support metadata attributes * do not support source headers **Link to tracking Issue:** #32315 **Testing:** * unit tests **Documentation:** * inline comments * readme --------- Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * Fix diff to upstream * [chore][exporter/rabbitmq] Add missing code owner (#32984) **Description:** <Describe what has changed.>  @atoulme [volunteered to be the sponsor](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/28891#issuecomment-1981402878) of this component, so I believe he should be listed as a code owner. From [CONTRIBUTING.md](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components): ``` A sponsor is an approver who will be in charge of being the official reviewer of the code and become a code owner for the component. ``` **Link to tracking Issue:** <Issue number if applicable> #28891 * [chore][receiver/sqlserver] Document Windows-only metrics (#32944) **Description:** <Describe what has changed.>  The referenced metrics are being gathered from Windows perf counters, thus they're currently only available on Windows. With the introduction of direct connection and other supported OSs, I think it would be good to be clear to users about metric availability. * [receiver/splunkehecreceiver] Align acking behavior with that of Splu… (#32996) **Description:** - Make the channelID header case-insensitive - Make hecreceiver endpoints able to extract channelID from query params **Link to tracking Issue:** https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/32995 * [receiver/vcenter] Collection Time Performance Enhancement (#32991) **Description:** <Describe what has changed.> There were already some improvements made as far as how networks calls were made centered around Virtual Machines. This allowed collection times to decrease from ~90s to ~27s in an environment with 1 Cluster, 2 Hosts, & 280 VMs. Making similar changes for all resource types helped to further decrease collection times. Now collection time has decreased from ~27s to <~3s for the same environment. Here's a general list of the changes made: - Now makes all network calls (per datacenter) first and stores returned data. - Processes this data afterwards to convert to OTEL resources/metrics (refactored to new file). - Moves all metric recording to metrics.go to keep consistent. - Moves all resource builder creation to resources.go to keep consistent. - Updates/fixes tests. **Link to tracking Issue:** <Issue number if applicable> #31837 Although this issue prescribes a solution to the problem (goroutines) which ended up not being necessary **Testing:** <Describe what testing was performed and which tests were added.> Unit Tests & Integration Tests Passing as well as Manual Testing in Local Environments **Documentation:** <Describe the documentation added.> N/A * [exporter/sumologic]: add sticky session (#33011) **Description:** Adds support for sticky session in order to better support AWS LB. This code is moved from Sumo Logic repository **Link to tracking Issue:** #32315 **Testing:** Tested manually **Documentation:** N/A --------- Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * [receiver/sqlserver] Add more metrics (#32932) **Description:** This change adds a query, scraper, and some more metrics for data from the performance counter SQL server table. The query itself is mostly taken from Telegraf's SQL server plugin. This also reuses the existing metric `sqlserver.lock.wait.rate`, so now it will be available both from Windows performance counters, as well as other OSs when directly connecting to the SQL server instance. **Naming and format feedback on new metrics would be greatly appreciated.** **Link to tracking Issue:** #29865 **Testing:** Added tests for the query itself, as well as the new scraper. Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com> * deltatocumulative: exponential histograms (#32030) **Description:** Implements accumulation of exponential histograms by adding bucket-per-bucket. - [x] Align bucket offset to the smaller one - [x] Merge buckets by adding up each buckets count - [x] Widen zero buckets so they are the same - [x] Adjust scale to the lowest one **Link to tracking Issue:** https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/30705 **Testing:** Extensive tests have been added to the `internal/data` package **Documentation:** not needed * [pkg/stanza] Add container operator parser (#32594) **Description:** <Describe what has changed.>  This PR implements the new container logs parser as it was proposed at https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/31959. **Link to tracking Issue:** <Issue number if applicable> https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/31959 **Testing:** <Describe what testing was performed and which tests were added.> Added unit tests. Providing manual testing steps as well: ### How to test this manually 1. Using the following config file: ```yaml receivers: filelog: start_at: end include_file_name: false include_file_path: true include: - /var/log/pods/*/*/*.log operators: - id: container-parser type: container output: m1 - type: move id: m1 from: attributes.k8s.pod.name to: attributes.val - id: some type: add field: attributes.key2.key_in value: val2 exporters: debug: verbosity: detailed service: pipelines: logs: receivers: [filelog] exporters: [debug] processors: [] ``` 2. Start the collector: `./bin/otelcontribcol_linux_amd64 --config ~/otelcol/container_parser/config.yaml` 3. Use the following bash script to create some logs: ```bash #! /bin/bash echo '2024-04-13T07:59:37.505201169-05:00 stdout P This is a very very long crio line th' >> /var/log/pods/kube-scheduler-kind-control-plane_49cc7c1fd3702c40b2686ea7486091d3/kube-scheduler43/1.log echo '{"log":"INFO: log line here","stream":"stdout","time":"2029-03-30T08:31:20.545192187Z"}' >> /var/log/pods/kube-controller-kind-control-plane_49cc7c1fd3702c40b2686ea7486091d6/kube-controller/1.log echo '2024-04-13T07:59:37.505201169-05:00 stdout F at is awesome! crio is awesome!' >> /var/log/pods/kube-scheduler-kind-control-plane_49cc7c1fd3702c40b2686ea7486091d3/kube-scheduler43/1.log echo '2021-06-22T10:27:25.813799277Z stdout P some containerd log th' >> /var/log/pods/kube-scheduler-kind-control-plane_49cc7c1fd3702c40b2686ea7486091d3/kube-scheduler44/1.log echo '{"log":"INFO: another log line here","stream":"stdout","time":"2029-03-30T08:31:20.545192187Z"}' >> /var/log/pods/kube-controller-kind-control-plane_49cc7c1fd3702c40b2686ea7486091d6/kube-controller/1.log echo '2021-06-22T10:27:25.813799277Z stdout F at is super awesome! Containerd is awesome' >> /var/log/pods/kube-scheduler-kind-control-plane_49cc7c1fd3702c40b2686ea7486091d3/kube-scheduler44/1.log echo '2024-04-13T07:59:37.505201169-05:00 stdout F standalone crio line which is awesome!' >> /var/log/pods/kube-scheduler-kind-control-plane_49cc7c1fd3702c40b2686ea7486091d3/kube-scheduler43/1.log echo '2021-06-22T10:27:25.813799277Z stdout F standalone containerd line that is super awesome!' >> /var/log/pods/kube-scheduler-kind-control-plane_49cc7c1fd3702c40b2686ea7486091d3/kube-scheduler44/1.log ``` 4. Run the above as a bash script to verify any parallel processing. Verify that the output is correct. ### Test manually on k8s 1. `make docker-otelcontribcol && docker tag otelcontribcol otelcontribcol-dev:0.0.1 && kind load docker-image otelcontribcol-dev:0.0.1` 2. Install using the following helm values file: ```yaml mode: daemonset presets: logsCollection: enabled: true image: repository: otelcontribcol-dev tag: "0.0.1" pullPolicy: IfNotPresent command: name: otelcontribcol config: exporters: debug: verbosity: detailed receivers: filelog: start_at: end include_file_name: false include_file_path: true exclude: - /var/log/pods/default_daemonset-opentelemetry-collector*_*/opentelemetry-collector/*.log include: - /var/log/pods/*/*/*.log operators: - id: container-parser type: container output: some - id: some type: add field: attributes.key2.key_in value: val2 service: pipelines: logs: receivers: [filelog] processors: [batch] exporters: [debug] ``` 3. Check collector's output to verify the logs are parsed properly: ```console 2024-05-10T07:52:02.307Z info LogsExporter {"kind": "exporter", "data_type": "logs", "name": "debug", "resource logs": 1, "log records": 2} 2024-05-10T07:52:02.307Z info ResourceLog #0 Resource SchemaURL: ScopeLogs #0 ScopeLogs SchemaURL: InstrumentationScope LogRecord #0 ObservedTimestamp: 2024-05-10 07:52:02.046236071 +0000 UTC Timestamp: 2024-05-10 07:52:01.92533954 +0000 UTC SeverityText: SeverityNumber: Unspecified(0) Body: Str(otel logs at 07:52:01) Attributes: -> log: Map({"iostream":"stdout"}) -> time: Str(2024-05-10T07:52:01.92533954Z) -> k8s: Map({"container":{"name":"busybox","restart_count":"0"},"namespace":{"name":"default"},"pod":{"name":"daemonset-logs-6f6mn","uid":"1069e46b-03b2-4532-a71f-aaec06c0197b"}}) -> logtag: Str(F) -> key2: Map({"key_in":"val2"}) -> log.file.path: Str(/var/log/pods/default_daemonset-logs-6f6mn_1069e46b-03b2-4532-a71f-aaec06c0197b/busybox/0.log) Trace ID: Span ID: Flags: 0 LogRecord #1 ObservedTimestamp: 2024-05-10 07:52:02.046411602 +0000 UTC Timestamp: 2024-05-10 07:52:02.027386192 +0000 UTC SeverityText: SeverityNumber: Unspecified(0) Body: Str(otel logs at 07:52:02) Attributes: -> log.file.path: Str(/var/log/pods/default_daemonset-logs-6f6mn_1069e46b-03b2-4532-a71f-aaec06c0197b/busybox/0.log) -> time: Str(2024-05-10T07:52:02.027386192Z) -> log: Map({"iostream":"stdout"}) -> logtag: Str(F) -> k8s: Map({"container":{"name":"busybox","restart_count":"0"},"namespace":{"name":"default"},"pod":{"name":"daemonset-logs-6f6mn","uid":"1069e46b-03b2-4532-a71f-aaec06c0197b"}}) -> key2: Map({"key_in":"val2"}) Trace ID: Span ID: Flags: 0 ... ``` **Documentation:** <Describe the documentation added.> Added Signed-off-by: ChrsMark <chrismarkou92@gmail.com> * fix(deps): update module google.golang.org/genproto/googleapis/api to v0.0.0-20240513163218-0867130af1f8 (#33039) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google.golang.org/genproto/googleapis/api](https://togithub.com/googleapis/go-genproto) | `v0.0.0-20240506185236-b8a5c65736ae` -> `v0.0.0-20240513163218-0867130af1f8` | [![age](https://developer.mend.io/api/mc/badges/age/go/google.golang.org%2fgenproto%2fgoogleapis%2fapi/v0.0.0-20240513163218-0867130af1f8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/google.golang.org%2fgenproto%2fgoogleapis%2fapi/v0.0.0-20240513163218-0867130af1f8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/google.golang.org%2fgenproto%2fgoogleapis%2fapi/v0.0.0-20240506185236-b8a5c65736ae/v0.0.0-20240513163218-0867130af1f8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/google.golang.org%2fgenproto%2fgoogleapis%2fapi/v0.0.0-20240506185236-b8a5c65736ae/v0.0.0-20240513163218-0867130af1f8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> * [chore][receiver/sqlserver] Update documentation for lock wait rate metric (#33023) **Description:** <Describe what has changed.>  As a result of https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/32932 the metric `sqlserver.lock.wait.rate` is now available on Windows, or when directly connecting to a SQL server instance. Since this metric is always available, it no longer needs extended documentation about availability. * [exporter/datadog] Actually gzip host metadata (#32992) **Description:** We were sending a payload and setting the `Content-Encoding: gzip` HTTP header while actually sending uncompressed data. This has been happening for at least a couple years. This fixes the bug by actually gzipping the payload * [chore][pkg/stanza] Add syslog octet counting test cases with whitespace scenarios (#32832) Resolves #31477 --------- Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com> Co-authored-by: Curtis Robert <crobert@splunk.com> * fix(deps): update module github.com/grafana/loki/pkg/push to v0.0.0-20240514073905-7cc9a9386a8f (#33031) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/grafana/loki/pkg/push](https://togithub.com/grafana/loki) | `v0.0.0-20240507085123-772616cd8f5c` -> `v0.0.0-20240514073905-7cc9a9386a8f` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgrafana%2floki%2fpkg%2fpush/v0.0.0-20240514073905-7cc9a9386a8f?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgrafana%2floki%2fpkg%2fpush/v0.0.0-20240514073905-7cc9a9386a8f?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgrafana%2floki%2fpkg%2fpush/v0.0.0-20240507085123-772616cd8f5c/v0.0.0-20240514073905-7cc9a9386a8f?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgrafana%2floki%2fpkg%2fpush/v0.0.0-20240507085123-772616cd8f5c/v0.0.0-20240514073905-7cc9a9386a8f?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> * fix(deps): update module github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common to v1.0.919 (#33036) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common](https://togithub.com/tencentcloud/tencentcloud-sdk-go) | `v1.0.914` -> `v1.0.919` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2ftencentcloud%2ftencentcloud-sdk-go%2ftencentcloud%2fcommon/v1.0.919?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2ftencentcloud%2ftencentcloud-sdk-go%2ftencentcloud%2fcommon/v1.0.919?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2ftencentcloud%2ftencentcloud-sdk-go%2ftencentcloud%2fcommon/v1.0.914/v1.0.919?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2ftencentcloud%2ftencentcloud-sdk-go%2ftencentcloud%2fcommon/v1.0.914/v1.0.919?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>tencentcloud/tencentcloud-sdk-go (github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common)</summary> ### [`v1.0.919`](https://togithub.com/tencentcloud/tencentcloud-sdk-go/blob/HEAD/CHANGELOG.md#Release-v10919) [Compare Source](https://togithub.com/tencentcloud/tencentcloud-sdk-go/compare/v1.0.918...v1.0.919) #### 负载均衡(clb) 版本：2018-03-17 ##### 第 105 次发布发布时间：2024-05-14 01:28:52 本次发布包含了以下内容：改善已有的文档。修改数据结构： - [TargetGroupAssociation](https://cloud.tencent.com/document/api/214/30694#TargetGroupAssociation) - 新增成员：Weight #### TDSQL-C MySQL 版(cynosdb) 版本：2019-01-07 ##### 第 89 次发布发布时间：2024-05-14 01:39:01 本次发布包含了以下内容：改善已有的文档。修改接口： - [CreateCLSDelivery](https://cloud.tencent.com/document/api/1003/106079) - 新增入参：InstanceId, CLSInfoList - 新增出参：TaskId - [DeleteCLSDelivery](https://cloud.tencent.com/document/api/1003/106078) - 新增入参：InstanceId, CLSTopicIds - 新增出参：TaskId - [DescribeInstanceCLSLogDelivery](https://cloud.tencent.com/document/api/1003/106077) - 新增入参：InstanceId - 新增出参：TotalCount, InstanceCLSDeliveryInfos - [StartCLSDelivery](https://cloud.tencent.com/document/api/1003/106076) - 新增入参：InstanceId, CLSTopicIds - 新增出参：TaskId - [StopCLSDelivery](https://cloud.tencent.com/document/api/1003/106075) - 新增入参：InstanceId, CLSTopicIds - 新增出参：TaskId 新增数据结构： - [CLSInfo](https://cloud.tencent.com/document/api/1003/48097#CLSInfo) - [InstanceCLSDeliveryInfo](https://cloud.tencent.com/document/api/1003/48097#InstanceCLSDeliveryInfo) #### 数据安全治理中心(dsgc) 版本：2019-07-23 ##### 第 11 次发布发布时间：2024-05-14 01:46:03 本次发布包含了以下内容：改善已有的文档。修改数据结构： - [AKSKLeak](https://cloud.tencent.com/document/api/1087/96844#AKSKLeak) - **修改成员**：AK, SK, URL - [AssetCosDetail](https://cloud.tencent.com/document/api/1087/96844#AssetCosDetail) - **修改成员**：Bucket, DataType, FileNums, SensitiveFileNums, DistributionData, MatchedNum - [DSPACosMetaDataInfo](https://cloud.tencent.com/document/api/1087/96844#DSPACosMetaDataInfo) - **修改成员**：BindStatus, Storage - [DbRelationStatusItem](https://cloud.tencent.com/document/api/1087/96844#DbRelationStatusItem) - **修改成员**：DbName, BindStatus, ValidStatus - [DbTaskResult](https://cloud.tencent.com/document/api/1087/96844#DbTaskResult) - **修改成员**：Result, ResultDescription, ErrDescription, ResourceId, DbName - [ErrDescription](https://cloud.tencent.com/document/api/1087/96844#ErrDescription) - **修改成员**：ErrCode, ErrMessage - [SuggestRiskLevelMatrixItem](https://cloud.tencent.com/document/api/1087/96844#SuggestRiskLevelMatrixItem) - **修改成员**：SensitiveLevel, VulnerabilityLevel, RiskName, RiskScore #### 弹性 MapReduce(emr) 版本：2019-01-03 ##### 第 63 次发布发布时间：2024-05-14 01:50:50 本次发布包含了以下内容：改善已有的文档。修改数据结构： - [ImpalaQuery](https://cloud.tencent.com/document/api/589/33981#ImpalaQuery) - 新增成员：BackendsCount, FragmentInstancesCount, RemainingFragmentCount #### Elasticsearch Service(es) 版本：2018-04-16 ##### 第 58 次发布发布时间：2024-05-14 01:51:30 本次发布包含了以下内容：改善已有的文档。修改数据结构： - [ServerlessSpace](https://cloud.tencent.com/document/api/845/30634#ServerlessSpace) - 新增成员：KibanaLanguage #### 文字识别(ocr) 版本：2018-11-19 ##### 第 135 次发布发布时间：2024-05-14 02:17:52 本次发布包含了以下内容：改善已有的文档。修改接口： - [HKIDCardOCR](https://cloud.tencent.com/document/api/866/46919) - **修改入参**：DetectFake - 新增出参：WarnCardInfos - [MLIDCardOCR](https://cloud.tencent.com/document/api/866/37656) - 新增出参：WarnCardInfos - [RecognizeIndonesiaIDCardOCR](https://cloud.tencent.com/document/api/866/75195) - 新增出参：WarnCardInfos - [RecognizeThaiIDCardOCR](https://cloud.tencent.com/document/api/866/48475) - 新增出参：WarnCardInfos #### TI-ONE 训练平台(tione) 版本：2021-11-11 ##### 第 59 次发布发布时间：2024-05-14 02:40:26 本次发布包含了以下内容：改善已有的文档。新增数据结构： - [CBSConfig](https://cloud.tencent.com/document/api/851/75051#CBSConfig) 修改数据结构： - [DataConfig](https://cloud.tencent.com/document/api/851/75051#DataConfig) - 新增成员：CBSSource #### TI-ONE 训练平台(tione) 版本：2019-10-22 ##### 第 13 次发布发布时间：2024-05-14 02:40:07 本次发布包含了以下内容：改善已有的文档。 **删除接口**： - UpdateNotebookLifecycleScript #### 实时音视频(trtc) 版本：2019-07-22 ##### 第 73 次发布发布时间：2024-05-14 02:45:49 本次发布包含了以下内容：改善已有的文档。修改数据结构： - [McuWaterMarkText](https://cloud.tencent.com/document/api/647/44055#McuWaterMarkText) - 新增成员：Font #### 微服务引擎(tse) 版本：2020-12-07 ##### 第 66 次发布发布时间：2024-05-14 02:46:25 本次发布包含了以下内容：改善已有的文档。修改数据结构： - [CloudNativeAPIGatewayNode](https://cloud.tencent.com/document/api/1364/54942#CloudNativeAPIGatewayNode) - 新增成员：Weight, IsDefaultWeight - **修改成员**：ZoneId, Zone, GroupId, GroupName, Status - [NativeGatewayServerGroup](https://cloud.tencent.com/document/api/1364/54942#NativeGatewayServerGroup) - 新增成员：DefaultWeight ### [`v1.0.918`](https://togithub.com/tencentcloud/tencentcloud-sdk-go/blob/HEAD/CHANGELOG.md#Release-v10918) [Compare Source](https://togithub.com/tencentcloud/tencentcloud-sdk-go/compare/v1.0.917...v1.0.918) #### TDSQL-C MySQL 版(cynosdb) 版本：2019-01-07 ##### 第 88 次发布发布时间：2024-05-13 01:14:47 本次发布包含了以下内容：改善已有的文档。新增接口： - [CreateCLSDelivery](https://cloud.tencent.com/document/api/1003/106079) - [DeleteCLSDelivery](https://cloud.tencent.com/document/api/1003/106078) - [DescribeInstanceCLSLogDelivery](https://cloud.tencent.com/document/api/1003/106077) - [StartCLSDelivery](https://cloud.tencent.com/document/api/1003/106076) - [StopCLSDelivery](https://cloud.tencent.com/document/api/1003/106075) #### 腾讯电子签企业版(ess) 版本：2020-11-11 ##### 第 169 次发布发布时间：2024-05-13 01:18:00 本次发布包含了以下内容：改善已有的文档。新增接口： - [DescribeUserVerifyStatus](https://cloud.tencent.com/document/api/1323/106080) #### 轻量应用服务器(lighthouse) 版本：2020-03-24 ##### 第 60 次发布发布时间：2024-05-13 01:21:46 本次发布包含了以下内容：改善已有的文档。修改数据结构： - [Instance](https://cloud.tencent.com/document/api/1207/47576#Instance) - 新增成员：LatestOperationStartedTime - [InstancePriceDetail](https://cloud…

**Description:** <Describe what has changed.>  Enable `goleak` checks on the `cadvisor` package of the AWS Container Insights receiver to help ensure no goroutines are being leaked. **Link to tracking Issue:** <Issue number if applicable> #30438 **Testing:** <Describe what testing was performed and which tests were added.> This package is a linux-only package, so I wasn't able to test locally, but CI/CD tests are passing. Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>

**Description:** This change is a refactor to allow us to enable `goleak` checks in each of the exporter's sub-directories, as well as the signalfx receiver (which uses the signalfxexporter in a test). The main idea is to use `start`/`shutdown` for each package's functionality, rather than relying on the top level context cancel of the exporter. The addition of start and shutdowns for each package means we can more closely control the lifecycle of each as needed, and enable `goleak` for each package. The memory leaks being fixed are: 1. Call the `TTLMap.Shutdown` so the ticker is properly stopped: `t.prevPts.Shutdown()`. 2. Don't block waiting for a request if the context is cancelled. **Link to tracking issue:** #30438 --------- Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>

* [chore]: enable bool-compare rule from testifylint (#34912) #### Description Testifylint is a linter that provides best practices with the use of testify. This PR enables [bool-compare](https://github.com/Antonboom/testifylint?tab=readme-ov-file#bool-compare) rule from [testifylint](https://github.com/Antonboom/testifylint) It's linter provided by golangci-lint. Here all available rules are activated except those who require to be fixed. This PR only fixes bool-compare so the quantity of changes stays reasonnable for reviewers. Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * [pkg/ottl] Remove tracing from OTTL (#34910) **Description:** Reverts https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/33508 since it was causing performance issues **Link to tracking Issue:** <Issue number if applicable> Reopens https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/33433 Related to https://github.com/open-telemetry/opentelemetry-collector/issues/10858 Closes https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34890 * [chore]: enable len rule from testifylint (#34921) #### Description Testifylint is a linter that provides best practices with the use of testify. This PR enables [len](https://github.com/Antonboom/testifylint?tab=readme-ov-file#len) rule from [testifylint](https://github.com/Antonboom/testifylint) * [chore][receiver/nginx] Update README for consistency (#34923) **Description:** <Describe what has changed.>  This just cleans up the README a bit: 1. Make case of `NGINX` consistent. Happy to change it to `nginx` if that's preferred. 2. Remove empty `Details` section 3. Cleanup description of the `collection_interval` config option. This is the same config option many other receivers have, so I don't think the concept needs explained in-depth here. 4. Remove disclaimer that the component's status is beta and configuration is subject to change. The README's header states this component is beta, so I don't think it needs to be repeated. * [processor/redaction] add support for redacting metrics and logs attributes (#34609) **Description:** This PR extends the redaction processor to also support the redaction of attributes within logs and metrics. **Link to tracking Issue:** #34479 **Testing:** Extended the existing unit tests to also cover the redaction of logs and metrics **Documentation:** Adapted the readme to reflect the changes --------- Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com> * [chore] Fix linter issues (#34937) **Description:** <Describe what has changed.>  #34609 and #34921 conflicted. This fixes CI * [receiver/gitproviderreceiver] rename to githubreceiver (#34731) **Description:** <Describe what has changed.> Renames `gitproviderreceiver` to `githubreceiver` to better align with OpenTelemetry Semantic Conventions v1.27.0+ and allow for tracing and log signals in the future. --------- Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> * [chore][CODEOWNERS] Change account references to match new username (#34929) [Failing CI/CD action](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10616610306/job/29427492169#step:16:13) Failure output: ``` cd cmd/githubgen && go install . githubgen 2024/08/2[9](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10616610306/job/29427492169#step:16:10) 14:07:14 codeowners are not members: kkujawa-sumo make: *** [Makefile:296: gengithub] Error 1 ``` It appears that the user @kkujawa-sumo has been renamed to @kasia-kujawa. This updates all references to resolve our code owners check to ensure all code owners are members of the OpenTelemetry organization. * [chore] refactor filter processor test to use generated test harness (#34940) The code in telemetry_test.go was mostly doing something the code generated by mdatagen was doing. Updated the tests to use that instead. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> * [chore] use generated test harness for groupbyattrs processor (#34941) Like https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/34940 but for the groupsbyattrs processor. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> * [chore] update core to pull in telemetry settings changes (#34930) Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> * [receiver/splunkhec] fix memory leak (#34911) **Description:** Fix memory leak when the receiver is used for both metrics and logs at the same time **Link to tracking Issue:** <Issue number if applicable> Fixes #34886 * [chore] Updating @MovieStoreGuy affiliation (#34947) * [chore]: Update README.md (#34725) Alolita Sharma works at Apple now. :) **Description:** <Describe what has changed.>  **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> * [connector/servicegraph]Fix incorrectly reversed latency settings(resolve #34562 unit fail) (#34933) **Description:** <Describe what has changed.> This PR resolves the #34562 unit failure and adds back this bugfix after revert #34865. * [chore]: enable error-nil and nil-compare rules from testifylint (#34936) #### Description Testifylint is a linter that provides best practices with the use of testify. This PR enables [error-nil](https://github.com/Antonboom/testifylint?tab=readme-ov-file#error-nil) and [nil-compare](https://github.com/Antonboom/testifylint?tab=readme-ov-file#nil-compare) rules from [testifylint](https://github.com/Antonboom/testifylint) It also adds testifylint as tool to use with a make command * [connector/count] fix typo in metric.datapoint.count (#34961) **Documentation:** The documentation mentions a metric called "metric.data_point.count" but the metric is actually called "metric.datapoint.count" Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com> * [chore] Upgrade arvo package (#34962) **Description:** Upgrading the arvo package used, it appears to be causing build issues on integer overflows * Update module github.com/shirou/gopsutil/v4 to v4.24.8 (#34970) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/shirou/gopsutil/v4](https://redirect.github.com/shirou/gopsutil) | `v4.24.7` -> `v4.24.8` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fshirou%2fgopsutil%2fv4/v4.24.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fshirou%2fgopsutil%2fv4/v4.24.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fshirou%2fgopsutil%2fv4/v4.24.7/v4.24.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fshirou%2fgopsutil%2fv4/v4.24.7/v4.24.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>shirou/gopsutil (github.com/shirou/gopsutil/v4)</summary> ### [`v4.24.8`](https://redirect.github.com/shirou/gopsutil/releases/tag/v4.24.8) [Compare Source](https://redirect.github.com/shirou/gopsutil/compare/v4.24.7...v4.24.8)  #### What's Changed ##### disk - fix(IOCountersWithContext): Fix the issue of not using names to fil ter devices in func IOCountersWithContext of the windows implementation by [@zmyzheng](https://redirect.github.com/zmyzheng) in [https://github.com/shirou/gopsutil/pull/1688](https://redirect.github.com/shirou/gopsutil/pull/1688) - \[disk]\[windows]: ignore network drive when not ready by [@shirou](https://redirect.github.com/shirou) in [https://github.com/shirou/gopsutil/pull/1699](https://redirect.github.com/shirou/gopsutil/pull/1699) ##### process - Fix parsing of /proc/pid/smaps when path is empty by [@pgimalac](https://redirect.github.com/pgimalac) in [https://github.com/shirou/gopsutil/pull/1691](https://redirect.github.com/shirou/gopsutil/pull/1691) - Refactoring the algorithm for calculating CPU usage by [@TheBestLL](https://redirect.github.com/TheBestLL) in [https://github.com/shirou/gopsutil/pull/1692](https://redirect.github.com/shirou/gopsutil/pull/1692) - Fix panic on OpenBSD and FreeBSD systems if KinfoProc size has an unexpected size by [@fivitti](https://redirect.github.com/fivitti) in [https://github.com/shirou/gopsutil/pull/1694](https://redirect.github.com/shirou/gopsutil/pull/1694) ##### Other Changes - Fix badge link in README.md by [@Yurunsoft](https://redirect.github.com/Yurunsoft) in [https://github.com/shirou/gopsutil/pull/1695](https://redirect.github.com/shirou/gopsutil/pull/1695) - fix golangcilint errors, ignore gosec G115 by [@shirou](https://redirect.github.com/shirou) in [https://github.com/shirou/gopsutil/pull/1697](https://redirect.github.com/shirou/gopsutil/pull/1697) - fix: golangci lint with max -> maxConn by [@shirou](https://redirect.github.com/shirou) in [https://github.com/shirou/gopsutil/pull/1693](https://redirect.github.com/shirou/gopsutil/pull/1693) #### New Contributors 🎉 - [@zmyzheng](https://redirect.github.com/zmyzheng) made their first contribution in [https://github.com/shirou/gopsutil/pull/1688](https://redirect.github.com/shirou/gopsutil/pull/1688) - [@Yurunsoft](https://redirect.github.com/Yurunsoft) made their first contribution in [https://github.com/shirou/gopsutil/pull/1695](https://redirect.github.com/shirou/gopsutil/pull/1695) - [@pgimalac](https://redirect.github.com/pgimalac) made their first contribution in [https://github.com/shirou/gopsutil/pull/1691](https://redirect.github.com/shirou/gopsutil/pull/1691) - [@TheBestLL](https://redirect.github.com/TheBestLL) made their first contribution in [https://github.com/shirou/gopsutil/pull/1692](https://redirect.github.com/shirou/gopsutil/pull/1692) - [@fivitti](https://redirect.github.com/fivitti) made their first contribution in [https://github.com/shirou/gopsutil/pull/1694](https://redirect.github.com/shirou/gopsutil/pull/1694) **Full Changelog**: https://github.com/shirou/gopsutil/compare/v4.24.7...v4.24.8 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> * Update module github.com/ClickHouse/clickhouse-go/v2 to v2.28.2 (#34968) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/ClickHouse/clickhouse-go/v2](https://redirect.github.com/ClickHouse/clickhouse-go) | `v2.28.1` -> `v2.28.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.28.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.28.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.28.1/v2.28.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fClickHouse%2fclickhouse-go%2fv2/v2.28.1/v2.28.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ClickHouse/clickhouse-go (github.com/ClickHouse/clickhouse-go/v2)</summary> ### [`v2.28.2`](https://redirect.github.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2282-2024-08-30----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://redirect.github.com/ClickHouse/clickhouse-go/compare/v2.28.1...v2.28.2) #### What's Changed ##### Fixes 🐛 - Validate connection in bad state before query execution in the stdlib database/sql driver by [@jkaflik](https://redirect.github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1396](https://redirect.github.com/ClickHouse/clickhouse-go/pull/1396) ##### Other Changes 🛠 - Update README with newer Go versions by [@jkaflik](https://redirect.github.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1393](https://redirect.github.com/ClickHouse/clickhouse-go/pull/1393) **Full Changelog**: https://github.com/ClickHouse/clickhouse-go/compare/v2.28.1...v2.28.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> * Update All github.com/datadog packages to v0.56.2 (#34965) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/DataDog/datadog-agent/comp/core/config](https://redirect.github.com/DataDog/datadog-agent) | `v0.56.0` -> `v0.56.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fcore%2fconfig/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fcore%2fconfig/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fcore%2fconfig/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fcore%2fconfig/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/core/hostname/hostnameinterface](https://redirect.github.com/DataDog/datadog-agent) | `v0.56.0` -> `v0.56.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fcore%2fhostname%2fhostnameinterface/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fcore%2fhostname%2fhostnameinterface/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fcore%2fhostname%2fhostnameinterface/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fcore%2fhostname%2fhostnameinterface/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/core/log](https://redirect.github.com/DataDog/datadog-agent) | `v0.56.0` -> `v0.56.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fcore%2flog/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fcore%2flog/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fcore%2flog/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fcore%2flog/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/logs/agent/config](https://redirect.github.com/DataDog/datadog-agent) | `v0.56.0` -> `v0.56.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2flogs%2fagent%2fconfig/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2flogs%2fagent%2fconfig/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2flogs%2fagent%2fconfig/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2flogs%2fagent%2fconfig/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline](https://redirect.github.com/DataDog/datadog-agent) | `v0.56.0` -> `v0.56.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2flogsagentpipeline/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2flogsagentpipeline/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2flogsagentpipeline/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2flogsagentpipeline/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline/logsagentpipelineimpl](https://redirect.github.com/DataDog/datadog-agent) | `v0.56.0` -> `v0.56.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2flogsagentpipeline%2flogsagentpipelineimpl/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2flogsagentpipeline%2flogsagentpipelineimpl/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2flogsagentpipeline%2flogsagentpipelineimpl/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2flogsagentpipeline%2flogsagentpipelineimpl/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/logsagentexporter](https://redirect.github.com/DataDog/datadog-agent) | `v0.56.0` -> `v0.56.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2fotlp%2fcomponents%2fexporter%2flogsagentexporter/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2fotlp%2fcomponents%2fexporter%2flogsagentexporter/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2fotlp%2fcomponents%2fexporter%2flogsagentexporter/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2fotlp%2fcomponents%2fexporter%2flogsagentexporter/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/metricsclient](https://redirect.github.com/DataDog/datadog-agent) | `v0.56.0` -> `v0.56.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2fotlp%2fcomponents%2fmetricsclient/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2fotlp%2fcomponents%2fmetricsclient/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2fotlp%2fcomponents%2fmetricsclient/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2fotlp%2fcomponents%2fmetricsclient/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/statsprocessor](https://redirect.github.com/DataDog/datadog-agent) | `v0.56.0` -> `v0.56.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2fotlp%2fcomponents%2fstatsprocessor/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2fotlp%2fcomponents%2fstatsprocessor/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2fotlp%2fcomponents%2fstatsprocessor/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2fotelcol%2fotlp%2fcomponents%2fstatsprocessor/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/comp/trace/compression/impl-gzip](https://redirect.github.com/DataDog/datadog-agent) | `v0.56.0` -> `v0.56.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2ftrace%2fcompression%2fimpl-gzip/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2ftrace%2fcompression%2fimpl-gzip/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2ftrace%2fcompression%2fimpl-gzip/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fdatadog-agent%2fcomp%2ftrace%2fcompression%2fimpl-gzip/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/pkg/config/model](https://redirect.github.com/DataDog/datadog-agent) | `v0.56.0` -> `v0.56.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2fconfig%2fmodel/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2fconfig%2fmodel/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2fconfig%2fmodel/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2fconfig%2fmodel/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/pkg/config/setup](https://redirect.github.com/DataDog/datadog-agent) | `v0.56.0` -> `v0.56.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2fconfig%2fsetup/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2fconfig%2fsetup/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2fconfig%2fsetup/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2fconfig%2fsetup/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/pkg/logs/sources](https://redirect.github.com/DataDog/datadog-agent) | `v0.56.0` -> `v0.56.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2flogs%2fsources/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2flogs%2fsources/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2flogs%2fsources/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2flogs%2fsources/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/pkg/obfuscate](https://redirect.github.com/DataDog/datadog-agent) | `v0.56.0` -> `v0.56.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2fobfuscate/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2fobfuscate/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2fobfuscate/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2fobfuscate/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/pkg/proto](https://redirect.github.com/DataDog/datadog-agent) | `v0.56.0` -> `v0.56.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2fproto/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2fproto/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2fproto/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2fproto/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/pkg/trace](https://redirect.github.com/DataDog/datadog-agent) | `v0.56.0` -> `v0.56.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2ftrace/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2ftrace/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2ftrace/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2ftrace/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/datadog-agent/pkg/util/hostname/validate](https://redirect.github.com/DataDog/datadog-agent) | `v0.56.0` -> `v0.56.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2futil%2fhostname%2fvalidate/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2futil%2fhostname%2fvalidate/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2futil%2fhostname%2fvalidate/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fdatadog-agent%2fpkg%2futil%2fhostname%2fvalidate/v0.56.0/v0.56.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> * Update module github.com/snowflakedb/gosnowflake to v1.11.1 (#34971) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/snowflakedb/gosnowflake](https://redirect.github.com/snowflakedb/gosnowflake) | `v1.11.0` -> `v1.11.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fsnowflakedb%2fgosnowflake/v1.11.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fsnowflakedb%2fgosnowflake/v1.11.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fsnowflakedb%2fgosnowflake/v1.11.0/v1.11.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fsnowflakedb%2fgosnowflake/v1.11.0/v1.11.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>snowflakedb/gosnowflake (github.com/snowflakedb/gosnowflake)</summary> ### [`v1.11.1`](https://redirect.github.com/snowflakedb/gosnowflake/releases/tag/v1.11.1): Release [Compare Source](https://redirect.github.com/snowflakedb/gosnowflake/compare/v1.11.0...v1.11.1) - Please check Snowflake [community page for release notes](https://docs.snowflake.com/en/release-notes/clients-drivers/golang). </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> * [exporter/loki] Document the migration from the Loki Exporter to the Loki V3 OTLP endpoint (#34918) **Description:** <Describe what has changed.> Document how to migrate from the now deprecated OTel Collector Loki Exporter to the new Loki V3 OTLP endpoint and new OTel log format --------- Co-authored-by: Curtis Robert <crobert@splunk.com> Co-authored-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com> * [connector/spanmetrics] Improve consistency between metrics generated by spanmetricsconnector (#34485) **Link to tracking Issue:** #33227 #32818 **Documentation:** added an entry to the changelog explaining the deprecated metrics. --------- Signed-off-by: Israel Blancas <iblancasa@gmail.com> Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: Murphy Chen <minquan.chen@daocloud.io> Co-authored-by: Rafael Pax <rpax@users.noreply.github.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Update module google.golang.org/grpc to v1.66.0 (#34978) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google.golang.org/grpc](https://redirect.github.com/grpc/grpc-go) | `v1.65.0` -> `v1.66.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/google.golang.org%2fgrpc/v1.66.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/google.golang.org%2fgrpc/v1.66.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/google.golang.org%2fgrpc/v1.65.0/v1.66.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/google.golang.org%2fgrpc/v1.65.0/v1.66.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>grpc/grpc-go (google.golang.org/grpc)</summary> ### [`v1.66.0`](https://redirect.github.com/grpc/grpc-go/releases/tag/v1.66.0): Release 1.66.0 [Compare Source](https://redirect.github.com/grpc/grpc-go/compare/v1.65.0...v1.66.0) ### New Features - metadata: stabilize `ValueFromIncomingContext` ([#7368](https://redirect.github.com/grpc/grpc-go/issues/7368)) - Special Thanks: [@KarthikReddyPuli](https://redirect.github.com/KarthikReddyPuli) - client: stabilize the `WaitForStateChange` and `GetState` methods, which were previously experimental. ([#7425](https://redirect.github.com/grpc/grpc-go/issues/7425)) - xds: Implement ADS flow control mechanism ([#7458](https://redirect.github.com/grpc/grpc-go/issues/7458)) - See [https://github.com/grpc/grpc/issues/34099](https://redirect.github.com/grpc/grpc/issues/34099) for context. - balancer/rls: Add metrics for data cache and picker internals ([#7484](https://redirect.github.com/grpc/grpc-go/issues/7484), [#7495](https://redirect.github.com/grpc/grpc-go/issues/7495)) - xds: LRS load reports now include the `total_issued_requests` field. ([#7544](https://redirect.github.com/grpc/grpc-go/issues/7544)) ### Bug Fixes - grpc: Clients now return status code INTERNAL instead of UNIMPLEMENTED when the server uses an unsupported compressor. This is consistent with the [gRPC compression spec](https://redirect.github.com/grpc/grpc/blob/master/doc/compression.md#compression-method-asymmetry-between-peers). ([#7461](https://redirect.github.com/grpc/grpc-go/issues/7461)) - Special Thanks: [@Gayathri625](https://redirect.github.com/Gayathri625) - transport: Fix a bug which could result in writes busy looping when the underlying `conn.Write` returns errors ([#7394](https://redirect.github.com/grpc/grpc-go/issues/7394)) - Special Thanks: [@veshij](https://redirect.github.com/veshij) - client: fix race that could lead to orphaned connections and associated resources. ([#7390](https://redirect.github.com/grpc/grpc-go/issues/7390)) - xds: use locality from the connected address for load reporting with pick_first ([#7378](https://redirect.github.com/grpc/grpc-go/issues/7378)) - without this fix, if a priority contains multiple localities with pick_first, load was reported for the wrong locality - client: prevent hanging during ClientConn.Close() when the network is unreachable ([#7540](https://redirect.github.com/grpc/grpc-go/issues/7540)) ### Performance Improvements - transport: double buffering is avoided when using an http connect proxy and the target server waits for client to send the first message. ([#7424](https://redirect.github.com/grpc/grpc-go/issues/7424)) - codec: Implement a new `Codec` which uses buffer recycling for encoded message ([#7356](https://redirect.github.com/grpc/grpc-go/issues/7356)) - introduce a `mem` package to facilitate buffer reuse ([#7432](https://redirect.github.com/grpc/grpc-go/issues/7432)) - Special Thanks: [@PapaCharlie](https://redirect.github.com/PapaCharlie) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> * [vcenterreceiver] Updated units on several metrics (#34946) **Description:** <Describe what has changed.>  The following change works to update several metrics units to be more inline with the semantics declared here: https://opentelemetry.io/docs/specs/semconv/general/metrics/#instrument-units Specifically it changes all the uses of `sec` to `s` and also updates the incorrect unit usage of `{MHz}` to `MHz` on a couple metrics. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> All golden package tests were updated, as well as integration tests. **Documentation:** <Describe the documentation added.> Documentation was updated with mdatagen with the use of `make generate` * Update module github.com/SAP/go-hdb to v1.12.0 (#34973) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/SAP/go-hdb](https://redirect.github.com/SAP/go-hdb) | `v1.11.3` -> `v1.12.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fSAP%2fgo-hdb/v1.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fSAP%2fgo-hdb/v1.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fSAP%2fgo-hdb/v1.11.3/v1.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fSAP%2fgo-hdb/v1.11.3/v1.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>SAP/go-hdb (github.com/SAP/go-hdb)</summary> ### [`v1.12.0`](https://redirect.github.com/SAP/go-hdb/blob/HEAD/RELEASENOTES.md#v1120) [Compare Source](https://redirect.github.com/SAP/go-hdb/compare/v1.11.3...v1.12.0) ##### Changes - Changed 'prometheus' into own go module to reduce dependencies on go-hdb. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com> * [chore][pkg/stanza] Speed up file deduplication in finder (#34888) **Description:** <Describe what has changed.> For large numbers of files, the logic that deduplicates the filenames between matches is costly. This is mainly due to the O(n^2) deduping algorithm used. If we instead use a map (as a hashset), we can make this ~O(n). This PR speeds up the deduplication logic, as well as adds a benchmark for a case where the filelog receiver is polling many files at once. **Testing:** <Describe what testing was performed and which tests were added.> Running the added benchmark and comparing with benchstat, we can see a large increase in speed for the large number of files case (10000 monitored files), at the cost of a very slight increase in memory usage: ``` goos: darwin goarch: arm64 pkg: github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/matcher/internal/finder cpu: Apple M3 Pro │ old.txt │ new.txt │ │ sec/op │ sec/op vs base │ Find10kFiles-12 198.636m ± 6% 8.696m ± 16% -95.62% (p=0.002 n=6) │ old.txt │ new.txt │ │ B/op │ B/op vs base │ Find10kFiles-12 5.416Mi ± 0% 5.581Mi ± 0% +3.04% (p=0.002 n=6) │ old.txt │ new.txt │ │ allocs/op │ allocs/op vs base │ Find10kFiles-12 80.06k ± 0% 80.25k ± 0% +0.23% (p=0.002 n=6) ``` * [receiver/mysql] client, convert NULL to int64 (#34411) **Description:** <Describe what has changed.> bug fix, receiver/mysql client.go raise error when the TABLE_ROWS column is NULL, fix it in the SQL query, convert the NULL to 0. **Link to tracking Issue:** <Issue number if applicable> https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34195 **Testing:** <Describe what testing was performed and which tests were added.> run command "make test" in the receiver/mysqlreceiver, all the test case passed. **Documentation:** <Describe the documentation added.> --------- Signed-off-by: Jian Li <jian.li2@fmr.com> * [testbed] - Add scenarios to handle large files (#34417) **Description:** Add test cases covering large files to existing testbed. This PR adds following scenarios: Scenario 1: Ensure that all logs are captured for files that reach a size of 2GB. Scenario 2: Ensure that all logs are captured for files that reach a size of 6GB Scenario 3: Ensure that all logs are captured for a file of approximately 1.5GB that contains prewritten data. **Link to tracking Issue:** https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34288 **Testing:** Added --------- Co-authored-by: Antoine Toulme <antoine@toulme.name> * Avoid rendering the whole event to get only the provider name (#34914) **Description:** The code was always getting the event as a XML string that was unmarshalled into a type only to obtain the provider name. That can be done in a cheaper fashion by requesting the `System` properties of the event and reading only the provider name. **Link to tracking Issue:** Fixes #34755 **Testing:** The benchmark below is only good to compare memory usage, which shows that this change is already beneficial. See the changes for the benchmark code. ```terminal goos: windows goarch: amd64 pkg: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/windowseventlogreceiver cpu: Intel(R) Core(TM) i9-10885H CPU @ 2.40GHz │ .\old.txt │ .\pr.txt │ │ sec/op │ sec/op vs base │ ReadWindowsEventLogger/10-16 1.255 ± 0% 1.255 ± 0% ~ (p=0.912 n=10) ReadWindowsEventLogger/100-16 1.379 ± 9% 1.256 ± 0% ~ (p=0.190 n=10) ReadWindowsEventLogger/1_000-16 2.633 ± 5% 2.507 ± 0% ~ (p=0.063 n=10) geomean 1.658 1.581 -4.62% │ .\old.txt │ .\pr.txt │ │ B/op │ B/op vs base │ ReadWindowsEventLogger/10-16 3.228Mi ± 6% 2.190Mi ± 8% -32.17% (p=0.000 n=10) ReadWindowsEventLogger/100-16 5.399Mi ± 42% 2.276Mi ± 4% -57.85% (p=0.000 n=10) ReadWindowsEventLogger/1_000-16 26.12Mi ± 8% 17.66Mi ± 4% -32.38% (p=0.000 n=10) geomean 7.693Mi 4.448Mi -42.18% │ .\old.txt │ .\pr.txt │ │ allocs/op │ allocs/op vs base │ ReadWindowsEventLogger/10-16 67.18k ± 7% 44.74k ± 9% -33.40% (p=0.000 n=10) ReadWindowsEventLogger/100-16 112.87k ± 42% 46.69k ± 4% -58.64% (p=0.000 n=10) ReadWindowsEventLogger/1_000-16 551.6k ± 8% 368.0k ± 4% -33.28% (p=0.000 n=10) geomean 161.1k 91.61k -43.14% ``` **Documentation:** N/A * [chore] add Tyler to CODEOWNERS for githubreceiver (#34963) **Description:** Adding @TylerHelmuth (GitHub Actions Receiver component sponsor) as codeowner in the GitHub Receiver after the decision to incorporate the tracing and log capability mentioned in #27460 into the GitHub receiver was made. * Update README.md (#34990) I think this URL has changed? * [extension/opamp] Add support for polling interval in HTTP client (#34811) **Description:** <Describe what has changed.>  Adds support for configuring polling interval for the OpAMP HTTP client. **Link to tracking Issue:** #34749 **Testing:** Adjusted unit test, manually tested **Documentation:** Added to README --------- Signed-off-by: Matej Gera <matejgera@gmail.com> Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com> * [receiver/apache] Invalid endpoint should not cause panic (#34992) **Description:** The receiver crashes if it fails to parse the endpoint. **Link to tracking Issue:** N/A **Testing:** Add a test covering this case. **Documentation:** Changelog updated. * [chore]: enable compares and empty rules from testifylint (#34976) #### Description Testifylint is a linter that provides best practices with the use of testify. This PR enables [compares](https://github.com/Antonboom/testifylint?tab=readme-ov-file#compares) and [empty](https://github.com/Antonboom/testifylint?tab=readme-ov-file#empty) rules from [testifylint](https://github.com/Antonboom/testifylint) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * [receiver/githubreceiver] promote githubreceiver to alpha status (#34960) **Description:** Promotes the GitHub receiver to alpha status --------- Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com> * [connector/datadog] Improve performance in cases with many peer tags (#34945) **Description:** Improves performance of Datadog connector when there are many peer tags and `connector.datadogconnector.NativeIngest` is enabled **Link to tracking Issue:** Related to https://github.com/DataDog/datadog-agent/pull/28908 **Testing:** Added new benchmark tests, results: ``` % go test -bench . -benchmem -benchtime=1000x goos: darwin goarch: arm64 pkg: github.com/open-telemetry/opentelemetry-collector-contrib/connector/datadogconnector cpu: Apple M1 Max BenchmarkPeerTags_Native-10 1000 22851735 ns/op 9147 B/op 118 allocs/op BenchmarkPeerTags_Legacy-10 1000 27704684 ns/op 12157 B/op 152 allocs/op PASS ``` * [chore] upgrading pulsar client v0.13.1 (#34951) **Description:** Upgraded client and fix https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/34213 * [processor/interval] Update config structure for interval processor (#34926) **Description:** This PR addresses comments made in #34805 after it was merged The gist is change in configuration from ```yaml interval: 60s gauge_pass_through: false summary_pass_through: false ``` to ```yaml interval: 60s pass_through: gauge: false summary: false ``` **Link to tracking Issue:** #34920 Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> * [extension/solarwindsapmsettingsextension] Added remaining implementation of solarwindsapmsettingsextension (#33315) **Description:** <Describe what has changed.>  - Added logic for `refresh` function **Link to tracking Issue:** <Issue number if applicable> [27668](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/27668) **Testing:** <Describe what testing was performed and which tests were added.> Manually tested against test server ``` extensions: solarwindsapmsettings: endpoint: "apm-testcollector.click:443" key: "any:any" service: extensions: [solarwindsapmsettings] ``` **Documentation:** <Describe the documentation added.> - Updated README to remove the support of `/tmp/solarwinds-apm-settings-raw` file --------- Co-authored-by: Antoine Toulme <antoine@toulme.name> * feat: Support Prometheus Created Timestamps (#34596) **Description:** exporter/prometheusexporter now supports Prometheus Created Timestamps. **Link to tracking Issue:** Fix #32521 **Testing:** Unit tests were extended with the new scope **Documentation:** No documentation was added so far, looking for direction about where would be the best place for it :) Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> * [receiver/sqlquery] support attributes for logs (#34599) **Description:** Introduced a new configuration option, attribute_columns, for log queries. This option was already available for metric queries. Note: If an attribute column is missing in the result set, the collection process fails with an error to maintain consistency with metric query behaviour. Conversely, in the existing implementation, if the body column is absent, log body will be populated with an empty string. For consistency, it might be preferable for both behaviours to align. However, since this could introduce a breaking change, it may be more appropriate to implement this adjustment in a separate PR. **Link to tracking Issue:** [24459](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/24459) **Testing:** Added column `attribute` in test set, and verification in the integration test **Documentation:** Migrated description for `attribute_columns` from metrics queries section to general "Queries" section, updated example configuration --------- Co-authored-by: Curtis Robert <crobert@splunk.com> * [receiver/kafkareceiver]: allow tunable fetch sizes (#34431) **Description:** This commit adds the ability to tune the minimum, default and maximum fetch sizes for the Kafka Receiver in the OpenTelemetry configuration file. The defaults are kept consistent with the defaults imposed by [sarama](https://pkg.go.dev/github.com/shopify/sarama#Config) **Link to tracking Issue:** Resolves https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/22741 **Testing:** Built the image with `make docker-otelcontribcol`, uploaded to [Docker Hub](https://hub.docker.com/r/ckaczynski/otelcontribcol) to pull the image into our Kubernetes deployment, and hit the cluster with 200k logs per second with the following settings: ``` default_fetch_size: 15728640 # 15MB max_fetch_size: 31457280 # 30MB min_fetch_size: 1048576 # 1MB ``` These limits are absurdly high for no reason other than because I just wanted to set them higher and see how far I could push it in our cluster. No new tests were added, but added to existing configuration tests in config.go and factory.go **Documentation:** Added the new configuration options to the receiver's README --------- Co-authored-by: Israel Blancas <iblancasa@gmail.com> Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com> * [exporter/splunkhec] drop empty log events (#34871) **Description:** Drop empty log events Log records with no body are dropped by Splunk on reception as they contain no log message, albeit they may have attributes. This PR removes those logs from consideration to be exported. This is in tune with the behavior of splunkhecreceiver, which refuses HEC events with no event (#19769) * [exporter/signalfx] Fix goroutine leaks (#32781) **Description:** This change is a refactor to allow us to enable `goleak` checks in each of the exporter's sub-directories, as well as the signalfx receiver (which uses the signalfxexporter in a test). The main idea is to use `start`/`shutdown` for each package's functionality, rather than relying on the top level context cancel of the exporter. The addition of start and shutdowns for each package means we can more closely control the lifecycle of each as needed, and enable `goleak` for each package. The memory leaks being fixed are: 1. Call the `TTLMap.Shutdown` so the ticker is properly stopped: `t.prevPts.Shutdown()`. 2. Don't block waiting for a request if the context is cancelled. **Link to tracking issue:** #30438 --------- Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com> * [chore] make update-otel to 48b11ba (#34956) Bumps core libraries to open-telemetry/opentelemetry-collector@48b11ba1c5f83497aa09604a7d0ac7e7c3d93a5d --------- Signed-off-by: Pablo Baeyens <pablo.baeyens@datadoghq.com> * [chore][receiver/filelog] Change plaintext name: filelog -> file log (#34984) **Description:** <Describe what has changed.>  Updated the name of the file log receiver to be two words. Updated some references as well where I thought it made sense, reviewers are welcome to suggest changes. **Link to tracking Issue:** <Issue number if applicable> Resolves #34943 * [chore] Fix flaky test by ignoring metrics order (#35002) See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10696785646/job/29652663151?pr=34985#step:6:570 * fix: handle OTLPJSON unmarshal error (#34784) **Description:** <Describe what has changed.>  Handles the error that the Unmarshaler can return in case an invalid OTLPJSON is provided, this avoids sending a nil signal to the corresponding consumer. The fix logs the error and continues the execution: ```go t, err := tracesUnmarshaler.UnmarshalTraces([]byte(token.AsString())) if err != nil { c.logger.Error("could extract traces from otlp json", zap.Error(err)) continue } ``` **Link to tracking Issue:** <Issue number if applicable> https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/34782 **Testing:** <Describe what testing was performed and which tests were added.> Factory tests moved to connector tests using the `golden` + compare testing packages. Testdata includes a file with an invalid json for each signal. **Documentation:** <Describe the documentation added.> NA * [chore] Fix flaky test in filelog receiver (#35012) Quick fix for https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/35007. Ideally we should not need to depend on order of files returned from the finder but there are apparently some subtle implications which need to be better understood before we remove the assumption. * Bump github.com/opencontainers/runc from 1.1.13 to 1.1.14 in /cmd/otelcontribcol (#34991) Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc) from 1.1.13 to 1.1.14. <details> <summary>Release notes</summary> Sourced from <a href="/opencontainers/runc/releases">github.com/opencontainers/runc's releases</a>. <blockquote> <h2>runc v1.1.14 -- "年を取っていいことは、驚かなくなることね。"</h2> This is the fourteenth patch release in the 1.1.z release branch of runc. It includes a fix for a low severity security issue (CVE-2024-45310) as well as some minor build-related fixes (including Go 1.23 support). <ul> <li>Fix <a href="/opencontainers/runc/security/advisories/GHSA-jfvp-7x6p-h2pv">CVE-2024-45310</a>, a low-severity attack that allowed maliciously configured containers to create empty files and directories on the host.</li> <li>Add support for Go 1.23. (<a href="https://redirect.github.com/opencontainers/runc/issues/4360">#4360</a>, <a href="https://redirect.github.com/opencontainers/runc/issues/4372">#4372</a>)</li> <li>Revert "allow overriding VERSION value in Makefile" and add EXTRA_VERSION. (<a href="https://redirect.github.com/opencontainers/runc/issues/4370">#4370</a>, <a href="https://redirect.github.com/opencontainers/runc/issues/4382">#4382</a>)</li> <li>rootfs: consolidate mountpoint creation logic. (<a href="https://redirect.github.com/opencontainers/runc/issues/4359">#4359</a>)</li> </ul> <h3>Static Linking Notices</h3> The <code>runc</code> binary distributed with this release are statically linked with the following <a href="https://www.gnu.org/licenses/old-licenses/lgpl-2.1.en.html">GNU LGPL-2.1</a> licensed libraries, with <code>runc</code> acting as a "work that uses the Library": <ul> <li><a href="/seccomp/libseccomp">libseccomp</a></li> </ul> The versions of these libraries were not modified from their upstream versions, but in order to comply with the LGPL-2.1 (§6(a)), we have attached the complete source code for those libraries which (when combined with the attached runc source code) may be used to exercise your rights under the LGPL-2.1. However we strongly suggest that you make use of your distribution's packages or download them from the authoritative upstream sources, especially since these libraries are related to the security of your containers.  Thanks to all of the contributors who made this release possible: <ul> <li>Akihiro Suda <a href="mailto:akihiro.suda.cz@hco.ntt.co.jp">akihiro.s…

**Description:** This change is a refactor to allow us to enable `goleak` checks in each of the exporter's sub-directories, as well as the signalfx receiver (which uses the signalfxexporter in a test). The main idea is to use `start`/`shutdown` for each package's functionality, rather than relying on the top level context cancel of the exporter. The addition of start and shutdowns for each package means we can more closely control the lifecycle of each as needed, and enable `goleak` for each package. The memory leaks being fixed are: 1. Call the `TTLMap.Shutdown` so the ticker is properly stopped: `t.prevPts.Shutdown()`. 2. Don't block waiting for a request if the context is cancelled. **Link to tracking issue:** open-telemetry#30438 --------- Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>

github-actions · 2024-09-18T03:32:15Z

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Related to #30438 --------- Signed-off-by: Israel Blancas <iblancas@redhat.com> Co-authored-by: Curtis Robert <crobert@splunk.com>

crobert-1 added enhancement New feature or request needs triage New item requiring triage labels Jan 11, 2024

crobert-1 self-assigned this Jan 11, 2024

crobert-1 mentioned this issue Jan 11, 2024

[chore] Enable all (passing) goleak checks #30451

Merged

This was referenced Jan 11, 2024

[chore] Enable goleak for tests failing on opencensus-go #30457

Merged

[mdatagen] Automatically generate goleak tests for packages #30483

Closed

github-actions bot mentioned this issue Jan 16, 2024

Weekly Report: 2024-01-09 - 2024-01-16 #30565

Closed

crobert-1 removed the needs triage New item requiring triage label Jan 17, 2024

This was referenced Jan 26, 2024

goroutine leak detected in throttleManager.Stop microsoft/ApplicationInsights-Go#70

Open

[exporter/azuremonitor] Fix memory leaks on shutdown #30801

Closed

[chore][exporter/coralogixexporter] Enable goleak check #30803

Merged

codeboten pushed a commit that referenced this issue May 21, 2024

[chore][exporter/pulsar] Enable goleak (#33135)

eb06690

This is a test only change, adding `goleak` to help ensure no goroutines are being leaked. This passed in local testing without any changes. #30438 `goleak` is passing

codeboten pushed a commit that referenced this issue May 22, 2024

[chore][receiver/jmx/internal/subprocess] Enable goleak check (#31773)

91e4b9c

This originally was failing in CI/CD, but has passed 10+ times in a row, I think it's safe to merge. **Link to tracking Issue:** #30438

github-actions bot added the Stale label Sep 18, 2024

mx-psi removed the Stale label Sep 18, 2024

iblancasa mentioned this issue Sep 18, 2024

[chore] Enable goleak in kubeletstatsreceiver #35277

Closed

crobert-1 added the never stale Issues marked with this label will be never staled and automatically removed label Sep 18, 2024

This was referenced Sep 18, 2024

[chore] Enable goleak in k8sclusterreceiver #35279

Closed

[chore] Enable goleak oidcauthextension #35282

Merged

mauri870 mentioned this issue Oct 7, 2024

[exporter/elasticsearch] goroutine leaks in tests #35638

Open

MovieStoreGuy pushed a commit that referenced this issue Oct 9, 2024

[chore] Enable goleak oidcauthextension (#35282)

aa89dc7

Related to #30438 --------- Signed-off-by: Israel Blancas <iblancas@redhat.com> Co-authored-by: Curtis Robert <crobert@splunk.com>

github-actions bot mentioned this issue Nov 4, 2024

Link Checker Report signalfx/splunk-otel-collector#5578

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable and enforce goleak in all packages #30438

Enable and enforce goleak in all packages #30438

crobert-1 commented Jan 11, 2024

crobert-1 commented Jan 11, 2024 •

edited

Loading

crobert-1 commented Jan 11, 2024

crobert-1 commented Jan 11, 2024 •

edited

Loading

crobert-1 commented Jan 12, 2024 •

edited

Loading

github-actions bot commented Sep 18, 2024

Enable and enforce goleak in all packages #30438

Enable and enforce goleak in all packages #30438

Comments

crobert-1 commented Jan 11, 2024

Component(s)

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

crobert-1 commented Jan 11, 2024 • edited Loading

crobert-1 commented Jan 11, 2024

crobert-1 commented Jan 11, 2024 • edited Loading

crobert-1 commented Jan 12, 2024 • edited Loading

github-actions bot commented Sep 18, 2024

crobert-1 commented Jan 11, 2024 •

edited

Loading

crobert-1 commented Jan 11, 2024 •

edited

Loading

crobert-1 commented Jan 12, 2024 •

edited

Loading