Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][receiver/awsxray] Enable goleak checks #32402

Merged
merged 1 commit into from
Apr 16, 2024
Merged

[chore][receiver/awsxray] Enable goleak checks #32402

merged 1 commit into from
Apr 16, 2024

Conversation

crobert-1
Copy link
Member

Description:

Enable goleak checks in the internal/udppoller package of the AWS X-Ray receiver to help ensure no goroutines are being leaked. This is a test only change, simply adding a few missing Close calls.

Link to tracking Issue:
#30438

Testing:
All existing tests as well as added goleak checks are passing.

@crobert-1 crobert-1 requested review from a team and bogdandrutu April 15, 2024 22:31
@crobert-1 crobert-1 mentioned this pull request Apr 15, 2024
Open
@codeboten codeboten merged commit 3deea1b into open-telemetry:main Apr 16, 2024
171 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@srprash srprash Awaiting requested review from srprash

@wangzlei wangzlei Awaiting requested review from wangzlei

Assignees

@Aneurysm9 Aneurysm9

Labels
receiver/awsxray
Projects
None yet
Milestone
v0.99.0
Development

Successfully merging this pull request may close these issues.
3 participants
@crobert-1 @codeboten @Aneurysm9