Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][cmd/telemetrygen] Enable goleak #31724

Merged
merged 1 commit into from
Mar 13, 2024
Merged

[chore][cmd/telemetrygen] Enable goleak #31724

merged 1 commit into from
Mar 13, 2024

Conversation

crobert-1
Copy link
Member

Description:

Enables goleak checks for telemetrygen to help ensure no goroutines are being leaked.

Link to tracking Issue:
#30438

Testing:
All existing tests are passing, as well as added goleak check.

@github-actions github-actions bot added the cmd/telemetrygen telemetrygen command label Mar 12, 2024
@crobert-1 crobert-1 mentioned this pull request Mar 12, 2024
Open
@crobert-1 crobert-1 marked this pull request as ready for review March 12, 2024 23:49
@crobert-1 crobert-1 requested a review from a team March 12, 2024 23:49
@mx-psi mx-psi merged commit 7a1a9c4 into open-telemetry:main Mar 13, 2024
145 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner

Assignees

@andrzej-stencel andrzej-stencel

Labels
cmd/telemetrygen telemetrygen command
Projects
None yet
Milestone
v0.97.0
Development

Successfully merging this pull request may close these issues.
3 participants
@crobert-1 @mx-psi @andrzej-stencel