-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus exporters: graduate pkg.translator.prometheus.NormalizeName feature gate #26488
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This requires new configuration options in the prometheus components based on this comment right? Disregard: I missed the last sentence in the issue where the configuration option is now present. |
I believe this issue will track the feature gate until it graduates to stable |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
## Which problem is this PR solving? Document the troubleshooting steps taken while investigating [this support question](https://cloud-native.slack.com/archives/CGG7NFUJ3/p1699539239671519). One of the problems faced by users was caused by [OpenTelemetry Collector Contrib v0.85.0](https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.85.0) introducing a breaking change to enable normalized metric names by default: > `prometheusexporters`: Append prometheus type and unit suffixes by default in prometheus exporters. (open-telemetry/opentelemetry-collector-contrib#26488) Suffixes can be disabled by setting add_metric_suffixes to false on the exporter. Relates to: jaegertracing/jaeger#4957 ## Description of the changes - Adds the following troubleshooting guides: - Inspecting the Prometheus queries that Jaeger makes to fetch data for the Monitor tab. - Inspecting OpenTelemetry config to troubleshoot a possible cause for missing error metrics. - Updates only made from when SPM defaulted to supporting the spanmetrics connector, which was [v1.49.0](https://github.com/jaegertracing/jaeger/releases/tag/v1.49.0). ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits ~- [ ] I have added unit tests for the new functionality~ ~- [ ] I have run lint and test steps successfully~ --------- Signed-off-by: Albert Teoh <albert@packsmith.io> Co-authored-by: Albert Teoh <albert@packsmith.io>
## Which problem is this PR solving? [OpenTelemetry Collector Contrib v0.85.0](https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.85.0) introduces a breaking change to enable normalized metric names by default: > `prometheusexporters`: Append prometheus type and unit suffixes by default in prometheus exporters. (open-telemetry/opentelemetry-collector-contrib#26488) Suffixes can be disabled by setting add_metric_suffixes to false on the exporter. Motivated by [this support question](https://cloud-native.slack.com/archives/CGG7NFUJ3/p1699539239671519). ## Description of the changes - Updates the otel version in the example to the latest v0.89.0 release, which includes this breaking change. - Enable normalized metric name support. - Jaeger documentation/troubleshooting tips relating to this problem will added in another PR. ## How was this change tested? - Ran locally before the change to confirm no metrics appeared in the Monitor tab after only version bump of OTEL image to v0.89.0. - Added the `PROMETHEUS_QUERY_NORMALIZE_CALLS=true` and `PROMETHEUS_QUERY_NORMALIZE_DURATION=true` env vars to confirm metrics appear again. <img width="1709" alt="Screenshot 2023-11-18 at 12 31 16 pm" src="https://github.com/jaegertracing/jaeger/assets/26584478/d36bc6bc-e99f-4858-903b-30da9aedda67"> ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits ~- [ ] I have added unit tests for the new functionality~ ~- [ ] I have run lint and test steps successfully~ Signed-off-by: Albert Teoh <albert@packsmith.io> Co-authored-by: Albert Teoh <albert@packsmith.io>
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Component(s)
exporter/prometheus
Description
Second try at #20518.
We have addressed issues that arose from the initial implementation:
pkg.translator.prometheus.NormalizeName
feature gate #23208It is still possible for users to disable normalization in exporters by setting the
add_metric_suffixes
configuration option to false.The text was updated successfully, but these errors were encountered: