Normalize metric names due to breaking change #4957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albert Teoh <albert@packsmith.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4957 +/- ##
==========================================
+ Coverage 96.44% 96.47% +0.02%
==========================================
Files 304 304
Lines 18049 18049
==========================================
+ Hits 17408 17413 +5
+ Misses 508 504 -4
+ Partials 133 132 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2 tasks
yurishkuro
pushed a commit
to jaegertracing/documentation
that referenced
this pull request
Nov 18, 2023
## Which problem is this PR solving? Document the troubleshooting steps taken while investigating [this support question](https://cloud-native.slack.com/archives/CGG7NFUJ3/p1699539239671519). One of the problems faced by users was caused by [OpenTelemetry Collector Contrib v0.85.0](https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.85.0) introducing a breaking change to enable normalized metric names by default: > `prometheusexporters`: Append prometheus type and unit suffixes by default in prometheus exporters. (open-telemetry/opentelemetry-collector-contrib#26488) Suffixes can be disabled by setting add_metric_suffixes to false on the exporter. Relates to: jaegertracing/jaeger#4957 ## Description of the changes - Adds the following troubleshooting guides: - Inspecting the Prometheus queries that Jaeger makes to fetch data for the Monitor tab. - Inspecting OpenTelemetry config to troubleshoot a possible cause for missing error metrics. - Updates only made from when SPM defaulted to supporting the spanmetrics connector, which was [v1.49.0](https://github.com/jaegertracing/jaeger/releases/tag/v1.49.0). ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits ~- [ ] I have added unit tests for the new functionality~ ~- [ ] I have run lint and test steps successfully~ --------- Signed-off-by: Albert Teoh <albert@packsmith.io> Co-authored-by: Albert Teoh <albert@packsmith.io>
yurishkuro
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
OpenTelemetry Collector Contrib v0.85.0 introduces a breaking change to enable normalized metric names by default:
Motivated by this support question.
Description of the changes
How was this change tested?
PROMETHEUS_QUERY_NORMALIZE_CALLS=trueandPROMETHEUS_QUERY_NORMALIZE_DURATION=trueenv vars to confirm metrics appear again.Checklist
- [ ] I have added unit tests for the new functionality- [ ] I have run lint and test steps successfully